palemoon 32.5.0 build changes Topic is solved

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
stefan11111
Apollo supporter
Apollo supporter
Posts: 30
Joined: 2023-08-13, 18:09

palemoon 32.5.0 build changes

Unread post by stefan11111 » 2023-11-04, 10:03

I build palemoon using this .mozconfig(generated by an ebuild on gentoo):

Code: Select all

ac_add_options --enable-application=palemoon
ac_add_options --disable-updater
ac_add_options --disable-accessibility
ac_add_options --disable-gconf
ac_add_options --disable-webrtc
ac_add_options --enable-strip
ac_add_options --enable-install-strip
ac_add_options --disable-eme
ac_add_options --disable-gamepad
ac_add_options --enable-system-ffi
ac_add_options --enable-system-extension-dirs
ac_add_options --enable-system-pixman
ac_add_options --enable-optimize="-O2 -msse2 -mfpmath=sse"
ac_add_options --with-pthreads
ac_add_options --disable-debug
ac_add_options --enable-jemalloc
ac_add_options --disable-dbus
ac_add_options --enable-default-toolkit="cairo-gtk3"
ac_add_options --disable-necko-wifi
ac_add_options --disable-pulseaudio
ac_add_options --disable-precompiled-startupcache
mk_add_options PYTHON=/usr/bin/python2
mk_add_options AUTOCONF=/usr/bin/autoconf-2.13
mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/o
When building palemoon 32.5.0, this happens:

Code: Select all

 0:03.14 Reexecuting in the virtualenv
 0:03.29 Adding configure options from /var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/.mozconfig
 0:03.29   --enable-application=palemoon
 0:03.29   --disable-updater
 0:03.29   --disable-accessibility
 0:03.30   --disable-gconf
 0:03.30   --disable-webrtc
 0:03.30   --enable-strip
 0:03.30   --enable-install-strip
 0:03.30   --disable-eme
 0:03.30   --disable-gamepad
 0:03.30   --enable-system-ffi
 0:03.30   --enable-system-extension-dirs
 0:03.30   --enable-system-pixman
 0:03.30   --enable-optimize=-O2 -msse2 -mfpmath=sse
 0:03.30   --with-pthreads
 0:03.30   --disable-debug
 0:03.30   --enable-jemalloc
 0:03.30   --disable-dbus
 0:03.30   --enable-default-toolkit=cairo-gtk3
 0:03.30   --disable-necko-wifi
 0:03.30   --disable-pulseaudio
 0:03.30   --disable-precompiled-startupcache
 0:03.30   BASH_ARGC=([0]="4")
 0:03.30   BASH_ARGV=([0]="/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/platform/python/mozbuild/mozbuild/action/dump_env.py" [1]="/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/o/_virtualenv/bin/python" [2]="/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/.mozconfig" [3]="/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/platform")
 0:03.42 checking for a shell... /bin/sh
 0:03.46 checking for host system type... x86_64-pc-linux-gnu
 0:03.46 checking for target system type... x86_64-pc-linux-gnu
 0:03.46 Traceback (most recent call last):
 0:03.46   File "/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/configure.py", line 32, in <module>
 0:03.46     sys.exit(main(sys.argv))
 0:03.46   File "/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/configure.py", line 24, in main
 0:03.46     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
 0:03.46   File "/var/tmp/portage/www-client/palemoon-32.5.0/work/palemoon-32.5.0/platform/python/mozbuild/mozbuild/configure/__init__.py", line 360, in run
 0:03.46     raise InvalidOptionError('Unknown option: %s' % without_value)
 0:03.46 mozbuild.configure.options.InvalidOptionError: Unknown option: --disable-eme
 0:03.48 *** Fix above errors and then restart with\
 0:03.48                "/usr/bin/gmake -f client.mk build"
 0:03.48 gmake: *** [client.mk:370: configure] Error 1
Did any build options change between 32.4.1 and 32.5.0?
Palemoon 32.4.1 built fine with this .mozconfig, and it is the browser I'm writing this on.
I see it complains about --disable-eme. Did the option do disable drm change?

Potkeny
Fanatic
Fanatic
Posts: 132
Joined: 2018-08-03, 17:00

Re: palemoon 32.5.0 build changes

Unread post by Potkeny » 2023-11-04, 10:45

Release notes say
Removed the last vestiges of EME/DRM code from UXP, since this will never be supported in any application building on it due to the media industry's draconic policies around FOSS.
I guess it complains about disabling something which doesn't exist anymore?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35653
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: palemoon 32.5.0 build changes

Unread post by Moonchild » 2023-11-04, 11:32

It's right there in your output

Code: Select all

0:03.46 mozbuild.configure.options.InvalidOptionError: Unknown option: --disable-eme
remove that from your mozconfig.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
athenian200
Contributing developer
Contributing developer
Posts: 1537
Joined: 2018-10-28, 19:56
Location: Georgia

Re: palemoon 32.5.0 build changes

Unread post by athenian200 » 2023-11-04, 19:03

You can also comment it out, especially if you think you might have to build an older version of Pale Moon again for some reason and don't want to forget what the old option was.

Like this:

Code: Select all

# Used to build Pale Moon versions older than 32.5.0, don't use for anything newer.
# ac_add_options --disable-eme
I got kind of used to commenting out lines in my .mozconfig as Pale Moon evolves, especially since I do actually go back and build older versions for various reasons.

Still, I really probably should remove a lot of the cruft from my .mozconfig at some point... I have so many options that haven't been a thing for a couple of years. LOL.
"The Athenians, however, represent the unity of these opposites; in them, mind or spirit has emerged from the Theban subjectivity without losing itself in the Spartan objectivity of ethical life. With the Athenians, the rights of the State and of the individual found as perfect a union as was possible at all at the level of the Greek spirit." -- Hegel's philosophy of Mind