[Suggestion] Remove obsolete "contains" methods

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
Moonchild
Project founder
Project founder
Posts: 39291
Joined: 2011-08-28, 17:27
Location: Sweden

Re: [Suggestion] Remove obsolete "contains" methods

Post by Moonchild » 2023-10-19, 11:59

Off-topic:
dapgo wrote:
2023-10-19, 10:14
there where risks tend to 0 or just exposure has 0 impact on the user.

IMO. well informed users should have the power to decide what they want and how to use
While I agree to a point with that sentiment, removing all basic safeguards that are common sense is just as extreme as aiming for 0 vulnerabilities, ever.

You don't remove the railings from your stairs or gantries because you're careful walking on them, but also don't strap yourself in a harness that makes it physically impossible to ever fall. If you get my point.
Win XP at this point is like a railless gantry. Sure, you can use it safely if you have good balance, but if anything untoward happens you're pretty much screwed. I know there is a vocal minority of people who absolutely insist they want to keep using it out of some sense of desiring a never-changing computing environment, and that's why these forks endure. Does it make sense otherwise? Not really. I have no problem people wanting to use it in isolated environments either, but that's not the point of a modern browser, is it?

IOW: balance your safeguards. Don't go overboard in either direction.
"Praise from a narcissistic person is always a poison dart. They don't share the stage, so discernment matters." - Dr. Ramani
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
BenFenner
Keeps coming back
Keeps coming back
Posts: 911
Joined: 2015-06-01, 12:52
Location: US Southeast

Re: [Suggestion] Remove obsolete "contains" methods

Post by BenFenner » 2023-10-21, 05:14

athenian200 wrote:
2023-10-04, 12:26
I don't think we should do this without some kind of underlying security reason
If I am a web developer (and I happen to be one) and I target Pale Moon, I can be reasonably sure my web site will work on all contemporary browsers. Having these "legacy" (for lack of a better word) method aliases around when none of the other contemporary browsers support it anymore makes the (admittedly fanciful) practice of only targeting Pale Moon less effective.

Not that I expect this would ever effect me personally or professionally, but just wanted to voice this small point.

I can certainly see the argument for keeping them active, and I won't lose sleep over it either way.

User avatar
Moonchild
Project founder
Project founder
Posts: 39291
Joined: 2011-08-28, 17:27
Location: Sweden

Re: [Suggestion] Remove obsolete "contains" methods

Post by Moonchild » 2023-10-21, 09:21

BenFenner wrote:
2023-10-21, 05:14
I can be reasonably sure my web site will work on all contemporary browsers. Having these "legacy" (for lack of a better word) method aliases around when none of the other contemporary browsers support it anymore makes the (admittedly fanciful) practice of only targeting Pale Moon less effective.
It's always good practice to double-check in other browsers before publishing, of course. But I do get your point and it's why I generally do follow the standards and want to remove things that have been dropped when they are actually not supposed to be in use any longer.

I just don't see a point of quickly removing this particular one because of the potential impact. If people can do the leg work and investigate the scope of impact of this, then I am in a better position to know whether this should go or not, but I'm not just going by the flat "it has changed in the standard so should go" when it's a simple, and very widely-used function that was active for a long time in JS (and why I was actually against renaming it to begin with!). The longer and more widely something was active before it was removed, the longer of a "run out" period there should be after it's been dropped from the standard.
"Praise from a narcissistic person is always a poison dart. They don't share the stage, so discernment matters." - Dr. Ramani
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite