FreeBSD tarball compression

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

FreeBSD tarball compression

Unread post by jobbautista9 » 2023-04-03, 06:14

I noticed a while back that the tarballs for FreeBSD builds are compressed with bzip2, unlike GNU/Linux and Solaris which uses xz. Is there a reason why this is so (like xz not being used much in FreeBSD)? Would be nice to save megabytes of space each update on the server if there's no reason why we shouldn't use xz in FreeBSD.

I have a ready-made commit that can be cherry-picked that will make the packaging on FreeBSD the same as in Linux and Solaris.
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

dbsoft
Project Contributor
Project Contributor
Posts: 418
Joined: 2020-02-21, 17:35

Re: FreeBSD tarball compression

Unread post by dbsoft » 2023-04-03, 07:12

jobbautista9 wrote:
2023-04-03, 06:14
I have a ready-made commit that can be cherry-picked that will make the packaging on FreeBSD the same as in Linux and Solaris.
No particular reason, I just used the compression it picked automatically. I might have to install xz on the server but I am fine with that change. (Actually just checked it is installed as part of the base system under contributed works).

User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

Re: FreeBSD tarball compression

Unread post by jobbautista9 » 2023-04-03, 07:48

Cool. Can you test with this branch based on current master please and check if it breaks anything in FreeBSD packaging and spits out a tar.xz before I open a PR? Thanks!
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

dbsoft
Project Contributor
Project Contributor
Posts: 418
Joined: 2020-02-21, 17:35

Re: FreeBSD tarball compression

Unread post by dbsoft » 2023-04-03, 08:33

jobbautista9 wrote:
2023-04-03, 07:48
Cool. Can you test with this branch based on current master please and check if it breaks anything in FreeBSD packaging and spits out a tar.xz before I open a PR? Thanks!
Compiled and packaged successfully, saved about 9MB vs bzip2.

User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

Re: FreeBSD tarball compression

Unread post by jobbautista9 » 2023-04-03, 08:57

Thanks! Filed PR Issue #2188 (UXP)
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: FreeBSD tarball compression

Unread post by Moonchild » 2023-04-03, 09:41

Thanks! Merged in.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked