[Minor] GUI: Bookmark icon not reset properly

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
VADemon

[Minor] GUI: Bookmark icon not reset properly

Unread post by VADemon » 2020-06-26, 14:20

Bookmark icon doesn't appear yellow again after bookmarking a page and modifying the URL bar.

Steps:
  1. Go to a page that is not bookmarked
  2. Add page to bookmarks (using the star icon)
  3. -> Star icon now active (yellow color)
  4. In the URL bar start typing a new URL (green > arrow appears in place of bookmark icon)
  5. Press Escape to abort
  6. The star icon is now "inactive" despite this page being a bookmark
Now, interestingly if you slightly change the order and switch tabs in between it will work correctly:
  1. Go to a page that is not bookmarked
  2. Add page to bookmarks (using the star icon)
  3. -> Star icon now active (yellow color)
  4. In the URL bar start typing a new URL (green > arrow appears in place of bookmark icon)
  5. Switch to a different tab, then switch back
  6. Press Escape to abort
  7. The star icon is correct in yellow color
Palemoon: 28.10.0, 32-bit
OS: Ubuntu 18.04.4 LTS
XDG_CURRENT_DESKTOP=Unity:Unity7:ubuntu
GDMSESSION=unity

User avatar
adesh
Board Warrior
Board Warrior
Posts: 1277
Joined: 2017-06-06, 07:38

Re: [Minor] GUI: Bookmark icon not reset properly

Unread post by adesh » 2020-06-26, 14:54

Confirming it's a generic issue, and not dependent on the platform.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35473
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: [Minor] GUI: Bookmark icon not reset properly

Unread post by Moonchild » 2020-06-27, 01:44

Super low end priority corner case.
If you want this fixed, you'll most likely have to provide a patch yourself.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35473
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: [Minor] GUI: Bookmark icon not reset properly

Unread post by Moonchild » 2022-12-04, 12:56

"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked