Disabling UI with a command element

[moonbat]

Per the documentation, commands are a special case of broadcaster and should be used with menu items and buttons. My extension has a menu item and a button to open a window, and I want them to be disabled while the window is open.

I'm using a command for both in the overlay like this -

Code: Select all

	<commandset>
		<command id="myCommand" />
	</commandset>
	<menupopup id="menu_ToolsPopup">
		<menuitem id="menu-id" class="menu-iconic"
			label="&menu-label;"
			insertafter="appmenu_addons" command="myCommand" />
	</menupopup>
	<toolbarpalette id="BrowserToolbarPalette">
		<toolbarbutton id="button-id"
			class="toolbarbutton-1 chromeclass-toolbar-additional"
			label="&button.label;"
			command="myCommand" />
	</toolbarpalette>

In the Javascript, I'm doing

Code: Select all

	openWindow: function() {
		var windowtype = "mywindow";
		var wm = Cc["@mozilla.org/appshell/window-mediator;1"].getService(Ci.nsIWindowMediator);
		var existingWindow = wm.getMostRecentWindow(windowtype);
		var windowref = null;
		if (existingWindow) {
			existingWindow.focus();
		}
		else {
			windowref = window.open("chrome://myextension/content/mywindow.xul", "mywindow",
				  "chrome,width=640,height=480,resizable=yes,dialog,alwaysRaised,centerscreen");
		}
		document.getElementById('myCommand').setAttribute("disabled","true");
		windowref.addEventListener("unload",closeWindow,false);
	},
	closeWindow:function (){
		console.log("Inside window close");
	    document.getElementById('CmdSetPMPlayerOpenWindow').removeAttribute("disabled");
	}

This doesn't work, neither does setting the disabled attribute to true or "true" - the UI elements stay enabled when the window is opened. Is the command set supposed to be used this way? I tried using a separate broadcaster element instead but that didn't work either.

Also, the window close listener is called twice, both when opening and closing, why?

[Moonchild]

Why aren't you disabling them from the window load event, instead?

[moonbat]

Do you mean the window load for the extension? The openWindow function is the window load handler for the extension's window, triggered by myCommand. So I want to disable the button after it has been clicked to open the window, and enable it again when the window is closed.

[Moonchild]

What I meant was disabling the button from the window you are opening, in the load handler in the opened window.
And enable it again in the unload handler of the window. So, let the pop-up control the button state.