WebRTC in Pale Moon build output

Talk about code development, features, specific bugzilla bugs, enhancements, patches, and other highly technical things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific referenced Bugzilla bugs, mercurial, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Most "bug reports" do not belong in this board and should initially be posted in Community Support or other relevant support boards.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
Post Reply
User avatar
adesh
Board Warrior
Board Warrior
Posts: 1045
Joined: 2017-06-06, 07:38

WebRTC in Pale Moon build output

Post by adesh » 2020-05-02, 10:18

While compiling Pale Moon today I noticed some mentions on webrtc in the build output.
During the early phase:

Code: Select all

content_html.xpt
content_webrtc.xpt
content_xslt.xpt
And then later in compilation step:

Code: Select all

libimage.a.desc
libeditor_composer.a.desc
libdom_media_webrtc.a.desc
libdom_xslt_xslt.a.desc
Does it mean that some portion of WebRTC is built but is not functional? Or is it more than that? Is is just because "media" is intertwined with this stuff?

I was building on Mac and have --disable-webrtc (not needed probably) in the mozconfig.

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 7339
Joined: 2012-10-09, 19:37
Location: Binary Outcast

Re: WebRTC in Pale Moon build output

Post by New Tobin Paradigm » 2020-05-02, 10:29

There is some dom plumbing that gets built but it does nothing except satisfy callsites but is otherwise no-op.. Check MOZ_WEBRTC in the dom directory with xref. You can see.
Last edited by New Tobin Paradigm on 2020-05-02, 10:45, edited 1 time in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 27036
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: WebRTC in Pale Moon build output

Post by Moonchild » 2020-05-02, 10:33

Even if WebRTC isn't built, some headers are still exported and processed because the rest of the platform expects some definitions to be there; the platform has the capability of building WebRTC, after all. This can't always be neatly modularised. That doesn't mean any actually functional WebRTC capability is present in the final application or that it is more than a bit of ductwork. The same goes for some other components/features.
Even in the case a module is built because it's too entwined it doesn't mean the code is also exposed.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 7339
Joined: 2012-10-09, 19:37
Location: Binary Outcast

Re: WebRTC in Pale Moon build output

Post by New Tobin Paradigm » 2020-05-02, 10:43

Maybe later we can sort it but not anytime soon and it hardly matters.

User avatar
adesh
Board Warrior
Board Warrior
Posts: 1045
Joined: 2017-06-06, 07:38

Re: WebRTC in Pale Moon build output

Post by adesh » 2020-05-02, 10:47

Thank you both for explaining.

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 7339
Joined: 2012-10-09, 19:37
Location: Binary Outcast

Re: WebRTC in Pale Moon build output

Post by New Tobin Paradigm » 2020-05-02, 14:41

I recently went over that in my channel actually. Someone else asked. So it was fresh in mah mind.

Post Reply