Obsolete code

Talk about code development, features, specific bugzilla bugs, enhancements, patches, and other highly technical things.

Moderator: satrow

Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific referenced Bugzilla bugs, mercurial, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Most "bug reports" do not belong in this board and should initially be posted in Community Support or other relevant support boards.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
Fedor2
Astronaut
Astronaut
Posts: 660
Joined: 2016-04-11, 01:26

Obsolete code

Unread post by Fedor2 » 2019-07-01, 19:37

nsToolkitProfileService::CreateDefaultProfileForApp is for webapps, in our code webapps code has been deleted, why not to delete it too.

Also what about multiprocess windows int the about:support?

User avatar
Isengrim
Keeps coming back
Keeps coming back
Posts: 967
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: Obsolete code

Unread post by Isengrim » 2019-07-01, 20:20

Not sure about the former, but the latter looks like a Good First Issue™ to me.
Linux Mint 19.2 Cinnamon (64-bit), Windows 7 (64-bit), Windows 10 build 1803 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 5883
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Obsolete code

Unread post by New Tobin Paradigm » 2019-07-02, 02:49

fedor2..

If it is code that can be removed we will get to it. But you throwing random mothod names at us won't accelerate the process. You should know as a "developer" that unfocused random removal will only serve to paint us in a corner. But then again, I have seen your codebase and the changes you made and you have already screwed your self and it is blindingly obvious you have NO IDEA what you are actually doing.

So excuse me if I don't consider your suggestion as something that has any basis until it is checked properly. To be blunt, I don't like you, your friends, your followers or trust your opinion or judgement let alone the motives behind anything you do.

As far as I am conserned, you are a threat to everything we collectively have done for the past five years or longer.

That being said, it shall be looked into.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 660
Joined: 2016-04-11, 01:26

Re: Obsolete code

Unread post by Fedor2 » 2019-07-02, 05:25

The Good First Issue™ seems quietly has been gone.

I wanted to help, sure wrong help is more bad than no any help, i but try not to do wrong thing and shall learn.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 660
Joined: 2016-04-11, 01:26

Re: Obsolete code

Unread post by Fedor2 » 2019-07-08, 15:24

I do not insist to apply, may be later you will want to remove little bit unused code.

Remove unused code from ToolkitProfileService
https://github.com/Feodor2/Mypal/commit ... 1f4f1172a0

Remove multiprocess windows from about:support
https://github.com/Feodor2/Mypal/commit ... 8e10758f00

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 24457
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Obsolete code

Unread post by Moonchild » 2019-07-08, 18:33

You might want to double-check your patches. the second one at least is incomplete.
"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne
Image

User avatar
Fedor2
Astronaut
Astronaut
Posts: 660
Joined: 2016-04-11, 01:26

Re: Obsolete code

Unread post by Fedor2 » 2019-07-17, 19:48

Yes i did, thanks.

Post Reply