Question on packaging fix for Mac

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Question on packaging fix for Mac

Unread post by Isengrim » 2019-01-25, 04:41

Mac devs,

This might be a really trivial question, but here goes. While reviewing some commits to the UXP repo, I found the following change made to the package manifest files for Pale Moon and Basilisk.

Code: Select all

- @BINPATH@/@MOZ_APP_NAME@-bin
+ @RESPATH@/@MOZ_APP_NAME@-bin
Relevant commits:
Pale Moon: Quick fix to binay file path for Mac packaging
Basilisk: Trivial fixes for Mac build

To the best of your knowledge, will other applications building upon UXP also need this fix applied for Mac OS packaging?

Thanks In Advance!
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
wicknix
Fanatic
Fanatic
Posts: 173
Joined: 2018-03-26, 04:47
Location: Wisconsin, USA
Contact:

Re: Question on packaging fix for Mac

Unread post by wicknix » 2019-01-26, 18:58

I don't believe so. It may just be application (browser?) specific. It's needed for pm, basilisk, and iceweasel-uxp, but i don't recall having to make that change with interlink or standalone ambassador.

Cheers
Silence is golden, but duct tape is silver...

Locked