Page 1 of 1

no copy&paste of bookmark folders

Posted: 2018-08-20, 00:35
by karlkracher
As the title says it is no more possible with version 28 to copy and paste bookmark folders. For bookmarks and seperators it is possible. I've tried it also in safe mode and in a fresh installed portable version.

Well, i've read the post "please read first" later, here is the missing information, :oops:

os is german windows 7 professional (32-bit) with all updates
browser is pale moon desktop 28.0.0 (32-bit)
nothing in bugzilla, which i expected because with the last version before 28 it was working
to reproduce: open bookmarks in the sidebar, right click folder -> copy, left click an other spot to mark, right click -> paste
expected result: a copy of the folder with all its contents at the choosen location
actual result: nothing

Re: no copy&paste of bookmark folders

Posted: 2018-10-09, 18:46
by karlkracher
More information from the browser console, sorry for missing this in the past.

Trying to paste an already copied folder in the sidebar with ctr-v results in:

Code: Select all

TypeError: aChildren is undefined[Weitere Informationen]  
PlacesUIUtils.jsm:156:7
	getChildItemsTransactions resource://app/modules/PlacesUIUtils.jsm:156:7
	PUIU__getFolderCopyTransaction resource://app/modules/PlacesUIUtils.jsm:208:24
	PUIU_makeTransaction resource://app/modules/PlacesUIUtils.jsm:340:18
	PC_paste chrome://browser/content/places/controller.js:1538:9
	PC_doCommand chrome://browser/content/places/controller.js:220:7
using the context menu -> insert results in:

Code: Select all

TypeError: aChildren is undefined[Weitere Informationen]  
PlacesUIUtils.jsm:156:7
	getChildItemsTransactions resource://app/modules/PlacesUIUtils.jsm:156:7
	PUIU__getFolderCopyTransaction resource://app/modules/PlacesUIUtils.jsm:208:24
	PUIU_makeTransaction resource://app/modules/PlacesUIUtils.jsm:340:18
	PC_paste chrome://browser/content/places/controller.js:1538:9
	PC_doCommand chrome://browser/content/places/controller.js:220:7
	goDoPlacesCommand chrome://browser/content/places/controller.js:1888:5
	oncommand chrome://browser/content/bookmarks/bookmarksPanel.xul:1:1
NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "aChildren is undefined" {file: "resource://app/modules/PlacesUIUtils.jsm" line: 156}]'[JavaScript Error: "aChildren is undefined" {file: "resource://app/modules/PlacesUIUtils.jsm" line: 156}]' when calling method: [nsIController::doCommand]  
controller.js:1888
	goDoPlacesCommand chrome://browser/content/places/controller.js:1888:5
	oncommand chrome://browser/content/bookmarks/bookmarksPanel.xul:1:1

Re: no copy&paste of bookmark folders

Posted: 2018-11-13, 20:06
by karlkracher
Sorry, but after 28.2.0 i risk a "bump". No change in console messages, even the line numbers are the same.

And in case it's not a bug but a feature: please tell me. Thank you.

Re: no copy&paste of bookmark folders

Posted: 2018-11-14, 01:17
by back2themoon
Never really had to, but I also cannot do this (didn't try Safe Mode etc.). Was it possible in PM27?

Re: no copy&paste of bookmark folders

Posted: 2018-11-14, 11:01
by karlkracher
back2themoon wrote: Was it possible in PM27?
Yes, it was.

It's a needed part of my daily research routine. Basically one folder per day, which is the root of a bunch of subfolders and separating lines for different kind of items. Before version 28 it was easy: Copy and paste a (unused) dummy structure, rename it, done. Now i have to rebuild the complete structure every day every item by hand.

Looking at the messages cited above i think its' a bug. I even tried to trace "aChildren is undefined" back through the function calls but get lost between javascript xul and windows api, my programming experience is more hacking micro controllers in c and sometimes assembler, so i can't provide the needed patch.

I know that for the majority of pale moon users there are more important problems, but to keep my hope alive that it will be fixed some day i bumped this thread to prevent it getting lost in the past.

Re: no copy&paste of bookmark folders

Posted: 2018-11-14, 14:54
by back2themoon
Probably best to add the issue here so it won't be lost: https://github.com/MoonchildProductions/UXP/issues

Re: no copy&paste of bookmark folders

Posted: 2018-11-14, 17:11
by JustOff
Tracking in Issue #872 (UXP).

Re: no copy&paste of bookmark folders

Posted: 2018-12-06, 20:09
by karlkracher
Now with 28.2.2 it's working. Big thank you to the team for fixing this (and making this great browser).