Why is there that code?

Talk about code development, features, specific bugzilla bugs, enhancements, patches, and other highly technical things.

Moderator: satrow

Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific referenced Bugzilla bugs, mercurial, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Most "bug reports" do not belong in this board and should initially be posted in Community Support or other relevant support boards.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
Fedor2
Lunatic
Lunatic
Posts: 488
Joined: Mon, 11 Apr 2016, 01:26

Why is there that code?

Unread postby Fedor2 » Tue, 06 Feb 2018, 04:18

https://github.com/MoonchildProductions ... ue.js#L685

I do not get it, what is the purpose of that, can it be some bug? Becauase of that browser.showQuitWarning not works, but there are users who want use this setting.

I removed that code, and browser.showQuitWarning began do properly, and seems no other things has broken. Let that code to be removed from main code.

User avatar
New Tobin Paradigm
Banned user
Banned user
Posts: 4417
Joined: Tue, 09 Oct 2012, 19:37

Re: Why is there that code?

Unread postby New Tobin Paradigm » Tue, 06 Feb 2018, 05:43

No. Stop telling us what to do about things you don't understand. The feature works as intended.
I hate Pod Six. Tch, I don't even know why we have a Pod Six. Total suck Pod.
[ ニュー・トビン・パラダイム ]

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 21411
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: Why is there that code?

Unread postby Moonchild » Tue, 06 Feb 2018, 10:26

If # pages < 2, then don't show quit warning == correct behavior.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

User avatar
Fedor2
Lunatic
Lunatic
Posts: 488
Joined: Mon, 11 Apr 2016, 01:26

Re: Why is there that code?

Unread postby Fedor2 » Tue, 06 Feb 2018, 11:18

Yes, by default it do that way exactly.
But when users enabled browser.showQuitWarning they want get quit warning on one page too, is that wrong?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 21411
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: Why is there that code?

Unread postby Moonchild » Tue, 06 Feb 2018, 12:39

Fedor2 wrote:Yes, by default it do that way exactly.
But when users enabled browser.showQuitWarning they want get quit warning on one page too, is that wrong?

You clearly don't understand the preferences involved. Stop messing with them.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

User avatar
Fedor2
Lunatic
Lunatic
Posts: 488
Joined: Mon, 11 Apr 2016, 01:26

Re: Why is there that code?

Unread postby Fedor2 » Wed, 07 Feb 2018, 05:59

So i want to understand.
If you want to get quit warning on closing browser with one page, what you are to tweak in the prefs?
I found these related:

Code: Select all

browser.tabs.warnOnClose;true
browser.tabs.warnOnCloseOtherTabs;true
browser.warnOnQuit;true
browser.showQuitWarning;false

One is false, and with that you get quit warning on two and greater pages, so i think if to enable the last, i shall get quit warning regardless page count, but with check in the code mentioned above, execution cannot reach to process showQuitWarning if opened only one page.


Return to “Development (discussion)”

Who is online

Users browsing this forum: No registered users and 2 guests