Page 1 of 1

Remove mozilla legacy code and other

Posted: Thu, 31 Aug 2017, 15:52
by Fedor2
while i do search whole code, its so quite a mess i would say, i found several questionable things, consider their utility.
I already removed gmp code in my unofficial build, and browser seems runs fine.
here the other
* services\datareporting these disabled by default but why keep them at all
* services\healthreport
* services\metrics
* dom\media\platforms\agnostic related to gmp removed as well
* toolkit\components\social this if needed should be take away into some extension
* toolkit\components\telemetry bad stuff
* toolkit\identity these may be needed for sync
services\fxaccounts

Re: Remove mozilla legacy code and other

Posted: Thu, 31 Aug 2017, 17:57
by Moonchild
Just because it's in the source tree doesn't mean that it's in use.
While code cleanup is a nice thing to do, it is also relatively low priority (and because Mozilla's build system is a mess, it may toss up unexpected roadblocks).

Re: Remove mozilla legacy code and other

Posted: Tue, 12 Sep 2017, 17:10
by Fedor2
Roughly there are 250 cpps injected with telemetry code, i deleted telemetry entries form them and b2g as well, and it was a failure, browser wont start, now i'm thinking about build with debug mode to found what i have broke.

Re: Remove mozilla legacy code and other

Posted: Tue, 12 Sep 2017, 17:52
by Moonchild
Fedor2 wrote:Roughly there are 250 cpps injected with telemetry code, i deleted telemetry entries form them and b2g as well, and it was a failure, browser wont start, now i'm thinking about build with debug mode to found what i have broke.


You probably broke 250 things ;)

Re: Remove mozilla legacy code and other

Posted: Wed, 13 Sep 2017, 13:06
by Latitude
Moonchild wrote:You probably broke 250 things ;)


:lol:

But, I would give a standing ovation to Pale Moon devs because they could bring a true fork out of Firefox code mess.

Re: Remove mozilla legacy code and other

Posted: Wed, 13 Sep 2017, 13:29
by Latitude
Fedor2 wrote:my unofficial build,


Is it a Pale Moon fork?

Re: Remove mozilla legacy code and other

Posted: Thu, 14 Sep 2017, 11:38
by Moonchild
Latitude wrote:
Fedor2 wrote:my unofficial build,

Is it a Pale Moon fork?

If it is an independent build from an edited version of the source code not governed by us, then by strict definition it is a fork. Maybe not a product fork if unpublished or the edits being small, but at least a code fork.

Re: Remove mozilla legacy code and other

Posted: Sun, 08 Oct 2017, 12:04
by Donotfillintheblank
Moonchild wrote:
Fedor2 wrote:Roughly there are 250 cpps injected with telemetry code, i deleted telemetry entries form them and b2g as well, and it was a failure, browser wont start, now i'm thinking about build with debug mode to found what i have broke.


You probably broke 250 things ;)

Hm... maybe he isn't on the right track after all. :lol:

Re: Remove mozilla legacy code and other

Posted: Sun, 08 Oct 2017, 12:06
by Donotfillintheblank
Latitude wrote:
Moonchild wrote:You probably broke 250 things ;)


:lol:

But, I would give a standing ovation to Pale Moon devs because they could bring a true fork out of Firefox code mess.

Was Pale Moon forked from original Mozilla code, or from Firefox?

Re: Remove mozilla legacy code and other

Posted: Sun, 08 Oct 2017, 13:05
by Latitude
It is rebased from Mozilla Firefox code.

Re: Remove mozilla legacy code and other

Posted: Mon, 22 Jan 2018, 23:05
by Fedor2
I see that webrtc was started removing, fully up for that. However GMP is still keeping, do you have plans for them?

What can you say about voicemail, telephony, cellbrodcast, mobileconnections and sms, all those are in the dom folder, and those i removed already, shall do fmradio and tv too. In my build of course.

Re: Remove mozilla legacy code and other

Posted: Mon, 22 Jan 2018, 23:39
by New Tobin Paradigm
WebRTC in Tycho.. Pale Moon 27.. was removed to prevent misguided builders using the unsupported, bitrotted, insecure and otherwise not included code from building it.

The future of webrtc in Pale Moon is that it will not be included BUT UXP will have webrtc in a working state in the codebase but of course excluded from Pale Moon and the application won't really support it even if the platform can unlike Basilisk.

I would suggest you, Fedor2, not speak about things you do not understand. The fact is.. There won't be a huge amount of code culling in Tycho's future because there isn't much of a point now.

Re: Remove mozilla legacy code and other

Posted: Tue, 23 Jan 2018, 05:35
by Fedor2
not speak about things you do not understand.

so i ask for get understand, and you answered it clearly, about webrtc only though.

Re: Remove mozilla legacy code and other

Posted: Tue, 23 Jan 2018, 06:47
by gracious1
New Tobin Paradigm wrote:The future of webrtc in Pale Moon is that it will not be included BUT UXP will have webrtc in a working state in the codebase but of course excluded from Pale Moon and the application won't really support it even if the platform can unlike Basilisk..

To make sure I understand.... UXP (the platform) will support WebRTC. Therefore, if you want WebRTC you have to use or build an application, such as Basilisk (not Pale Moon), that also supports WebRTC.

Re: Remove mozilla legacy code and other

Posted: Tue, 23 Jan 2018, 14:25
by adesh
I don't think developers will go as far to make Pale Moon + WebRTC build impossible.
You would be able to build both Pale Moon and Basilisk with WebRTC support if you desire so, but the developers will choose to ship Pale Moon without any WebRTC code at all.

Re: Remove mozilla legacy code and other

Posted: Tue, 23 Jan 2018, 15:49
by New Tobin Paradigm
adesh wrote:I don't think developers will go as far to make Pale Moon + WebRTC build impossible.


Actually, in Tycho I did. I specifically went out of my way to remove the main webrtc code from the codebase. Because Tycho's webrtc was out of date and unmaintained including sec wise. AND because someone bitching that unbuilt unsupported code was buildable.

In UXP however Pale Moon's frontend may not be aligned with its webrtc and unless webrtc becomes desirable as a Pale Moon feature by users it won't be taken into account.

There is also a mozilla trifecta going on with UXP at the moment where DRM and WebRTC and GMP were made dependent on each other. So initially and until we can undo that if you build one you have to build all three and of course for Pale Moon they are undesirable. So will have to isolate all three together and prevent them from building for Pale Moon. Also, even if the platform can support building EME, Pale Moon's application code does not in any way have a concept of it so it would fail to work in any event. So that has to be prevented from being a situation some idiot with a .mozconfig can do.