Crash when uploading video to YouTube

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-09, 08:09

Your Operating system
NixOS 20.09 (Nightingale) x86_64

The exact version of Pale Moon you are using (desktop/portable. 32/64 bits, exact version number)
Desktop, 64-bit, 29.2.0

Basic hardware information if relevant: CPU, graphics card, amount of RAM
Doesn't seem to be relevant. Happens on both a 4-thread Intel laptop and a 48-thread AMD HEDT CPU, >=16GB RAM each

A description of the problem
Uploading a video >= 1,2GB in size (smallest video that didn't work for me) causes Pale Moon to crash. Smaller videos (tested a ~500MB one) seem to still work. This didn't happen with 28.17.0 (which happened to be on my laptop still, oops). As soon as I updated my laptop from 28.17.0 to 29.2.0, it started crashing as well. I haven't tested any version between those two.

Bugzilla bug number if found
n/a

Steps to reproduce the problem
  1. Login to YouTube
  2. Go to YouTube Studio (studio.youtube.com)
  3. Press Create -> Upload Video (translated from my language)
  4. Select a video >= 1,2GB in size
  5. The upload animation will play for a moment. Most of the time it froze on me when it's supposed to fade out & bring the video details editor, but once it did manage to briefly continue into the editor.
  6. Pale Moon crashes with SIGSEGV (GDB backtrace)

    Code: Select all

    Thread 221 "IndexedDB #1" received signal SIGSEGV, Segmentation fault.
    [Switching to Thread 0x7fff5b2ff640 (LWP 58324)]
    0x00007ffff036ae6d in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    (gdb) bt
    #0  0x00007ffff036ae6d in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #1  0x00007ffff0481d09 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #2  0x00007ffff04a75c8 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #3  0x00007ffff04aba44 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #4  0x00007ffff04abc4f in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #5  0x00007ffff04a15f7 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #6  0x00007fffee5d2ca9 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #7  0x00007fffee5ff5d9 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #8  0x00007ffff0494a89 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #9  0x00007fffee5d2ca9 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #10 0x00007fffee5ff5d9 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #11 0x00007fffee99abf2 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #12 0x00007fffee955aa3 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #13 0x00007fffee955ab1 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #14 0x00007fffee955e15 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #15 0x00007fffee5d5fa9 in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
    #16 0x00007ffff7a9635a in ?? () from /nix/store/kv511k5m16ychaariprhxp4d4nb4h525-palemoon-29.2.0/lib/palemoon-29.2.0/libnspr4.so
    #17 0x00007ffff7fb1e9e in start_thread () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libpthread.so.0
    #18 0x00007ffff7baa49f in clone () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6
    
    I know this isn't super-helpful of a backtrace, I can try an unstripped build this evening if you can't replicate it on your end.
Expected result
A crash-free upload experience like with 28.17.0.

Actual result
Consistent crashing on 2 different machines, with and without safe mode.

Additional notes

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-09, 09:31

The backtrace is indeed completely useless because it's a build from source (IIUC) so we don't have any symbols either to relate to the addresses.
We need a bit more to go on than "it happens somewhere in IndexedDB"
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-09, 19:02

Right, sorry. Here's a more complete backtrace.

Code: Select all

Thread 248 "IndexedDB #3" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff3e6ff640 (LWP 40937)]
mozilla::dom::quota::QuotaObject::DisableQuotaCheck (this=0x0) at /build/source/platform/dom/quota/ActorsParent.cpp:2769
2769	/build/source/platform/dom/quota/ActorsParent.cpp: No such file or directory.
(gdb) bt
#0  mozilla::dom::quota::QuotaObject::DisableQuotaCheck (this=0x0) at /build/source/platform/dom/quota/ActorsParent.cpp:2769
#1  0x00007ffff0257e3f in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::DisableQuotaChecks (this=this@entry=0x7fff3f2587a0) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:11162
#2  0x00007ffff027d6fe in mozilla::dom::indexedDB::(anonymous namespace)::Database::StartTransactionOp::DoDatabaseWork (this=0x7fff6fb34080, aConnection=0x7fff3f2587a0) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:14719
#3  0x00007ffff0281b7a in mozilla::dom::indexedDB::(anonymous namespace)::TransactionDatabaseOperationBase::RunOnConnectionThread (this=this@entry=0x7fff6fb34080) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:23532
#4  0x00007ffff0281d85 in mozilla::dom::indexedDB::(anonymous namespace)::Database::StartTransactionOp::RunOnConnectionThread (this=0x7fff6fb34080) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:14706
#5  0x00007ffff027772d in mozilla::dom::indexedDB::(anonymous namespace)::TransactionDatabaseOperationBase::Run (this=<optimized out>) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:23709
#6  0x00007fffee3a72d9 in nsThread::ProcessNextEvent (this=0x7fff6fb3c260, aMayWait=<optimized out>, aResult=0x7fff3e6fec07) at /build/source/platform/xpcom/threads/nsThread.cpp:1140
#7  0x00007fffee3d3c09 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:355
#8  0x00007ffff026abbf in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::ThreadRunnable::Run (this=0x7fff6fb23420) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:13337
#9  0x00007fffee3a72d9 in nsThread::ProcessNextEvent (this=0x7fff6fb3c260, aMayWait=<optimized out>, aResult=0x7fff3e6fed17) at /build/source/platform/xpcom/threads/nsThread.cpp:1140
#10 0x00007fffee3d3c09 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:355
#11 0x00007fffee76f222 in mozilla::ipc::MessagePumpForNonMainThreads::Run (this=0x7fff3f218100, aDelegate=0x7fff3f212180) at /build/source/platform/ipc/glue/MessagePump.cpp:337
#12 0x00007fffee72a0d3 in MessageLoop::RunInternal (this=this@entry=0x7fff3f212180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:231
#13 0x00007fffee72a0e1 in MessageLoop::RunHandler (this=this@entry=0x7fff3f212180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:224
#14 0x00007fffee72a445 in MessageLoop::Run (this=this@entry=0x7fff3f212180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:204
#15 0x00007fffee3aa5d9 in nsThread::ThreadFunc (aArg=0x7fff6fb3c260) at /build/source/platform/xpcom/threads/nsThread.cpp:458
#16 0x00007ffff7a9635a in _pt_root (arg=0x7fff6fb40380) at /build/source/platform/nsprpub/pr/src/pthreads/ptthread.c:201
#17 0x00007ffff7fb1e9e in start_thread () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libpthread.so.0
#18 0x00007ffff7baa49f in clone () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-09, 19:31

Hmm. That's curious. The crash is in the DOM quota manager. There are some assertions that the quota objects should exist, but no hard checks. And I don't see where these are actually given any value in the call made that is supposedly filling the objects while still returning NS_OK, which seems very wrong.

Is your temporary storage space limited? Looks like the initial issue is that you're exceeding the IDB quota leading to this callstack.
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-09, 20:53

Moonchild wrote:
2021-05-09, 19:31
Is your temporary storage space limited? Looks like the initial issue is that you're exceeding the IDB quota leading to this callstack.
Didn't see the edits, sorry. I am indeed getting tight on disk space on my desktop, but I'm still dozens of GB away from having a full drive. Watching disk usage shows that maybe 2-3 GB get added to the usage before it crashes, which easily fit onto the drive. My laptop with hundreds of GB headroom also exhibits this crash, so I don't think limited storage space is the problem?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-09, 21:38

OPNA2608 wrote:
2021-05-09, 20:53
I don't think limited storage space is the problem?
Well I had to ask, since when using tmpfs or what not for /tmp you may run into issues that way ;P

I have a wip patch here that attempts to make a quick fix for this by piecemeal restoring needed parts of what was ripped out with telemetry by g4jc last year as well as doing the extra check and failing if ending up as null. If you could apply that and rebuild and let me know if it helped, that would be great.
Attachments
1768-wip1-patch.diff
(1.86 KiB) Downloaded 17 times
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-11, 10:08

29.2.0 + that patch gives me this crash now.

Code: Select all

Thread 73 "IndexedDB #3" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffabdff640 (LWP 540)]
0x00007fffe05fa597 in gconv () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/gconv/UTF-16.so
(gdb) bt
#0  0x00007fffe05fa597 in gconv () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/gconv/UTF-16.so
#1  0x00007ffff7ad976f in __gconv () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6
#2  0x00007ffff7ad91a4 in iconv () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6
#3  0x00007fffee38d961 in xp_iconv (aOutputLeft=0x7fffabdfd840, aOutput=0x7fffabdfd8c8, aInputLeft=0x7fffabdfd838, aInput=0x7fffabdfd8c0, converter=<optimized out>) at /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp:127
#4  nsNativeCharsetConverter::UnicodeToNative (this=this@entry=0x7fffabdfd8b7, aInput=aInput@entry=0x7fffabdfd8c0, aInputLeft=aInputLeft@entry=0x7fffabdfd8b8, aOutput=aOutput@entry=0x7fffabdfd8c8, 
    aOutputLeft=aOutputLeft@entry=0x7fffabdfd8bc) at /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp:557
#5  0x00007fffee38dc51 in NS_CopyUnicodeToNative (aInput=..., aOutput=...) at /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp:857
#6  0x00007fffee37a773 in nsLocalFile::InitWithPath (this=0x7fffd67e5cc0, aFilePath=...) at /build/source/platform/xpcom/io/nsLocalFileUnix.cpp:2043
#7  0x00007ffff025b4c8 in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::GetFileSize (this=this@entry=0x7fffd67b88e0, aPath=..., aResult=aResult@entry=0x7fffabdfea38)
    at /build/source/platform/dom/indexedDB/ActorsParent.cpp:11216
#8  0x00007ffff025b5cc in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::EnableQuotaChecks (this=this@entry=0x7fffd67b88e0) at /build/source/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/quota/QuotaObject.h:35
#9  0x00007ffff0279aa7 in mozilla::dom::indexedDB::(anonymous namespace)::TransactionBase::CommitOp::Run (this=0x7fffd5f833e0) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:23949
#10 0x00007ffff027ec83 in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::FinishCallbackWrapper::Run (this=0x7fffd5ff7200) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:13243
#11 0x00007fffee3a72d9 in nsThread::ProcessNextEvent (this=0x7fffd5faa6a0, aMayWait=<optimized out>, aResult=0x7fffabdfec07) at /build/source/platform/xpcom/threads/nsThread.cpp:1140
#12 0x00007fffee3d3c09 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:355
#13 0x00007ffff026acaf in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::ThreadRunnable::Run (this=0x7fffd5f30700) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:13337
#14 0x00007fffee3a72d9 in nsThread::ProcessNextEvent (this=0x7fffd5faa6a0, aMayWait=<optimized out>, aResult=0x7fffabdfed17) at /build/source/platform/xpcom/threads/nsThread.cpp:1140
#15 0x00007fffee3d3c09 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:355
#16 0x00007fffee76f215 in mozilla::ipc::MessagePumpForNonMainThreads::Run (this=0x7fffd6777bc0, aDelegate=0x7fffd676ead0) at /build/source/platform/ipc/glue/MessagePump.cpp:367
#17 0x00007fffee72a0d3 in MessageLoop::RunInternal (this=this@entry=0x7fffd676ead0) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:231
#18 0x00007fffee72a0e1 in MessageLoop::RunHandler (this=this@entry=0x7fffd676ead0) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:224
#19 0x00007fffee72a445 in MessageLoop::Run (this=this@entry=0x7fffd676ead0) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:204
#20 0x00007fffee3aa5d9 in nsThread::ThreadFunc (aArg=0x7fffd5faa6a0) at /build/source/platform/xpcom/threads/nsThread.cpp:458
#21 0x00007ffff7a9835a in _pt_root (arg=0x7fffd5ff2800) at /build/source/platform/nsprpub/pr/src/pthreads/ptthread.c:201
#22 0x00007ffff7fb3e9e in start_thread () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libpthread.so.0
#23 0x00007ffff7bac49f in clone () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-11, 12:16

That's a crash in glibc... not sure how we can help with that?
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
Gaming4JC
Hobby Astronomer
Hobby Astronomer
Posts: 18
Joined: 2018-09-08, 17:10

Re: Crash when uploading video to YouTube

Post by Gaming4JC » 2021-05-11, 12:17

This second crash is to do with system locales. Mozilla ran into some issues pre-59 and ripped out iconv altogether. I would assume you have a custom locale set? In either case it shouldn't be crashing on a system lib, merely asserting.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 9938
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Crash when uploading video to YouTube

Post by New Tobin Paradigm » 2021-05-11, 12:49

So is this person building with debug or what.. If the assert shouldn't be crashing on a normal build?
I'M COMBINING THE FORCE FIELD WITH ENERGY POWER!
Image

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-11, 12:55

So IIUC the locale setting used on the crashing system is non-UTF8, using filesystem paths on the system with locale-specific characters, and glibc can't handle that?
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-11, 15:08

Gaming4JC wrote:
2021-05-11, 12:17
I would assume you have a custom locale set?
I have LANG=de_DE.UTF-8 if that's what you mean.
New Tobin Paradigm wrote:
2021-05-11, 12:49
So is this person building with debug or what.. If the assert shouldn't be crashing on a normal build?
Only flag I changed from our regular mozconfig is

Code: Select all

ac_add_options --enable-strip
to

Code: Select all

ac_add_options --disable-strip
ac_add_options --disable-install-strip
to get meaningful backtraces from the build. Reverting this still gives me a segmentation fault.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-11, 16:37

OPNA2608 wrote:
2021-05-11, 15:08
I have LANG=de_DE.UTF-8 if that's what you mean.
Yes that's what I meant, but more so that you might have used localized paths in your filesystem (non-ASCII).

Either way, it seems like this isn't too much of an issue.
Try building from the 1768 branch on the repo and see if that combination of patches fixes your crashing.
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-12, 20:11

Moonchild wrote:
2021-05-11, 16:37
Try building from the 1768 branch on the repo and see if that combination of patches fixes your crashing.
I tried building 29.2.0 with the 1768 branch of UXP in /platform/ and got a compilation error:

Code: Select all

854:20.55 In file included from /build/source/obj-x86_64-pc-linux-gnu/xpcom/io/Unified_cpp_xpcom_io1.cpp:2:
854:20.55 /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp: In function 'nsresult NS_CopyUnicodeToNative(const nsAString_internal&, nsACString_internal&)':
854:20.55 /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp:142:3: error: 'LossyCopyUTF16toUTF8' was not declared in this scope; did you mean 'CopyUTF16toUTF8'?
854:20.55   142 |   LossyCopyUTF16toUTF8(aInput, aOutput);
854:20.55       |   ^~~~~~~~~~~~~~~~~~~~
854:20.55       |   CopyUTF16toUTF8
854:21.68 
854:21.68 In the directory  /build/source/obj-x86_64-pc-linux-gnu/xpcom/io
854:21.68 The following command failed to execute properly:
854:21.68 /nix/store/zzvq5qwlm2xikawfqxb0q8gl2bw391a9-gcc-wrapper-10.2.0/bin/g++ -std=gnu++11 -o Unified_cpp_xpcom_io1.o -c -I/build/source/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/build/source/obj-x86_64-pc-linux-gnu/dist/system_wrappers -include /build/source/platform/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/build/source/platform/xpcom/io -I/build/source/obj-x86_64-pc-linux-gnu/xpcom/io -I/build/source/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders -I/build/source/platform/ipc/chromium/src -I/build/source/platform/ipc/glue -I/build/source/obj-x86_64-pc-linux-gnu/xpcom -I/build/source/obj-x86_64-pc-linux-gnu/dist/include -I/build/source/obj-x86_64-pc-linux-gnu/dist/include/nspr -I/build/source/obj-x86_64-pc-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /build/source/obj-x86_64-pc-linux-gnu/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_xpcom_io1.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=multistatement-macros -flifetime-dse=1 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -msse2 -mfpmath=sse -pthread -pipe -g -O2 -w -fomit-frame-pointer /build/source/obj-x86_64-pc-linux-gnu/xpcom/io/Unified_cpp_xpcom_io1.cpp
854:21.69 make[5]: *** [/build/source/platform/config/rules.mk:881: Unified_cpp_xpcom_io1.o] Error 1

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-12, 20:32

Yeah my bad. Incorrect function call. should be without "Lossy". Pushed a commit to fix that.
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-13, 18:03

Builds now. New crash backtrace:

Code: Select all

Thread 74 "IndexedDB #2" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd41fe640 (LWP 4067)]
0x00007fffee32eebc in AppendUTF16toUTF8(nsAString_internal const&, nsACString_internal&, mozilla::fallible_t const&) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
(gdb) bt
#0  0x00007fffee32eebc in AppendUTF16toUTF8(nsAString_internal const&, nsACString_internal&, mozilla::fallible_t const&) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#1  0x00007fffee32f3e3 in CopyUTF16toUTF8(nsAString_internal const&, nsACString_internal&) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#2  0x00007fffee383399 in NS_CopyUnicodeToNative(nsAString_internal const&, nsACString_internal&) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#3  0x00007fffee36eb87 in nsLocalFile::InitWithPath(nsAString_internal const&) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#4  0x00007ffff02a520d in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::GetFileSize(nsAString_internal const&, long*) [clone .constprop.0] ()
   from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#5  0x00007ffff02bd02b in mozilla::dom::indexedDB::(anonymous namespace)::TransactionBase::CommitOp::Run() () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#6  0x00007ffff02c8140 in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::FinishCallbackWrapper::Run() () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#7  0x00007fffee39dba5 in nsThread::ProcessNextEvent(bool, bool*) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#8  0x00007fffee3ca1a8 in NS_ProcessNextEvent(nsIThread*, bool) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#9  0x00007ffff02b9fcd in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::ThreadRunnable::Run() () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#10 0x00007fffee39dba5 in nsThread::ProcessNextEvent(bool, bool*) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#11 0x00007fffee3ca1a8 in NS_ProcessNextEvent(nsIThread*, bool) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#12 0x00007fffee7e0dea in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#13 0x00007fffee795245 in MessageLoop::Run() () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#14 0x00007fffee39b75b in nsThread::ThreadFunc(void*) () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libxul.so
#15 0x00007ffff7a989f0 in _pt_root () from /nix/store/xxwlzfy91v7pw3l6m9mhnnkqnyd3izp5-palemoon-29.2.0/lib/palemoon-29.2.0/libnspr4.so
#16 0x00007ffff7fb3e9e in start_thread () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libpthread.so.0
#17 0x00007ffff7bac49f in clone () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-13, 19:08

There's no actual error and source location given in that trace so I don't know what's going on there.
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-13, 19:20

Shoot, sorry. Ran the wrong thing and didn't disable stripping properly… Lemme rebuild & give you a better trace in abit. :?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 30209
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Crash when uploading video to YouTube

Post by Moonchild » 2021-05-14, 00:12

It's quite possible this telemetry stuff was simply not removed properly/completely. At the very least it looks like C++ inheritance wasn't taken into account here resulting in issues.

If we can't get a minimal-patched solution here that works, at least let me know if reverting the removal (apply attached patch to master) makes these crashes stop?
EDIT: hang on, I forgot something, will attach an updated patch when I have it.
EDIT2: updated patch attached.
Attachments
telemetryvfs-patch.diff
(45.8 KiB) Downloaded 5 times
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
OPNA2608
Hobby Astronomer
Hobby Astronomer
Posts: 22
Joined: 2019-09-27, 09:30

Re: Crash when uploading video to YouTube

Post by OPNA2608 » 2021-05-14, 07:02

Fixed backtrace:

Code: Select all

Thread 84 "IndexedDB #3" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffbc3ff640 (LWP 31419)]
CalculateUTF8Size::write (aN=4150512296, aStart=0x7ffff766d020 <aVfs.88+512> u"Ȁ", this=<synthetic pointer>) at /build/source/platform/xpcom/string/nsUTF8Utils.h:578
578	/build/source/platform/xpcom/string/nsUTF8Utils.h: No such file or directory.
(gdb) bt
#0  CalculateUTF8Size::write (aN=4150512296, aStart=0x7ffff766d020 <aVfs.88+512> u"Ȁ", this=<synthetic pointer>) at /build/source/platform/xpcom/string/nsUTF8Utils.h:578
#1  nsCharSinkTraits<CalculateUTF8Size>::write (aN=4150512296, aStr=0x7ffff766d020 <aVfs.88+512> u"Ȁ", aIter=<synthetic pointer>...) at /build/source/platform/xpcom/string/nsCharTraits.h:571
#2  copy_string<nsReadingIterator<char16_t>, CalculateUTF8Size> (aResult=<synthetic pointer>..., aLast=..., aFirst=...) at /build/source/obj-x86_64-pc-linux-gnu/dist/include/nsAlgorithm.h:69
#3  AppendUTF16toUTF8 (aSource=..., aDest=..., aFallible=...) at /build/source/platform/xpcom/string/nsReadableUtils.cpp:280
#4  0x00007fffee33e199 in CopyUTF16toUTF8 (aSource=..., aDest=..., aFallible=...) at /build/source/platform/xpcom/string/nsReadableUtils.cpp:127
#5  0x00007fffee33e1b6 in CopyUTF16toUTF8 (aSource=..., aDest=...) at /build/source/platform/xpcom/string/nsReadableUtils.cpp:115
#6  0x00007fffee38f20e in NS_CopyUnicodeToNative (aInput=..., aOutput=...) at /build/source/platform/xpcom/io/nsNativeCharsetUtils.cpp:142
#7  0x00007fffee37c583 in nsLocalFile::InitWithPath (this=0x7fffde35e0c0, aFilePath=...) at /build/source/platform/xpcom/io/nsLocalFileUnix.cpp:2043
#8  0x00007ffff025c5cc in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::GetFileSize (this=this@entry=0x7fffde369800, aPath=..., aResult=aResult@entry=0x7fffbc3fea38)
    at /build/source/platform/dom/indexedDB/ActorsParent.cpp:11216
#9  0x00007ffff025c6d0 in mozilla::dom::indexedDB::(anonymous namespace)::DatabaseConnection::EnableQuotaChecks (this=this@entry=0x7fffde369800) at /build/source/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/quota/QuotaObject.h:35
#10 0x00007ffff027abab in mozilla::dom::indexedDB::(anonymous namespace)::TransactionBase::CommitOp::Run (this=0x7fffd6146e60) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:23949
#11 0x00007ffff027fd87 in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::FinishCallbackWrapper::Run (this=0x7fffb70c8180) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:13243
#12 0x00007fffee3a8803 in nsThread::ProcessNextEvent (this=0x7fffd6156bf0, aMayWait=<optimized out>, aResult=0x7fffbc3fec07) at /build/source/platform/xpcom/threads/nsThread.cpp:1125
#13 0x00007fffee3d5129 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:353
#14 0x00007ffff026bdb3 in mozilla::dom::indexedDB::(anonymous namespace)::ConnectionPool::ThreadRunnable::Run (this=0x7fffb25096e0) at /build/source/platform/dom/indexedDB/ActorsParent.cpp:13337
#15 0x00007fffee3a8803 in nsThread::ProcessNextEvent (this=0x7fffd6156bf0, aMayWait=<optimized out>, aResult=0x7fffbc3fed17) at /build/source/platform/xpcom/threads/nsThread.cpp:1125
#16 0x00007fffee3d5129 in NS_ProcessNextEvent (aThread=<optimized out>, aMayWait=<optimized out>) at /build/source/platform/xpcom/glue/nsThreadUtils.cpp:353
#17 0x00007fffee77036e in mozilla::ipc::MessagePumpForNonMainThreads::Run (this=0x7fffde309200, aDelegate=0x7fffde357180) at /build/source/platform/ipc/glue/MessagePump.cpp:337
#18 0x00007fffee72b21f in MessageLoop::RunInternal (this=this@entry=0x7fffde357180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:231
#19 0x00007fffee72b22d in MessageLoop::RunHandler (this=this@entry=0x7fffde357180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:224
#20 0x00007fffee72b591 in MessageLoop::Run (this=this@entry=0x7fffde357180) at /build/source/platform/ipc/chromium/src/base/message_loop.cc:204
#21 0x00007fffee3abb03 in nsThread::ThreadFunc (aArg=0x7fffd6156bf0) at /build/source/platform/xpcom/threads/nsThread.cpp:443
#22 0x00007ffff7a9835a in _pt_root (arg=0x7fffd61415c0) at /build/source/platform/nsprpub/pr/src/pthreads/ptthread.c:201
#23 0x00007ffff7fb3e9e in start_thread () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libpthread.so.0
#24 0x00007ffff7bac49f in clone () from /nix/store/v8q6nxyppy1myi3rxni2080bv8s9jxiy-glibc-2.32-40/lib/libc.so.6
Moonchild wrote:
2021-05-14, 00:12
If we can't get a minimal-patched solution here that works, at least let me know if reverting the removal (apply attached patch to master) makes these crashes stop?
EDIT: hang on, I forgot something, will attach an updated patch when I have it.
EDIT2: updated patch attached.
The attached patch seems to solve the crashes for me, yes.

Post Reply