[Image Toolbox] Not remembering last used directory

General discussion, compatibility and contributed extensions.

Moderators: Lootyhoof, FranklinDM

Locked
Catnip
Newbie
Newbie
Posts: 3
Joined: 2015-07-02, 19:32
Location: Northern Hemisphere

[Image Toolbox] Not remembering last used directory

Post by Catnip » 2015-07-02, 19:51

Hello everyone,

I know that the old Image Toolbar addon used to remember the last used directory (granted; only for the specific file type and not for every following image file) for the rest of the session.

So for example when I saved a PNG file in D:\Stuff\MoreStuff\, the next time I click on the save icon on a PNG the save as dialog would open at D:\Stuff\MoreStuff\ again.

But with Image Toolbox, it will always reset to the default directory (the Downloads folder). So this makes the addon a bit useless for me, because now it's faster to just click on Save As, because Pale Moon does indeed open the save as dialog at the last used directory.

Maybe it's just a config problem, but can't really find any settings related to this.

In PM I have 'ask me where to save files' selected (default is Downloads folder).
In Image Toolbox I have 'prompt for a location and filename' selected.

Please tell me if I missed anything.

Pale Moon v25.5.0 x64
Image Toolbox 1.0.0

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8884
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: [Image Toolbox] Not remembering last used directory

Post by New Tobin Paradigm » 2015-07-03, 03:39

The choices are to save to default downloads folder or set a custom folder.. Then you have the options to save automagically or prompt.. but it will always open in the downloads folder or the custom folder you set.. .. Or should. The code is almost identical to Image Toolbar so it will operate as the parent extension did.
How far are you prepared to go? How much are you prepared to risk? How many people are you prepared to sacrifice for victory?
Are you willing to die friendless, alone, deserted by everyone? Because that's what may be required of you in the war that is to come.

Image

Stormbringer

Re: [Image Toolbox] Not remembering last used directory

Post by Stormbringer » 2015-07-03, 10:07

Catnip,
it's true: ImageToolbox can't remember last used directory.
Image Toolbar can remember it, instead: tested on Firefox, Waterfox and Cyberfox.

I had to remove Image Toolbox 'cause is quite useless now.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8884
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: [Image Toolbox] Not remembering last used directory

Post by New Tobin Paradigm » 2015-07-03, 12:13

Well I can look into why it isn't.. I don't remember that being in the functionality when I last used Image Toolbar..

If you want to help make Image Toolbox better you can submit a pull request to https://github.com/Pale-Moon-Addons-Team/imagetoolbox
How far are you prepared to go? How much are you prepared to risk? How many people are you prepared to sacrifice for victory?
Are you willing to die friendless, alone, deserted by everyone? Because that's what may be required of you in the war that is to come.

Image

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8884
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: [Image Toolbox] Not remembering last used directory

Post by New Tobin Paradigm » 2015-07-03, 14:02

I have taken a look at the last version compatible with Pale Moon 24 on Pale Moon 24.. This is indeed a regression.. I will be looking into this.. I may have to downgrade the codebase back to that version and add improvements manually.. I am however very busy so it may take a bit..

Obviously the fixed version someone made of the then latest version wasn't as complete as some would think.. So, will be looking into that..

When I do get it up to snuff it will come through as an update via the add-ons manager.
How far are you prepared to go? How much are you prepared to risk? How many people are you prepared to sacrifice for victory?
Are you willing to die friendless, alone, deserted by everyone? Because that's what may be required of you in the war that is to come.

Image

Catnip
Newbie
Newbie
Posts: 3
Joined: 2015-07-02, 19:32
Location: Northern Hemisphere

Re: [Image Toolbox] Not remembering last used directory

Post by Catnip » 2015-07-03, 14:40

Hello Matt,

if you could find the time to look at the script, that would be amazing. Take your time.

I'm not sure how this whole Github thing works (pull request is submitting your own code?), but I want to thank you for everything you've done so far for the PM Project.

Cheers

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8884
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: [Image Toolbox] Not remembering last used directory

Post by New Tobin Paradigm » 2015-07-03, 18:51

RESOLVED FIXED in https://github.com/Pale-Moon-Addons-Team/imagetoolbox/commit/1da2f8525d48244dd49d26fe1a6d41ca53925ae9

I will make a release soon as v1.0.1 (when I am next on my dev partition)
How far are you prepared to go? How much are you prepared to risk? How many people are you prepared to sacrifice for victory?
Are you willing to die friendless, alone, deserted by everyone? Because that's what may be required of you in the war that is to come.

Image

Catnip
Newbie
Newbie
Posts: 3
Joined: 2015-07-02, 19:32
Location: Northern Hemisphere

Re: [Image Toolbox] Not remembering last used directory

Post by Catnip » 2015-07-03, 19:38

Great, thanks a lot :)

Locked