Are there any changes in how tabs are handled (33.4.0)

[sidology]

My tab related extensions are broken in 33.4.0.

For example, Close Tabs to the Right doesn't work when "Tab Utilities Fixed" is installed. Or closing multiple tabs with "Multiple Tab Handler" doesn't work anymore.

So I wonder is this a bug introduced by "ghostbuster" concept or new design which means all tab related extensions needs to be updated.

EDIT: "Multiple Tab Handler" works when "Tab Utilities Fixed" is uninstalled. So there is some conflict with "Tab Utilities Fixed" and tab managment.

EDIT 2: When I close and later open Pale Moon, all the closed tabs from my previous session don't stay closed, they are back, 100 tabs completely restored.

[Moonchild]

First, check the browser console for any errors thrown by either extension.

[sidology]

All errors are from Tab Utilities Fixed, except one from SiteDelta and one from Menu Wizard.

Code: Select all

Failed to hook PlacesViewBase.prototype.place
---
TU_hookSetter@chrome://tabutils/content/tulib.js:58:72
arrowscrollbox_XBL_Constructor@chrome://tabutils/content/tabutils.xml:104:11
 1 tulib.js:58
	TU_hookSetter chrome://tabutils/content/tulib.js:58:22
	arrowscrollbox_XBL_Constructor chrome://tabutils/content/tabutils.xml:104:11

Failed to hook gBrowser.addTab
---
TU_hookCode@chrome://tabutils/content/tulib.js:28:72
tabutils._tabOpeningOptions@chrome://tabutils/content/tabutils.js:672:3
init@chrome://tabutils/content/tabutils.js:10:10
handleEvent@chrome://tabutils/content/tabutils.js:179:37
 1 tulib.js:28
	TU_hookCode chrome://tabutils/content/tulib.js:28:22
	tabutils._tabOpeningOptions chrome://tabutils/content/tabutils.js:672:3
	init chrome://tabutils/content/tabutils.js:10:10
	handleEvent chrome://tabutils/content/tabutils.js:179:37

Failed to hook FullScreen.mouseoverToggle
---
TU_hookCode@chrome://tabutils/content/tulib.js:28:72
tabutils._verticalTabs@chrome://tabutils/content/tabutils-vt.js:31:3
init@chrome://tabutils/content/tabutils.js:27:10
handleEvent@chrome://tabutils/content/tabutils.js:179:37
 1 tulib.js:28
	TU_hookCode chrome://tabutils/content/tulib.js:28:22
	tabutils._verticalTabs chrome://tabutils/content/tabutils-vt.js:31:3
	init chrome://tabutils/content/tabutils.js:27:10
	handleEvent chrome://tabutils/content/tabutils.js:179:37

Failed to hook FullScreen.mouseoverToggle
---
TU_hookCode@chrome://tabutils/content/tulib.js:28:72
tabutils._verticalTabs@chrome://tabutils/content/tabutils-vt.js:71:3
init@chrome://tabutils/content/tabutils.js:27:10
handleEvent@chrome://tabutils/content/tabutils.js:179:37
 1 tulib.js:28
	TU_hookCode chrome://tabutils/content/tulib.js:28:22
	tabutils._verticalTabs chrome://tabutils/content/tabutils-vt.js:71:3
	init chrome://tabutils/content/tabutils.js:27:10
	handleEvent chrome://tabutils/content/tabutils.js:179:37

gBrowser.addProgressListener was called with a second argument, which is not supported. See bug 608628. 1 tabbrowser.xml:2481
	addProgressListener chrome://browser/content/tabbrowser.xml:2481:32
	onLoad chrome://sitedelta/content/sitedeltaOverlay.js:51:12

Failed to hook gSessionHistoryObserver.observe
---
TU_hookCode@chrome://tabutils/content/tulib.js:28:72
tabutils._undoCloseTabButton@chrome://tabutils/content/tabutils.js:2896:3
onload@chrome://tabutils/content/tabutils.js:99:10
handleEvent@chrome://tabutils/content/tabutils.js:180:25
 1 tulib.js:28
	TU_hookCode chrome://tabutils/content/tulib.js:28:22
	tabutils._undoCloseTabButton chrome://tabutils/content/tabutils.js:2896:3
	onload chrome://tabutils/content/tabutils.js:99:10
	handleEvent chrome://tabutils/content/tabutils.js:180:25

Failed to hook PlacesViewBase.prototype.place
---
TU_hookSetter@chrome://tabutils/content/tulib.js:58:72
arrowscrollbox_XBL_Constructor@chrome://tabutils/content/tabutils.xml:104:11
tabutils._verticalTabs/tabutils._tabPrefObserver.tabBarPosition@chrome://tabutils/content/tabutils-vt.js:119:33
observe@chrome://tabutils/content/tabutils.js:3011:17
init/<@chrome://tabutils/content/tabutils.js:2965:12
init@chrome://tabutils/content/tabutils.js:2964:8
onload@chrome://tabutils/content/tabutils.js:100:27
handleEvent@chrome://tabutils/content/tabutils.js:180:25
 1 tulib.js:58
	TU_hookSetter chrome://tabutils/content/tulib.js:58:22
	arrowscrollbox_XBL_Constructor chrome://tabutils/content/tabutils.xml:104:11
	tabutils._verticalTabs/tabutils._tabPrefObserver.tabBarPosition chrome://tabutils/content/tabutils-vt.js:119:33
	observe chrome://tabutils/content/tabutils.js:3011:17
	init/< chrome://tabutils/content/tabutils.js:2965:12
	forEach self-hosted:302:13
	init chrome://tabutils/content/tabutils.js:2964:8
	onload chrome://tabutils/content/tabutils.js:100:27
	handleEvent chrome://tabutils/content/tabutils.js:180:25

online-subs:TypeError: this.contextMenuContentData is null
Stack trace:
updateItemVisibilities@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js:1002:11
s3menuwizard.start_prepare@chrome://s3menuwizard/content/s3menuwizard.js:64:15
s3menuwizard.start@chrome://s3menuwizard/content/s3menuwizard.js:37:16
s3menuwizard.init/<@chrome://s3menuwizard/content/s3menuwizard.js:29:16
 1 context-menu.js:1011

ReferenceError: nsIWebNavigation is not defined 1 tulib.js%20line%20105%20%3E%20eval:42:13
	_endRemoveTab chrome://tabutils/content/tulib.js%20line%20105%20%3E%20eval:42:13
	removeTab chrome://tabutils/content/tulib.js%20line%20105%20%3E%20eval:39:20
	removeTabsBut chrome://tabutils/content/tabutils.js:1851:19
	oncommand chrome://browser/content/browser.xul:1:10
	doClickAction chrome://tabutils/content/tabutils.js:2215:31
	onTabClick chrome://tabutils/content/tulib.js%20line%20105%20%3E%20eval:33:12
	tabutils._tabClickingOptions/< chrome://tabutils/content/tabutils.js:2337:111

[Moonchild]

Interesting. Seems Tab Utilities is doing some voodoo with pulling methods out of the tab browser and manipulating them?

The issue is likely the inconsistency that was pointed out already (providing full context for nsIWebNavigation) but in tabbrowser code itself, that interface is globally defined already so it's not breaking there, and I didn't think it would be an issue so I did not uplift that from master/rebuilt all binaries; but if extensions make copies of method code and try to execute it in a different environment then I can see that being an issue (not something I thought would be done, tbh).

I can make a test build (windows) with that uplifted, and you can have a look if that fixes it? Let me know.

[sidology]

Yes, thank you.

[Moonchild]

OK. stand by.

[KSAKS]

Moonchild I'll test as well with my issue here: viewtopic.php?f=46&t=31680
This is what I see in the console when I close tab.

Code: Select all

Timestamp: 8.10.2024 15:56:04
Error: ReferenceError: nsIWebNavigation is not defined
Source File: chrome://speeddial/content/speeddialOverlay.js line 1595 > eval
Line: 42

[q160765803]

It should be fixed in master branch: https://repo.palemoon.org/MoonchildProd ... a78c458780
But it is yet to be merged into RC branch.

[Moonchild]

Give this a try.

ftp://publicbeta:get@ftp.palemoon.org/palemoon-33.4.0a1.win64.7z

[KSAKS]

The issue with Speed Dial addon is fixed for me in the test version. Thanks.

btw. there is some issue with ipv6 on your FTP server, I needed to force ipv4, else I got this in multiple clients:

Code: Select all

500 You are connected using IPv6. PASV is only for IPv4. You have to use the EPSV command instead.

[sidology]

Fixed for Tab Utilities, too. Thank you.

[Moonchild]

Alright.
I'll uplift the fix and make an out-of-band point release for this. Expected release tomorrow or Thursday.

As for FTP; the error should speak for itself? If using IPv6, your FTP clients need to use EPSV for passive mode transfers.

[sidology]

I'll uplift the fix and make an out-of-band point release for this. Expected release tomorrow or Thursday.

One small issue, now whenever I open PM, new empty tab (about:blank) is opened, too. Nothing in browser console. No biggie.

[KSAKS]

As for FTP; the error should speak for itself? If using IPv6, your FTP clients need to use EPSV for passive mode transfers.

Yes, but the "multiple clients" includes Palemoon and there I have seen no error at all, it just didn't load the file at all. Might be confusing for the users.