[problem] With Middle-Click closes tab extension - clicking on the scrollbar also closes tab

[MrAccident]

OS: Puppy Linux
PM Version: 33.0.0
64-bit browser
I'm using the extension "Double Click Closes Tab", and it's set to close the tab by a Middle-Click anywhere on the page (other than on links). Lately it started to close the tab - even when I click on the Scrollbar, no matter where; which it never did. The reason for Middle-Clicking on the Scrollbar - is to get all the way to the top\bottom in 1 click, instead of clicking many times. I disabled all the rest of the extensions - and it still does this.
So maybe something changed in one of the latest versions?

[moonbat]

Something may well have changed, but it is the addon author's job to keep up with the browser, not the other way round. Contact the author or look for an alternative on the Pale Moon addons site. Goes without saying that don't even bother looking at Firefox addons because those are all web extensions that won't work with Pale Moon.

[MrAccident]

The extension is from 2012, and doesn't appear in the author's website.
I was hoping that knowing what changed that causes it ― will enable me to find a personal solution. So I would still like to know that.

[Moonchild]

Well our click handling changed, we're more standards compliant now no longer dispatching click() events on non-primary buttons. so the extension needs to probably be updated for that.

[MrAccident]

@moonchild - OK, thanks. I don't know what that means exactly, as a non-technical person; but maybe someone will have an idea what to do. The extension is only in the Classic Add-ons Archive ― so probably nobody's gonna update it. I'll try to ask the author.

[Moonchild]

The extension is only in the Classic Add-ons Archive ― so probably nobody's gonna update it. I'll try to ask the author.

Yeah can't really do anything about it unless someone picks up the torch to update/maintain it. It's simply not always possible to keep using old Firefox extensions.

[MrAccident]

Yeah can't really do anything about it unless someone picks up the torch to update/maintain it. It's simply not always possible to keep using old Firefox extensions.

Yeah, I know. But it's strange to me that no one does ― cause this is one of the most useful extensions for me. Maybe I'll just switch to double-click to close the tab.

[Kris_88]

this is one of the most useful extensions for me.

Post it somewhere and I'll look at it at my leisure.

[MrAccident]

Post it somewhere and I'll look at it at my leisure.

What do you mean "Post it somewhere"? The extension? The XPI file?

[Kris_88]

The XPI file.

[MrAccident]

Here.
Thanks.

[Kris_88]

Original overlay.js :

Code: Select all

      setClick: function(e)
      {
        this.getPref();

Patched:

Code: Select all

      setClick: function(e)
      {
        if(e.target.tagName && e.target.tagName.slice(0, 4) == 'xul:') return;
        this.getPref();

[MrAccident]

I extracted the content of the XPI file, made the change, but how to put it into an XPI file again?

[athenian200]

I extracted the content of the XPI file, made the change, but how to put it into an XPI file again?

Try putting it into a .zip file and then changing the extension to .xpi.

I'm pretty sure .xpi files are just .zip files in disguise.

[MrAccident]

Try putting it into a .zip file and then changing the extension to .xpi.

It says "This add-on could not be installed because it appears to be corrupt."

[athenian200]

It says "This add-on could not be installed because it appears to be corrupt."

Ugh. It's been too long since I messed with this. I do seem to remember something stupid about the way Mozilla designed the .xpi files that makes it not work if you just put them in a normal .zip file.

I remember now that you can't just use a normal .zip file, but I also don't remember what does work.

[Kris_88]

In Windows this works using the built-in zip.
I don’t know how to do this in Puppy Linux.

[MrAccident]

I'll ask in Puppy forum.

[MrAccident]

🤦 I just opened the original XPI file with Xarchiver, deleted the old file, and replaced it with the modified.
Thanks Kris_88!
I contacted JustOff to add this version; don't know if he will. But here it is anyway.

[athenian200]

🤦 I just opened the original XPI file with Xarchiver, deleted the old file, and replaced it with the modified.

That was the trick! Now I remember. You have to replace the file inside the original XPI, not create a new XPI.

You got it, dude!