nicolaasjan wrote: ↑2024-02-06, 03:30
This merged change (pull request
#321) was already implemented in the 1.16.4.31b2 build, the starting point for AstroSkipper's later releases.
See
this commit.
Thanks for the info!
In my post above, I was comparing the latest version of AstroSkipper's mod to 1.16.4.30, which is the version that most Pale Moon users have used. So naturally, I saw all the changes the beta build made, as well as AstroSkipper's mod. I started from 30 because it was the last one anyone here had vetted, and we knew nothing about any version after that, so I wound up looking over it to see if any of those post-30 changes appeared harmful at a glance, and they passed the smell test. It wasn't meant to be extensive, just sort of comparing for myself and seeing how accurate the changelogs were, and I was mostly satisfied that they were accurate, and that the few things that seemed to be missing from them were harmless. As far as filter lists, I didn't see a need to look into that because the average uBO user already knows more about updated/alternative filter lists than I do and can use their own judgement there, they don't need my help for that. So, this should mean that AstroSkipper mostly updated filter lists as he said, and all of the code changes I observed were already in the beta? That does make sense.
I was aware that there was a 1.16.4.31b2, but I didn't know who released it or where it came from, what went into it, etc. And as far as I know from reading this thread, not many Pale Moon forum users were using that beta, everyone here was basically using 30 and was either uninterested in or unaware of the beta. I did actually find uBO's GitHub later on, and decided to check if anyone had tried to commit those changes I observed, because they weren't in AstroSkipper's changelogs, and it looks like they did. I started thinking and realized that these don't look like the kind of changes that would go into a mod, but rather just some vague attempts at code clean up and addressing a very minor feature request. According to what I found on GitHub, the shortcuts thing is apparently about allowing users to bind keys to shortcuts.
https://github.com/gorhill/uBlock-for-f ... 737f9901a4
https://github.com/gorhill/uBlock-for-f ... 57fbb9be48
These are the two changes I found in WinMerge that weren't mentioned in AstroSkipper's changelogs, and they are both from a developer called hawkeye116477. So, now all the post-30 changes found in AstroSkipper's mod are seemingly accounted for. Two PRs from Hawkeye that never made it into a mainstream uBO release, plus all that stuff about filter lists he mentioned in his changelogs.
It is worth bearing in mind here that I am by no means positioning myself as an expert here. I have never used uBO, and I am not particularly knowledgeable about the JS/XUL side of the codebase. I mostly work on the C/C++ platform code in UXP itself, and only started learning a little bit about the XUL side of things recently when I created Epyrus. That is to say, I'm actually more familiar with the extension parsing code in UXP (which I have actually touched a few times), than I am with how to develop extensions themselves. I'm usually looking at all this from the other side, parsing extensions and providing hooks for them, etc. So looking at things from the extension's point of view is really backwards and counter-intuitive for me, and that's probably why I'm making so many mistakes. I know
our codebase, but I don't know the codebase of any of the extensions we use, their version numbers, where their GitHub is, etc. And so when it comes to that kind of stuff, I am kinda stumbling around in the dark more than I'd like to admit.
"The Athenians, however, represent the unity of these opposites; in them, mind or spirit has emerged from the Theban subjectivity without losing itself in the Spartan objectivity of ethical life. With the Athenians, the rights of the State and of the individual found as perfect a union as was possible at all at the level of the Greek spirit." -- Hegel's philosophy of Mind
