Page 1 of 1
Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 00:15
by tarakbumba
Since there is an announcement about soon unsupported Firefox legacy extensions and gathering about info for such extensions; I tried to fork one of my favourite extension, customize_titlebar_v2, according to forking tips posted here. I'm not a web developer and don't know these stuff but I think this fork would work. I changed extension license from MPL-GPL-LGPL trio license to GPLv2. Anyway please inspect it and test. I hope it works for you too.
Source code and relevant extension xpi can be found here :
https://github.com/tarakbumba/title-bar ... -palemoon/
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 00:42
by moonbat
tarakbumba wrote: ↑2021-04-08, 00:15
I changed extension license from MPL-GPL-LGPL trio license to GPLv2
Better check if you're allowed to do that.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 01:00
by New Tobin Paradigm
Remove META-INF completely that is jar signing and Mozilla jar signing that won't be valid.
Your install manifest is badly formatted and using an obsolete incarnation of the attr form (though still works it is very sub-optimal). It also wouldn't pass Phoebus Validation anyway. Let me rewrite it for you:
Code: Select all
<?xml version="1.0"?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:em="http://www.mozilla.org/2004/em-rdf#">
<Description about="urn:mozilla:install-manifest"
em:type="2"
em:id="title-bar-customizer@github.org"
em:version="1.0"
em:name="Title Bar Customizer"
em:description="Customize the browser titlebar"
em:creator="tarakbumba"
em:homepageURL="https://github.com/tarakbumba/title-bar-customizer-for-palemoon"
em:iconURL="chrome://titlebar/titlebar-logo.png"
em:optionsType="1"
em:optionsURL="chrome://titlebar/content/options.xul">
<em:contributor>Richard Berry titlebar@sidthemonkey.com</em:contributor>
<em:contributor>Ivy Durante</em:contributor>
<em:contributor>Chris Neuner http://unrealstuff.bplaced.de</em:contributor>
<em:contributor>Leszek(teo)Zyczkowski</em:contributor>
<em:contributor>el_libre www.catmidia.cat</em:contributor>
<em:contributor>hrvoje.solc at gmail.com</em:contributor>
<em:targetApplication name="Pale Moon">
<Description em:id="{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}"
em:minVersion="28.0.0a1"
em:maxVersion="29.*"/>
</em:targetApplication>
</Description>
</RDF>
I would also seriously recommend you go through set your text editor to use spaces for indentation and convert all the tabs to spaces. I recommend 2 spaces per indent level. It will not only make it easier to deal with for your self but for others to contribute to.
As for the licensing you can fork as GPL2 but I would resist going further to GPL3. But yes, Moonbat the Tri-license does allow that. I think you should just keep it as MPL 1.1 or upgrade it to MPL 2.0. It is more sane and less prone to licensing conflicts and resistant to further hostile assimilative activity.
On the subject of function testing, I will leave that to other community peers.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 12:00
by tarakbumba
Thank you very much Tobin. I'll add your rewritten install.rdf asap and do other modifications. Regarding license, İ think i'll keep gpl2 for now.
EDIT: Title Bar Customizer v. 1.1 released including modifications provided by Tobin.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 12:38
by New Tobin Paradigm
You gonna submit it to the Add-ons Site?
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 13:26
by tarakbumba
I want to but don't know how. As I said I have almost no knowledge about these extensions but just wanted to save this particular one.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-08, 13:33
by New Tobin Paradigm
You'll learn over time, I'm sure. You are already suceeding by even bothering to go this far.
Uhh, here:
http://developer.palemoon.org/addons/site/
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-09, 20:54
by tarakbumba
Updated to version 1.3:
- Added auto update capatibilty from github.
- Changed extension's unique id to a uuid
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-09, 21:02
by vannilla
tarakbumba wrote: ↑2021-04-09, 20:54
Added auto update capatibilty from github.
Wouldn't this be solved by the add-ons website?
Or do you plan to keep this as external?
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-09, 23:17
by tarakbumba
vannilla wrote: ↑2021-04-09, 21:02
tarakbumba wrote: ↑2021-04-09, 20:54
Added auto update capatibilty from github.
Wouldn't this be solved by the add-ons website?
Or do you plan to keep this as external?
I can't register to addons site. Phoebus just doesn't send verification email. So, I decided to add this capability for now as external until problem solved.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-09, 23:56
by New Tobin Paradigm
I skipped Thursday except for a few hours to eat something because Monday through Wednesday I only had maybe 10 hours total sleep. You shouldn't be contacting me for issues with registration but the Add-ons Team.
According to mail log, Google bounced it back. Easy fix tho.. All one of us has to do is go into your account and hit submit which will put it in validated status.
AND... You're all set. You will have release a version without an em:updateURL to your impromptu update.rdf so they get switched over.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-10, 08:38
by Moonchild
FTR the mail issue should also be fixed now. looks like mail configuration got lost resulting in the server trying to send mail directly to Google which for palemoon.org mail isn't a good idea because SPF etc.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-10, 09:18
by New Tobin Paradigm
Still may end up unfairly in spam but least it SHOULD get there now.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-10, 10:34
by tarakbumba
New Tobin Paradigm wrote: ↑2021-04-09, 23:56
I skipped Thursday except for a few hours to eat something because Monday through Wednesday I only had maybe 10 hours total sleep. You shouldn't be contacting me for issues with registration but the Add-ons Team.
According to mail log, Google bounced it back. Easy fix tho.. All one of us has to do is go into your account and hit submit which will put it in validated status.
AND... You're all set. You will have release a version
without an
em:updateURL to your impromptu update.rdf so they get switched over.
Thank you very much. Will I release this new update at my github? Or at addons site?
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-10, 10:39
by New Tobin Paradigm
You should update on github and your update.rdf file but don't have em:updateURL in there and just submit on the Add-ons Site.. afterword you only need to update on the Add-ons Site but of course you can still release on github too just don't need to care about update.rdf.
It is all pretty easy tho. Designed it to be.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-10, 11:09
by tarakbumba
New Tobin Paradigm wrote: ↑2021-04-10, 10:39
You should update on github and your update.rdf file but don't have
em:updateURL in there and just submit on the Add-ons Site.. afterword you only need to update on the Add-ons Site but of course you can still release on github too just don't need to care about update.rdf.
It is all pretty easy tho. Designed it to be.
Thank you. I updated extension to 1.4 version with removal of update url and after that submitted to Add-ons Site.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-11, 09:31
by back2themoon
Many thanks and well done for
releasing it.
Re: Forking customize-titlebar: Title Bar Customizer
Posted: 2021-04-11, 12:42
by tarakbumba
Thank you.