FORK of Select like a boss

Add-ons for Pale Moon and other applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

vannilla
Moon Magic practitioner
Moon Magic practitioner
Posts: 2193
Joined: 2018-05-05, 13:29

Re: FORK of Select like a boss

Unread post by vannilla » 2021-04-06, 11:27

Ah but wait, the UUID was Pale Moon's, not the extension.
Do not change that. Reinstate the ec8... id where it was.
Also change the version, that's not exactly a reasonable version and depending on how things are programmed internally, it might be rejected.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-06, 11:39

I fixed is now is correct:

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>2015.4.24.2.1-signed.1-signed</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) - Forked by Select like a Boss by Dzianis Rusak ;)</em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Palemoon -->
    <em:targetApplication>
      <Description>
	      <em:id>{01db586a-f296-4980-97a2-d238b1c32a3c}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>30.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    </Description>
</RDF>
But maybe like Vanilla said, it does new error.
Uploading now i get:
em:targetApplication does not contain a currently supported application id
How can i know Palemoon ID ?

User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

Re: FORK of Select like a boss

Unread post by jobbautista9 » 2021-04-06, 11:49

You can see Pale Moon's ID which is {8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4} on its application.ini file on the folder where it is installed.
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-06, 12:02

It's ready.
I add ID Palemoon.
I copied it from another Addon :D
Now it is uploaded.
A question: email is visible and it can to be changed ?
Bye
Francesco bat

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-06, 12:27

That version number is unacceptable.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-06, 12:54

New Tobin Paradigm wrote:
2021-04-06, 12:27
That version number is unacceptable.
It’s not just that.
Verifying files i see references to Select Like A Boss in some strings like in bootstrap.js:

Code: Select all

chrome://SelectLikeABoss/content/'
Do i must to edit also these, except the license, of course ?
Bye
Francesco bat

User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

Re: FORK of Select like a boss

Unread post by jobbautista9 » 2021-04-06, 13:05

If you edited the name on chrome.manifest, then you need to change the chrome:// urls as well.
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-06, 13:31

Thank you very much to everyone.
It's edited and uploaded and i installed it from file in Palemoon and disabled Select Like A Boss and all work :D
I wait your final choice and any other change to be made ;)
Bye
Francesco bat

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-07, 13:44

Dude I am gonna have to purge this extension and your second one because of the version number. How Mozilla Toolkit version numbers compares to one another does not work like you think they would when you stray outside a few established conventions especially when you have dashes in them.. Phoebus follows the same rules. Just use a regular X.y.z type of versioning and resubmit. If you really are bent on using a date then consider either YYYYMMDD or YYYY.MM.DD (not the US or EU date order) as the version.

For more info please see: http://udn.realityripple.com/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIVersionComparator

As I said in the other thread, these kinds of easily catchable mistakes should be checked for by you or your community peers before you ever submit for review to the Add-ons Site and removal due to issues like this can currently only be done by me and ONLY me.. manually. Ryan or FranklinDM can't do it and Moonchild hasn't been trained to. If you want the background on that it is simply this: I intentionally did not code a way to delete invalid extensions because I was totally against the tenancy of those, when it was still FTP controlled, to just ragedelete everything nor did I want to give the Add-ons Team the power to just delete stuff on a whim. Given these are the fifth and six extensions I have had to purge, due to mistakes, in the past month or so perhaps that was a mistake to not at least code it in for Phoebus Administrators and the Add-ons Team Leader.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 15:09

New Tobin Paradigm wrote:
2021-04-07, 13:44
Dude I am gonna have to purge this extension and your second one because of the version number. How Mozilla Toolkit version numbers compares to one another does not work like you think they would when you stray outside a few established conventions especially when you have dashes in them.. Phoebus follows the same rules. Just use a regular X.y.z type of versioning and resubmit. If you really are bent on using a date then consider either YYYYMMDD or YYYY.MM.DD (not the US or EU date order) as the version.

For more info please see: http://udn.realityripple.com/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIVersionComparator

As I said in the other thread, these kinds of easily catchable mistakes should be checked for by you or your community peers before you ever submit for review to the Add-ons Site and removal due to issues like this can currently only be done by me and ONLY me.. manually. Ryan or FranklinDM can't do it and Moonchild hasn't been trained to. If you want the background on that it is simply this: I intentionally did not code a way to delete invalid extensions because I was totally against the tenancy of those, when it was still FTP controlled, to just ragedelete everything nor did I want to give the Add-ons Team the power to just delete stuff on a whim. Given these are the fifth and six extensions I have had to purge, due to mistakes, in the past month or so perhaps that was a mistake to not at least code it in for Phoebus Administrators and the Add-ons Team Leader.
Ok!
I edited it but i don't upload it if it has still errors.
Here's the install.rdf:

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>202104.1.0</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) - Forked by Select like a Boss by Dzianis Rusak ;)</em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Palemoon -->
    <em:targetApplication>
      <Description>
	      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>30.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    </Description>
</RDF>
I wait for upload it :)
Bye
Francesco bat

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-07, 15:33

Yes that will functionally work but it looks really fucking stupid. Are you being intentionally thick? Also, don't quote entire posts if they are more than a few lines, that IS a forum rule.

User avatar
jobbautista9
Keeps coming back
Keeps coming back
Posts: 784
Joined: 2020-11-03, 06:47
Location: Philippines
Contact:

Re: FORK of Select like a boss

Unread post by jobbautista9 » 2021-04-07, 15:59

It's better if you use 29.* as your maxVersion instead, since there's no 30 release yet. It will also helped other users know what versions this extension is compatible on.

Also, you might want to cut the description up to "(like in Opera'12 browser)" instead. You can always put where it was forked from in the add-on's page in the repository instead. I personally prefer to keep the description as short as possible.
Image

merry mimas

XUL add-ons developer. You can find a list of add-ons I manage at http://rw.rs/~job/software.html.

Mima avatar by 絵虎. Pixiv post: https://www.pixiv.net/en/artworks/15431817

Image

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 19:19

Here's:

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>202104.1.0</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) ;) </em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Palemoon -->
    <em:targetApplication>
      <Description>
	      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>29.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    </Description>
</RDF>
You say me if it is all right :)
Bye
Francesco bat

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-07, 19:57

It would still be great if you used a more standard versioning scheme. You are literally telling it is is Major version 202104.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 20:19

I'm sorry for confusion i created.
Just now i saw other addons have not name version like date.
I deleted date and i leave just 1.0 (this also for second extension in other post).
Now it is:

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>1.0</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) ;) </em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Palemoon -->
    <em:targetApplication>
      <Description>
	      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>29.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    </Description>
</RDF>
Is it ok ?

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-07, 20:33

Looks fine to me. Question: Do you want it to also target Basilisk? Have you seen if it works? Cause little-to-no-effort multi-application support is a good thing imo.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 21:15

It's strange.
I tried now but it can not to install in Basilisk because incompatible.
I edited so (i don't think it is wrong):

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>1.0</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) ;) </em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Palemoon -->
    <em:targetApplication>
      <Description>
	      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>29.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    </Description>
    <em:targetApplication>
	    <Description>
		    <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
		    <em:minVersion>52.0</em:minVersion>
		    <em:maxVersion>56.*</em:maxVersion>
		    <em:basilisk>true</em:basilisk>
	    </Description>
    </em:targetApplication> 
</RDF>

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 21:42

It's strange because the firefox version works :crazy:

New Tobin Paradigm

Re: FORK of Select like a boss

Unread post by New Tobin Paradigm » 2021-04-07, 21:56

Your RDF isn't well formed. I fixed it:

Code: Select all

<?xml version='1.0' encoding='utf-8'?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:type>2</em:type>
    <em:name>Select Links Like A Leader</em:name>
    <em:id>SelectLinksLikeALeader@francescoinblack</em:id>
    <em:version>1.0</em:version>
    <em:description>Select link's text just like a regular text (like in Opera'12 browser) ;) </em:description>
    <em:creator>Francescoinblack</em:creator>
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:bootstrap>true</em:bootstrap>
    <!-- Pale Moon -->
    <em:targetApplication>
      <Description>
        <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>29.*</em:maxVersion>
      </Description>
    </em:targetApplication>
    <!-- Basilisk -->
    <em:targetApplication>
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>52.0</em:minVersion>
        <em:maxVersion>56.*</em:maxVersion>
        <em:basilisk>true</em:basilisk>
      </Description>
    </em:targetApplication> 
  </Description>
</RDF>
But try this alt-form which uses mostly attributes instead of tags as it tends to be much easier to read:

Code: Select all

<?xml version="1.0"?>

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:em="http://www.mozilla.org/2004/em-rdf#">

  <Description about="urn:mozilla:install-manifest"
               em:type="2"
               em:id="SelectLinksLikeALeader@francescoinblack"
               em:version="1.0"
               em:name="Select Links Like A Leader"
               em:description="Select link's text just like a regular text (like in Opera'12 browser) ;)"
               em:creator="Francescoinblack"
               em:bootstrap="true">
    <em:contributor>Dzianis Rusak</em:contributor>
    <em:targetApplication name="Pale Moon">
      <Description em:id="{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}"
                   em:minVersion="29.0.0a1"
                   em:maxVersion="29.*"/>
    </em:targetApplication>
    <em:targetApplication name="Basilisk">
      <Description em:id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
                   em:minVersion="52.9"
                   em:maxVersion="52.*"/>
    </em:targetApplication>
  </Description>
</RDF>
Last edited by New Tobin Paradigm on 2021-04-07, 22:30, edited 1 time in total.

francesco bat

Re: FORK of Select like a boss

Unread post by francesco bat » 2021-04-07, 22:20

Yes.
It's installed, tried and it works :thumbup:
Now one thing I didn’t understand: the extension now works because the rdf shape has been modified, or because there was a specific error?
Sorry about the stupid question, but since the form has changed a lot, I can’t tell if there was a specific mistake I made. ;)
Bye
Francesco bat

Locked