Pentadactyl ceases to work after 28.5.0 upgrade

[pmnight]

After upgrading Pale Moon to 28.5.0 the extension Pentadactyl (Version 1.2pre-pm-3 - https://addons.palemoon.org/addon/pentadactyl/) no longer initializes. The add-ons manager shows it enabled but the browser behaves as if it is not.

[yami_]

Code: Select all

Timestamp: 2019-04-30 23:40:32
Error: /^function .*?\((.*?)\)/.exec(...) is null
Source File: resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm
Line: 927

[Moonchild]

Possibly this is because of the toString() implementation update in accordance with the TC39 proposal.

[New Tobin Paradigm]

It isn't backwards compatible? Well, I guess not. Anything we can do to make it a bit more backwards compatible?

[Man09]

The last version of Vimperator is now working, and it's WAAAAY faster than Pentadactyl.
I'm so glad for this update!
https://github.com/vimperator/vimperator-labs/releases

[Moonchild]

It isn't backwards compatible? Well, I guess not. Anything we can do to make it a bit more backwards compatible?

No, it isn't backwards compatible and we can't make it backwards compatible. The spec for function.prototype.toString() changed and unfortunately it's a breaking (behavioral) change. Extensions will have to update for it.
Here's the revision text: http://tc39.github.io/Function-prototype-toString-revision/
If there is a version of pentadactyl that was updated for Firefox 54 that can be adapted for use on Pale Moon then that should work (or port the relevant patches for it back to the current version)

[Tomaso]

I guess this is the same change which breaks functionality for the "Contextual Google Image Search" extension then?:
viewtopic.php?f=3&t=21461#p165838
It's no big deal, since there are other working alternatives, like the one posted by PaulN in the same thread.
Just curious to know.

[New Tobin Paradigm]

You COULD help developers fix it by making them aware of it.

[Man09]

Vimperator do work but there is 2 issues I have:
- the shortcut

Code: Select all

gi

which is used to focus an insert text zone doesn't work unless you already have focused a text zone once on the current webpage, I get the error

m.getClientRects is not a function

- The .vimperattorc is ignored

[pete_irl]

If there is a version of pentadactyl that was updated for Firefox 54 that can be adapted for use on Pale Moon then that should work (or port the relevant patches for it back to the current version)

There is a source patch for the Pale Moon fork of pentadactyl that makes it work with PM 28.5.0. It can be found at the github repository here: https://github.com/madand/pentadactyl-pm/issues/7

There's no new release XPI yet, but anyone comfortable with git and make can generate their own.

[Man09]

There is a source patch for the Pale Moon fork of pentadactyl that makes it work with PM 28.5.0. It can be found at the github repository here: https://github.com/madand/pentadactyl-pm/issues/7

There's no new release XPI yet, but anyone comfortable with git and make can generate their own.

Is it as sluggish as it was before? Because I switched to Vimperator and it is extremely faster than Pentadactyl was on 28.4.
There is only two small issues which should be easy to fix fore someone who know how.

[yami_]

Pentadactyl was always sluggish. Especially after the switch to UXP.

[pete_irl]

There is a source patch for the Pale Moon fork of pentadactyl that makes it work with PM 28.5.0. It can be found at the github repository here: https://github.com/madand/pentadactyl-pm/issues/7

There's no new release XPI yet, but anyone comfortable with git and make can generate their own.

Is it as sluggish as it was before? Because I switched to Vimperator and it is extremely faster than Pentadactyl was on 28.4.
There is only two small issues which should be easy to fix fore someone who know how.

I guess it depends how you define sluggish!

I tried Vimperator for a while before moving to Pentadactyl. I just found the Pentadactyl features better suited to my needs, and I don't have any issues with the performance.

It's good to have the choice.

[Man09]

I guess it depends how you define sluggish!

For exemple when I try to open with o or t, it can take like 1 second to load, or if I try to open a link with f it is also delayed. And it slow down the browser. Whereas Vimperator is at least 10 times faster. I run linux.
In terms of features I see pentadactyl as an old vimperator with slightly different shortcuts and less features, maybe I am ignorant.

If someone could hint to a way of resolving the 3 following issues I see in vimperator it'll be highly appreciated:

- the shortcut gi which is used to focus an insert text zone doesn't work unless you already have focused a text zone once on the current webpage, I get the error

Code: Select all

m.getClientRects is not a function

- The .vimperattorc is not detected, and the :source command to source a vimperatorrc is absent
- The help command is absent, I guess because it can't access the help files

I suspect the two last issues are linked, to a lack of browsing the file system.
None of these issues are present with firefox 52.

[Moonchild]

Please do not hijack this thread with vimperator support requests. Contact vimperator maintainers for that instead or if just a usability/config issue, make a separate topic!

I see pentadactyl as an old vimperator with slightly different shortcuts and less features, maybe I am ignorant.

That is quite possible, seeing that they are completely different extensions with no specific relationship.

[DNied]

There is a source patch for the Pale Moon fork of pentadactyl that makes it work with PM 28.5.0. It can be found at the github repository here: https://github.com/madand/pentadactyl-pm/issues/7

There's no new release XPI yet, but anyone comfortable with git and make can generate their own.

I can confirm that the patch works! Since I've built the patched version for myself, I'll host the XPI file on my own website (Moderator note: link removed) until there's an official release. If anyone has done the same, please confirm the resulting XPI's md5 hash as:

Code: Select all

8d970b276e0ec28cd8022eab7673c7be

[New Tobin Paradigm]

Don't do this, please remove the link.

[Man09]

Please do not hijack this thread with vimperator support requests. Contact vimperator maintainers for that instead or if just a usability/config issue, make a separate topic!

I see pentadactyl as an old vimperator with slightly different shortcuts and less features, maybe I am ignorant.

That is quite possible, seeing that they are completely different extensions with no specific relationship.

Off-topic:
Well, Pentadactyl is a fork of Vimperator.
Pentadactyl is significantly slowing down Palemoon. At this point, wether part of Pentadactyl should be rewritten or most people should switch to Vimperator.
Sorry for hijacking the topic, I made a new topic here: viewtopic.php?f=46&t=21989

[pmnight]

Off-topic:
Well, Pentadactyl is a fork of Vimperator.
…

Fair point except I wouldn't expect Firefox's developers to receive any of Pale Moon's bug reports (despite my opinion of how much better a program it is). Depending on how many generations apart Vimperator is from Pentadactyl the bugs may be completely different.

[pmnight]

I just update Pale Moon (28.6.0) and now the patched version doesn't work and I'm getting these errors in the browser console:

Code: Select all

pentadactyl: Pentadactyl fully initialized
[Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: resource://dactyl/bootstrap.jsm -> resource://dactyl/services.jsm :: _create :: line 124"  data: no]  
(unknown)
	_create@resource://dactyl/services.jsm:124:23
	add/<@resource://dactyl/services.jsm:165:35
	g_replaceProperty@resource://dactyl/base.jsm:797:78
	initLoad/<@resource://dactyl-content/dactyl.js:1969:1
	timeout_notify@resource://dactyl/base.jsm:1134:17
[Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm :: XPCOMShim/< :: line 1283"  data: no]  
(unknown)
	XPCOMShim/<@resource://dactyl/base.jsm:1283:55
	XPCOMShim@resource://dactyl/base.jsm:1283:13
	addClass/<@resource://dactyl/services.jsm:187:33
	g_replaceProperty@resource://dactyl/base.jsm:797:78
	_create@resource://dactyl/services.jsm:131:1
	addClass/this[name]@resource://dactyl/services.jsm:190:35
	writeNext@resource://dactyl/protocol.jsm:259:30
	XMLChannel@resource://dactyl/protocol.jsm:237:5
	Channel@resource://dactyl/protocol.jsm:33:17
	newChannel@resource://dactyl/protocol.jsm:146:24
	_loadOverlay/<@resource://dactyl/overlay.jsm:340:41
	insert@resource://dactyl/overlay.jsm:321:25
	_loadOverlay@resource://dactyl/overlay.jsm:340:9
	overlayWindow@resource://dactyl/overlay.jsm:246:13
	_init@resource://dactyl-content/mow.js:58:9
	init@resource://dactyl-content/mow.js:21:9
	mow@resource://dactyl/base.jsm line 912 > eval:10:23
	time@resource://dactyl/base.jsm:123:19
	loadModule@resource://dactyl/main.jsm:327:27
	get@resource://dactyl/main.jsm:389:36
	get mowEvents@resource://dactyl-content/commandline.js:970:23
	init@resource://dactyl/template.jsm:166:34
	Events@resource://dactyl/base.jsm line 912 > eval:10:23
	highlightNode@resource://dactyl/highlight.jsm:245:21
	tag@resource://dactyl/dom.jsm:1714:17
	fromJSON/tag/<@resource://dactyl/dom.jsm:1710:34
	tag@resource://dactyl/dom.jsm:1709:13
	fromJSON/tag/</<@resource://dactyl/dom.jsm:1668:42
	fromJSON/tag/<@resource://dactyl/dom.jsm:1667:21
	tag@resource://dactyl/dom.jsm:1664:17
	fromJSON@resource://dactyl/dom.jsm:1723:16
	insert@resource://dactyl/overlay.jsm:313:36
	_loadOverlay@resource://dactyl/overlay.jsm:338:9
	overlayWindow@resource://dactyl/overlay.jsm:246:13
	init@resource://dactyl-content/commandline.js:17:9
	CommandWidgets@resource://dactyl/base.jsm line 912 > eval:10:23
	CommandLine<.widgets<@resource://dactyl-content/commandline.js:640:34
	g_Memoize@resource://dactyl/base.jsm:1051:64
	echo@resource://dactyl-content/commandline.js:800:29
	echoerr@resource://dactyl-content/dactyl.js:429:9
	initLoad/<@resource://dactyl-content/dactyl.js:1985:17
	timeout_notify@resource://dactyl/base.jsm:1134:17