Need help to fix the uBlock Origin logger

General discussion, compatibility and contributed extensions.

Moderators: Lootyhoof, FranklinDM

Locked
User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-19, 18:19

gorhill has declined to fix this issue in uBO Legacy:
https://github.com/uBlockOrigin/uBlock- ... ssues/385/
..but points out that "pull requests are welcomed".
Anyone feel up to the task?
Last edited by Moonchild on 2019-01-20, 06:49, edited 2 times in total.
Reason: Topic clarification

User avatar
JustOff
Moon Magic practitioner
Moon Magic practitioner
Posts: 2083
Joined: 2015-09-03, 19:47
Location: UA
Contact:

Re: uBlock Origin

Post by JustOff » 2019-01-19, 18:45

Off-topic:
Please use more specific topic titles, i.e. "Need help to fix the uBlock Origin logger" instead of just "uBlock Origin".
Here are the add-ons I made in a spare time. That was fun!

If you have any questions or problems regarding the migration of my extensions to GitHub, feel free to contact me through a PM.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 703
Joined: 2016-04-11, 01:26

Re: uBlock Origin

Post by Fedor2 » 2019-01-19, 19:49

I want to help.
checked with rule ##iframe[src*="annonse"]
https://www.dagbladet.no/annonse/70179055/

And did not get what that rule do actually, see no difference.
Me was used only || and @@ type rules.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: uBlock Origin

Post by Tomaso » 2019-01-19, 22:07

JustOff wrote:
Off-topic:
Please use more specific topic titles, i.e. "Need help to fix the uBlock Origin logger" instead of just "uBlock Origin".
The other generic "uBlock Origin" thread has been locked, so I figured it would be a good idea to start a new one.

--
Fedor2 wrote:checked with rule ##iframe[src*="annonse"]
https://www.dagbladet.no/annonse/70179055/

And did not get what that rule do actually, see no difference.
Try this one instead then:

Code: Select all

###cookie:not(body):not(html):not([href*="cookieclicker"])
..at https://www.acronis.com/en-us/support/contact-us/.
Perhaps it's more apparent, at your end.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 703
Joined: 2016-04-11, 01:26

Re: Need help to fix the uBlock Origin logger

Post by Fedor2 » 2019-01-20, 09:11

See no difference either, so i consider that type rules maybe for newer ublock only.
Can you just tell what is it to change or block?

update:
According https://kb.adguard.com/en/general/how-t ... les-syntax
### is hiding an element, does it mean that it hide the cookie and all? what is the point?

update2:
Made test page with test div id element but the rule hides nothing... but do hide on the basilisk with ublock 17.4.

Conclusion:
To show in the logger at first the rule handler is to be ported from the newer version.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-20, 10:54

Don't know why you aren't seeing it, because both of them should be very easy to spot!

Example #1:
At https://www.acronis.com/en-us/support/contact-us/, the following rule blocks the support modules:

Code: Select all

###cookie:not(body):not(html):not([href*="cookieclicker"])
Screenshot:
Image

Example #2:
At https://www.dagbladet.no/annonse/70179055/, the following rule blocks the embeded video:

Code: Select all

##iframe[src*="annonse"]
Screenshot:
Image

Neither one of these rules shows up in uBO Legacy's logger.

User avatar
Fedor2
Astronaut
Astronaut
Posts: 703
Joined: 2016-04-11, 01:26

Re: Need help to fix the uBlock Origin logger

Post by Fedor2 » 2019-01-20, 11:33

This i get already, rule must hide those things, but it does not work, nothing is hidden, even with all other addons disabled. Does it works for you?

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-20, 11:42

Yes, it works just fine.
Pehaps you've accidentally disabled cosmetic filtering or something?
('Dashboard' > 'Settings' > 'Default behavior' > "Disable cosmetic filtering")

User avatar
Fedor2
Astronaut
Astronaut
Posts: 703
Joined: 2016-04-11, 01:26

Re: Need help to fix the uBlock Origin logger

Post by Fedor2 » 2019-01-20, 12:26

Oh, that was "Ignore generic cosmetic filters".

Now the test works and shows in the logger properly.
Image
however on support.acronis.com not shows.
Doing further research...

User avatar
Fedor2
Astronaut
Astronaut
Posts: 703
Joined: 2016-04-11, 01:26

Re: Need help to fix the uBlock Origin logger

Post by Fedor2 » 2019-01-20, 19:52

Well i got this fixed, your rules both show properly and nothing wrong is happens.
But i do not fully understand that stuff, and shall be making request to gorhill.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-20, 20:13

Yes, I noticed your post @ GitHub.
Great work! :)

Awaiting gorhill's response.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 29306
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Need help to fix the uBlock Origin logger

Post by Moonchild » 2019-01-22, 12:57

Somehow I doubt Gorhill will be wanting to do anything specific for us at this point, especially considering he's painting us black on Reddit apparently about "not giving credit for Mozilla patches" -- while the truth of the matter is that our patches are merely based on the work Mozilla does, and code is kept similar on purpose (e.g. variable names) for future code comparisons, but they are written specifically for UXP (and if not, patches applied will have the Mozilla authorship data on them).
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8946
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: Need help to fix the uBlock Origin logger

Post by New Tobin Paradigm » 2019-01-22, 14:24

Are we *gulp* stealing code from Mozilla again? Oh no, we must stop at once!
As a young boy, I dreamed of being a baseball.
But tonight I say, we must move forward, not backward; upward, not forward; and always twirling, twirling, twirling towards freedom!

Image

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1323
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: Need help to fix the uBlock Origin logger

Post by Isengrim » 2019-01-22, 16:17

Off-topic:
I have a hard time believing that Moonchild would have made such an egregious mistake in fulfilling the obligations of the MPL 2.0 license (or any other license), or that if such a mistake had been made, that it would not be properly rectified in a timely fashion.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2606
Joined: 2015-09-26, 04:51
Location: U.S.

Re: Need help to fix the uBlock Origin logger

Post by coffeebreak » 2019-01-22, 16:24

Off-topic:
Moonchild wrote:Somehow I doubt Gorhill will be wanting to do anything specific for us at this point, especially considering he's painting us black on Reddit apparently about "not giving credit for Mozilla patches"

Link to gorhill's Reddit post, so people can read it directly:
https://www.reddit.com/r/firefox/comments/ai95us/basilisk_browser_drops_webextension_support/een8fr0/


Respectfully, there is no basis to connect gorhill's opinions on Pale Moon patch attribution with his response to an issue a user raises in the legacy branch of uBO. I have never seen a sign that he makes decisions in that manner, but rather decides based on particulars of each issue.

If you want to respond to what was posted, why not do that directly in Reddit?
Or in the alternative, make a blog post?
But in any case, please consider to leave this support thread in peace to deal purely with the logger issue raised.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-22, 18:14

coffeebreak wrote:If you want to respond to what was posted, why not do that directly in Reddit?
If someone does, please stick to facts, and avoid flaming the situation.
I fear that a heated discussion only will serve to hurt us so-called "legacy" users even further.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 29306
Joined: 2011-08-28, 17:27
Location: Tranås, SE
Contact:

Re: Need help to fix the uBlock Origin logger

Post by Moonchild » 2019-01-22, 20:25

Off-topic:
Isengrim wrote:I have a hard time believing that Moonchild would have made such an egregious mistake in fulfilling the obligations of the MPL 2.0 license (or any other license), or that if such a mistake had been made, that it would not be properly rectified in a timely fashion.
For the record, there is no attribution clause in the MPL 2.0 that requires all sources of research for patches written OR for patches themselves be credited. I'm also pretty sure that everyone committing the patches to Mozilla that were used to create our patches are already mentioned as authors to the Mozilla code (also in our tree, see the authors file).
If patches would apply directly, I have to the best of my knowledge also always retained the original authorship mention of those patches. See the smattering of names mentioned on github as commit contributors.
As always, too, if someone wants to be credited who isn't yet credited as a contributor, they only have to ask.

I think what some people are disgruntled about is that I don't tend to retain Bugzilla bug numbers since they do not apply to our own bug tracking, and in the case of sec bugs I additionally don't see a reason to paint a bulls-eye on a potential problem either if linked to a bug that requires sec authorization to view.
"Son, in life you do not fight battles because you expect to win, you fight them merely because they need to be fought." -- Snagglepuss
Image

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1569
Joined: 2015-07-23, 16:09
Location: Norway

Re: Need help to fix the uBlock Origin logger

Post by Tomaso » 2019-01-30, 16:53


User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 8946
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: Need help to fix the uBlock Origin logger

Post by New Tobin Paradigm » 2019-01-30, 22:55

Why are you cross-posting.. This isn't a thing that is allowed since Mozillazine.. Please stop.

MODERATOR: Please clean this up.
As a young boy, I dreamed of being a baseball.
But tonight I say, we must move forward, not backward; upward, not forward; and always twirling, twirling, twirling towards freedom!

Image

User avatar
Admin
Site Admin
Site Admin
Posts: 328
Joined: 2012-05-17, 19:06

Re: Need help to fix the uBlock Origin logger

Post by Admin » 2019-01-31, 13:00

Crossposts removed, warning issued.
Did you know that moral outrage triggers the pleasure centers of the brain? It's unlikely you can actually get addicted to outrage, but there is plausible evidence that you can become strongly predisposed to it.
Source: https://www.bbc.co.uk/programmes/p002w557/episodes/downloads - "The cooperative species" and "Behaving better online"
Image

Locked