Redirector addon: stopped working since v28

[ketmar]

this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.

[TMINY]

this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.

This works! Thank you so much!

[New Tobin Paradigm]

Why isn't anyone forking this extension properly?

[Baloo]

this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.

Thank you so much! This is very much appreciated. Now someone just needs to make it an official fork!

[IMNdi]

This was working great until recently. Redirects aren't working... I noticed the preferences screen is empty of my rules and the buttons are non-responsive.
Anyone have any ideas on a fix? Thanks!

redirector_fixed is working here.
My only redirect works, as do buttons.

Mine's broken all right. When opening the addon setting page the console produces this:

Error: TypeError: this.unwatch is not a function
Source File: chrome://redirector/content/js/redirectorprefs.js
Line: 25

Buttons don't do anything.

[TMINY]

Mine's broken all right. When opening the addon setting page the console produces this:

Error: TypeError: this.unwatch is not a function
Source File: chrome://redirector/content/js/redirectorprefs.js
Line: 25

Buttons don't do anything.

Have a look at ketmar's fix up above. That got mine working.

[Moonchild]

I'd like to make a point here that watch() and unwatch() have never been part of any ECMAScript version, contrary to what Ketmar has said.
They have been internal Firefox-only functions that, unfortunately, extension devs have been using regardless.

[ketmar]

yeah, i meant "in new Pale Moon js engine versions", but got it wrongly worded. sure, those calls are not in any official ES specification, and Pale Moon is not dropping something that was standardized. sorry.

[Moonchild]

yeah, i meant "in new Pale Moon js engine versions", but got it wrongly worded. sure, those calls are not in any official ES specification, and Pale Moon is not dropping something that was standardized. sorry.

It's an easy mistake to make, no worries -- just wanted to clarify the situation.

[IMNdi]

Have a look at ketmar's fix up above. That got mine working.

Oh sorry, I read the thread wrong I thought that's what the fix does.
Thanks for the heads up, fortunately the website that needed correction was fixed server-side so I am abandoning for now.

[JohnAJ]

Thanks. I had given up on this. therube was kind enough to point this thread out to me at the end of my older one. Here is a corrected xpi for anybody who'd rather not do it themselves:redirector_fixed.xpi

this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.

Here's an updated xpi for those who prefer to just download a ready-made file

Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.

[Andrew Herbert]

Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.

Why? The other modified extension was allowed.

[Lew Rockwell Fan]

If somebody is going to work on this, may I make a suggestion (actually a shameless begging plea) to add an option to automatically send the regex matching url to an external program instead of opening an alternate url? There are probably a fair number of us who haven't managed to get a grip on xml and such but can still do some neat tricks with bash if the browser will just throw us a string.

I can do it with "Open With" but not automatically - I have to both know (and sometimes urls are hidden to casual view) and notice (which is a different matter) that the url is of a class I'd like to treat differently.

Thanks either way.

[Andrew Herbert]

What about the versions 3.0.4 and 3.0.6? The error console doesn't show anything.

[Andrew Herbert]

The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?

[Moonchild]

The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?

Because Pale Moon and Basilisk are not Firefox.
Please get this through your thick skull. Thank you.

[letmeindude]

The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?

Version 3.0.6 removed local copy of ExtensionStorage.jsm, because it ships with FF 44 and newer. Pale Moon is not Firefox.

Just copy ExtensionStorage.jsm from 3.0.4 maybe it will work.

[New Tobin Paradigm]

We could bring that jsm back.. While it landed as part of the initial WebExtensions bullshit it actually isn't dependent WebEx it but WebEx was dependent on it.

We will consider it. No promises.

EDIT: https://github.com/MoonchildProductions/UXP/commit/5e03c9ad4cf63c3f15e19a0dd0d1ea5b8f9abed2

[Baloo]

It seems that even with bringing that jsm back, Redirector 3.0.6 does not function. Installs, but won't save or activate any created redirects. Looks like this add-on just needs a old-fashioned fork...

[Moonchild]

Well we tried. And it would also allow other extensions using the (otherwise stand-alone) module to work.