ABL 5.0.0 "Contribute button" Topic is solved

Add-ons for Pale Moon and other applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

ABL 5.0.0 "Contribute button"

Unread post by coffeebreak » 2018-04-09, 22:24

Adblock Latitude 5.0.0 reinstated the Adblock Plus "Contribute button" to ABL's toolbar button menu (it had been removed from previous versions of ABL, including 4.0.1).

With 5.0.0, the button was rebranded for Adblock Latitude, but it links to the Adblock Plus contribution page:
https://adblockplus.org/en/contribute
For both installations, extensions.adblockplus.hideContributeButton = false (the default)

ABL 5.0.0
contribButton-5.0.0.png
contribButton-5.0.0.png (12.91 KiB) Viewed 788 times
ABL 4.0.1
noContribButton-4.0.1.png
noContribButton-4.0.1.png (7.62 KiB) Viewed 788 times

Lunix

Re: ABL 5.0.0 "Contribute button"

Unread post by Lunix » 2018-04-09, 23:16

If you click the 'x' it never returns.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: ABL 5.0.0 "Contribute button"

Unread post by coffeebreak » 2018-04-10, 00:01

Lunix wrote:If you click the 'x' it never returns.

Yes, I'm aware. Clicking the 'x' changes: extensions.adblockplus.hideContributeButton to true.

But I'm wondering if that button shouldn't be removed anyway, because of the improper linkage (to ABP).
(It had been removed from earlier versions of ABL, maybe at least in part for that very reason.)

New Tobin Paradigm

Re: ABL 5.0.0 "Contribute button"

Unread post by New Tobin Paradigm » 2018-04-10, 00:51

Because Adblock Latitude had a codebase refresh and everything I ever did was kinda wiped out and started again.. Why don't you submit a pull request and properly remove it... Or switch to ABPrime.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: ABL 5.0.0 "Contribute button"

Unread post by coffeebreak » 2018-04-10, 02:50

New Tobin Paradigm wrote:Because Adblock Latitude had a codebase refresh and everything I ever did was kinda wiped out and started again.
Yes, I know.

The retention of that button seemed (to me) like something that just fell through the cracks (i.e., why would ABL on purpose display a "Contribute Button" to support a different adblocker?)

Since Moonchild refreshed the codebase and maintains ABL, I was hoping this thread would catch his attention, so he might address this if he chooses. Or leave the button in place, if that's his decision.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35484
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: ABL 5.0.0 "Contribute button"

Unread post by Moonchild » 2018-04-10, 08:15

New Tobin Paradigm wrote:Because Adblock Latitude had a codebase refresh and everything I ever did was kinda wiped out and started again.
What do you care apart from wanting to be negative about ABL ever since you forked off with ABPrime? Because that's all you've been doing lately.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35484
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: ABL 5.0.0 "Contribute button"

Unread post by Moonchild » 2018-04-10, 08:31

Fixed in v5.0.1
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: ABL 5.0.0 "Contribute button"

Unread post by coffeebreak » 2018-04-10, 14:10

Moonchild, thank you for the fix.

Locked