ViewImage for Google Image Search script

Add-ons for Pale Moon and other applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

tor000

Re: ViewImage for Google Image Search script

Unread post by tor000 » 2018-06-07, 20:05

Where are the posts? How I can get version 1.3?

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-06-07, 20:47

tor000 wrote:Where are the posts?
On the very same page that you submitted your previous post.
Read up!

Brian

Re: ViewImage for Google Image Search script

Unread post by Brian » 2018-06-07, 21:38

tor000 wrote:Where are the posts? How I can get version 1.3?
This:
viewtopic.php?f=46&t=18397&start=20#p142821

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-06-07, 21:49

Actually, those instructions are incomplete.
You also need to extract the ZIP file, move everything out of the root folder and re-ZIP, before changing the extension type.
This becomes apparent a few posts further down.
Also, the renaming part doesn't make any sense to me (at least not under Windows).

tor000

Re: ViewImage for Google Image Search script

Unread post by tor000 » 2018-06-08, 07:10

Produced all the steps. Working correctly. The "View image" button is now appearing at Google Images.

tor000

Re: ViewImage for Google Image Search script

Unread post by tor000 » 2018-06-08, 13:12

Update: I can't change ViewImage settings. There are only two buttons: Reset and Cancel. There is no OK button.
Last edited by tor000 on 2018-06-08, 13:12, edited 1 time in total.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-06-08, 13:16

tor000 wrote:Update: I can't change ViewImage settings. There are only two buttons: Reset and Cancel. There is no OK button.
Confirmed.
Perhaps Isengrim can fix this?

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: ViewImage for Google Image Search script

Unread post by Isengrim » 2018-06-08, 13:27

Are you sure? IIRC the settings change as soon as you change them in the settings window; there is no OK button for that reason. That is how the settings window works in the Chrome version, so that is how the it was done for the XUL version.
Last edited by Isengrim on 2018-06-08, 13:53, edited 1 time in total.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-06-08, 14:17

Isengrim wrote:Are you sure? IIRC the settings change as soon as you change them in the settings window; there is no OK button for that reason.
I tried to make some changes, then simply closed the window.
..but the next time that I opened the settings, everything was back to default.
Even if it DID work, having no OK button looks very wrong and confusing.
Last edited by Tomaso on 2018-06-08, 14:20, edited 2 times in total.

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: ViewImage for Google Image Search script

Unread post by Isengrim » 2018-06-08, 16:25

Strange, it worked when I tested it, admittedly some time ago. I'll try again when I have time later today.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: ViewImage for Google Image Search script

Unread post by Isengrim » 2018-06-09, 00:21

Turns out there's a slight difference in how certain buttons are displayed on a prefwindow and with how preferences are applied, depending on the OS. :oops: (Documentation for the curious.) I've pushed a commit to fix the issue.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-06-09, 09:18

Isengrim wrote:I've pushed a commit to fix the issue.
Thanks, the settings work now. :)

tor000

Re: ViewImage for Google Image Search script

Unread post by tor000 » 2018-06-09, 14:31

I redownloaded ViewImage from the link and there is an OK button in the settings, so I can save the settings. Thanks.

tor000

Re: ViewImage for Google Image Search script

Unread post by tor000 » 2018-08-16, 17:20

Update: Viewimage stopped working in the Pale Moon of my father computer.

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: ViewImage for Google Image Search script

Unread post by Isengrim » 2018-08-16, 17:44

Looks like Google changed some CSS classes up again. The WebExtensions version has been updated to account for this. I'll put in a PR for the XUL branch when I get the chance.
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: ViewImage for Google Image Search script

Unread post by coffeebreak » 2018-08-16, 19:57

For anyone who cares to use a userscript, this one, make-gis-great-again still works.

To install it, click the "Raw" button.
raw-button.png

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-08-19, 20:48

Thanks for v1.4, Isengrim! :)

User avatar
Isengrim
Board Warrior
Board Warrior
Posts: 1325
Joined: 2015-09-08, 22:54
Location: 127.0.0.1
Contact:

Re: ViewImage for Google Image Search script

Unread post by Isengrim » 2018-08-20, 04:19

Tomaso wrote:Thanks for v1.4, Isengrim! :)
Not a problem... I need to PM bijij at some point to see if one of us can get some proper releases going, as that would make it easier for Pale Moon users to install the extension without going through the rigamarole of downloading the repo and creating the XPI themselves. :?
a.k.a. Ascrod
Linux Mint 19.3 Cinnamon (64-bit), Debian Bullseye (64-bit), Windows 7 (64-bit)
"As long as there is someone who will appreciate the work involved in the creation, the effort is time well spent." ~ Tetsuzou Kamadani, Cave Story

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: ViewImage for Google Image Search script

Unread post by Tomaso » 2018-08-20, 05:03

It would be nice if one you were able to fix this bug too (which still exist in v1.4):
https://github.com/bijij/ViewImage/issues/58/
Check out the two links that I've posted in that thread.
First click on a "related" image, then click back on the original one..
Now, if you click on "View image", it will display the wrong image (the related one that you clicked on).

Brian

Re: ViewImage for Google Image Search script

Unread post by Brian » 2018-08-21, 19:01

Isengrim wrote:
Tomaso wrote:Thanks for v1.4, Isengrim! :)
Not a problem... I need to PM bijij at some point to see if one of us can get some proper releases going, as that would make it easier for Pale Moon users to install the extension without going through the rigamarole of downloading the repo and creating the XPI themselves. :?
Please do. People like me, where Pale Moon isn't a hobby, I forget how to do this hack and have to have to find where in this thread the directions are (which apparently aren't in one post), read through the directions, and figure it out every time. :)

Locked