Issues with the Context Menu Image Saver Add-On

[Zero3K]

Its not working properly in Pale Moon. I've noticed the following things while using it:

1. The context menu items that can be made in its Settings for saving images to folder(s) don't work.
2. It pops up an error stating that I didn't set the previous download directory when using the Ctrl + Right-Click shortcut for quickly saving an image even though I did set the proper option in about:config.

You can get the extension being mentioned by going to https://addons.mozilla.org/en-US/firefo ... age-saver/.

EDIT: You can fix those issues or change the hotkey used by https://addons.mozilla.org/en-US/firefo ... in-folder/ for quickly saving an image from being a double click to being a ctrl + right-click.

[Zero3K]

Does it work properly for anyone or not?

[JustOff]

This extension fails because it detects incorrect browser APIs based on the platformVersion comparison.

You can make it work with Pale Moon 27.x by changing the following:

Code: Select all

--- bootstrap.js.orig	Fri Dec 04 12:18:06 2015
+++ bootstrap.js	Sun Feb 04 19:17:41 2018
@@ -36,8 +36,8 @@
 
 function startup(data, reason) {
     // As of Gecko 10.0, manifest registration is performed automatically.
-    if (Services.vc.compare(Services.appinfo.platformVersion, "10.0") < 0)
-        Components.manager.addBootstrappedManifestLocation(data.installPath);
+//    if (Services.vc.compare(Services.appinfo.platformVersion, "10.0") < 0)
+//        Components.manager.addBootstrappedManifestLocation(data.installPath);
 
     ["window", "menu", "io", "preferences", "utility", "update"].forEach(function (script) {
         let url = data.resourceURI.spec + "lib/" + script + ".js";
@@ -54,8 +54,8 @@
 }
 
 function shutdown(data, reason) {
-    if (Services.vc.compare(Services.appinfo.platformVersion, "10.0") < 0)
-        Components.manager.removeBootstrappedManifestLocation(data.installPath);
+//    if (Services.vc.compare(Services.appinfo.platformVersion, "10.0") < 0)
+//        Components.manager.removeBootstrappedManifestLocation(data.installPath);
 
     Cmis.preferences.shutdown();
     Cmis.window.shutdown();
     
--- lib\io.js.orig	Fri Dec 04 12:18:06 2015
+++ lib\io.js	Sun Feb 04 19:59:46 2018
@@ -44,7 +44,7 @@
 
         let filename = target.leafName;
 
-        if (Services.vc.compare(Services.appinfo.platformVersion, "26.0a1") < 0) {
+        if (false) {
             // https://developer.mozilla.org/en/nsIWebBrowserPersist
             let persist = Components
                 .classes["@mozilla.org/embedding/browser/nsWebBrowserPersist;1"]

[Zero3K]

Well, it works now but requires an entry to be added to the settings dialog box for it and that entry used for the quick save shortcut to work properly. I was hoping that it could be made to where entering in a directory to the extensions.cmis@moongiraffe.net.previousSaveAsDirectory option in about:config would get the shortcut to work properly. Also, it would be nice if it could also use Ctrl+Left-Click instead of Ctrl+Right-Click and ignore any javascript that is used by the image (such as one where the tab is closed when the image is clicked on).

[JustOff]

This add-on works only as it was intended by the author, no magic is included

[Zero3K]

This add-on works only as it was intended by the author, no magic is included

I know. It would be nice if someone could continue the development of it and include those suggestions.

EDIT: Thanks for fixing it. I will wait and see if you or someone else gets around to implementing them.

[0strodamus]

It would also be nice if someone would be more gracious and just thank JustOff for spending his valuable time getting it work, instead of asking for more and more.

[Zero3K]

I think that it should be listed on Pale Moon's Add-ons page.

[JustOff]

For this, someone who actually uses this add-on and is going to support it must first make a fork (it's unlikely it will be me).

[Zero3K]

Okay. By the way, it stopped working for some reason. No entries that are supposed to be added by it appear in the context menu when right-clicking an Image on a website.

[Zero3K]

Okay. By the way, it stopped working for some reason. No entries that are supposed to be added by it appear in the context menu when right-clicking an Image on a website.

I hope that someone can fix it soon.

[JustOff]

Sorry, but I can't help with an issue I can't reproduce; CMIS 20130929.1-signed.1-let-fixed.1-signed with the patch provided above works just fine for me.

[Zero3K]

Sorry, but I can't help with an issue I can't reproduce; CMIS 20130929.1-signed.1-let-fixed.1-signed with the patch provided above works just fine for me.

Even in the latest version of Pale Moon?

[JustOff]

Even in the latest version of Pale Moon?

Exactly so.