Night Mode Addon compatible with 27+?

Add-ons for Pale Moon and other applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-10-16, 17:35

tooshorttoolong wrote:Is it not possible to store the original state when the user asks to switch to the night mode?
Ok, it seems we can do without an extra option. Please check ANM 1.0.6b1 here.

tooshorttoolong
Fanatic
Fanatic
Posts: 137
Joined: 2017-09-11, 14:28

Re: Night Mode Addon compatible with 27+?

Unread post by tooshorttoolong » 2017-10-16, 18:41

JustOff wrote:
tooshorttoolong wrote:Is it not possible to store the original state when the user asks to switch to the night mode?
Ok, it seems we can do without an extra option. Please check ANM 1.0.6b1 here.
With that version, the "Use system colors" setting is remembered but only as long as I don’t quit Pale Moon. If I exit and restart PM then "Use system colors" is enabled again, as long as the ANM addon is not disabled.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-10-17, 09:07

tooshorttoolong wrote:With that version, the "Use system colors" setting is remembered but only as long as I don’t quit Pale Moon.
Try 1.0.6b2.

tooshorttoolong
Fanatic
Fanatic
Posts: 137
Joined: 2017-09-11, 14:28

Re: Night Mode Addon compatible with 27+?

Unread post by tooshorttoolong » 2017-10-17, 11:15

JustOff wrote:Try 1.0.6b2.
Perfect! Now it’s remembered after a restart. Thanks a lot :).

Dj_Ziio

Re: Night Mode Addon compatible with 27+?

Unread post by Dj_Ziio » 2017-11-15, 04:47

I absolute love this addon, I use it for every site I visit and haven't had a single issue until today. Trying to watch a twitch feed from AngryJoe all I got was the audio feed except for the ads. I disabled all my addons one by one until I found the culprit, which was the Advanced Night Mode addon. If I set it to disabled in the drop down menu the video will play for 1 second then go black, and its the same for every other setting. I have to click the check mark next to enabled and completely shut the addon off to get the video feed to work. I've managed to fix my issue but I was wondering why setting it to disabled was still causing it to interfere with the video feed, and why its was affecting the video feed from twitch but not the ads.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-15, 17:20

It's very odd. Can someone else confirm this issue with Twitch?

Dj_Ziio

Re: Night Mode Addon compatible with 27+?

Unread post by Dj_Ziio » 2017-11-15, 19:34

I do apologize for posting before doing more testing I was overly tired last night and didn't test enough twitch streams. It seems like its an icon that AngryJoe uses as an overlay on his site to popup when people donate that is causing the issue. I tested with all my addons off except night mode and it was enabled but set to disabled in the drop down menu. Streamlabs Loyalty Extension for the player is the culprit. I still think its odd that its causing problems with the addon set to disabled yet still on, but its probably an issue with how the Overlay is coded, not with Night Mode, and its definitely why the ads worked but his feed and a few others I checked did not. Thanks for the super quick reply and I'm sorry for wasting any of your time.

mhspacee

Re: Night Mode Addon compatible with 27+?

Unread post by mhspacee » 2017-11-15, 20:14

Hello. Dark Background and Light Text developer here.
JustOff wrote:It's very odd. Can someone else confirm this issue with Twitch?
The problem is in overlay iframes which should be transparent but aren't. See last two commits in https://github.com/m-khvoinitsky/dark-b ... /issues/51 for a way how I've fixed it.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-15, 20:55

mhspacee wrote:The problem is in overlay iframes which should be transparent but aren't. See last two commits in https://github.com/m-khvoinitsky/dark-b ... /issues/51 for a way how I've fixed it.
Hi, Mikhail, thanks for your original add-on and for the hint! I'll definitely take a closer look at it.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-15, 21:44

Dj_Ziio wrote:It seems like its an icon that AngryJoe uses as an overlay on his site to popup when people donate that is causing the issue.
Please try ANM 1.0.7b1 ANM 1.0.7b2 with the fixes suggested by the developer of the parent add-on.
Last edited by JustOff on 2017-11-15, 22:04, edited 1 time in total.

mhspacee

Re: Night Mode Addon compatible with 27+?

Unread post by mhspacee » 2017-11-15, 21:53

About "Use system colors" option overwriting: It can be safely removed (I mean overwriting of it).
"Override the colors specified by the page with my selections above" is still important.

Dj_Ziio

Re: Night Mode Addon compatible with 27+?

Unread post by Dj_Ziio » 2017-11-15, 22:17

The update fixed my issue. Thanks again for the super quick replies. This addon is da shit and I never want to have it disabled :)

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-16, 10:07

Advanced Night Mode has been updated to 1.0.7:

[±] Set background-color of only for top-level windows, not iframes

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-16, 10:12

mhspacee wrote:About "Use system colors" option overwriting: It can be safely removed (I mean overwriting of it).
Well, then I'm a little confused why it's still being processed in your jetpack release tree?

mhspacee

Re: Night Mode Addon compatible with 27+?

Unread post by mhspacee » 2017-11-16, 19:21

JustOff wrote:
mhspacee wrote:About "Use system colors" option overwriting: It can be safely removed (I mean overwriting of it).
Well, then I'm a little confused why it's still being processed in your jetpack release tree?
It's because I haven't enough time to backport it to jetpack version*. Last month I was (and still is) too busy with WebExtensions version. There is also no transparent iframes related fix backported too.

* Not actually backport — it's impossible to change preferences from WebExtensions version anymore. So, I have to check at runtime whether some option is activated or not. I did it for "Allow pages to overwrite my selections above" and found out that it's not needed for "Use system colors". I overwritten this option before because I think that it would prevent issues with inputs with dark desktop themes but it actually doesn't.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2017-11-16, 19:55

I'm understood, thank you. I'll have this in mind when I finally get to backport other useful features.

tor000

Re: Night Mode Addon compatible with 27+?

Unread post by tor000 » 2018-02-18, 10:12

Sometimes, when I click on the Advanced Night Mode add-on button, instead of opening the menu to allow enable night mode, it would show the following message:
Image

Code: Select all

Application Basics
------------------

Name: Pale Moon
Version: 27.7.2
Build ID: 20180130111628
Update Channel: release
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.9) Gecko/20100101 Goanna/3.4 Firefox/52.9 PaleMoon/27.7.2
OS: Windows_NT 6.1
Multiprocess Windows: 0/2 (default: false)
Safe Mode: false

Extensions
----------

Name: Advanced Night Mode
Version: 1.0.7
Enabled: true
ID: AdvancedNightMode@Off.JustOff

Name: Complete YouTube Saver
Version: 5.7.36.1
Enabled: true
ID: {AF445D67-154C-4c69-A17B-7F392BCC36A3}

Name: FavIconReloader
Version: 0.8.1-signed
Enabled: true
ID: FavIconReloader@mozilla.org

Name: IE View
Version: 1.5.6.1-signed.1-signed
Enabled: true
ID: {6e84150a-d526-41f1-a480-a67d3fed910d}

Name: NoScript
Version: 5.0.6
Enabled: true
ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: Pale Moon Commander
Version: 2.0.2
Enabled: true
ID: commander@palemoon.org

Name: Password Backup Tool
Version: 1.1.0
Enabled: true
ID: password-backup-tool@Off.JustOff

Name: Session Manager
Version: 0.8.1.13
Enabled: true
ID: {1280606b-2510-4fe0-97ef-9b5a22eafe30}

Name: uBlock Origin
Version: 1.15.6
Enabled: true
ID: uBlock0@raymondhill.net

Name: uBlock Origin Updater
Version: 1.3.0
Enabled: true
ID: ublock0-updater@Off.JustOff

Name: Download YouTube Videos as MP4
Version: 1.8.10
Enabled: false
ID: {b9bfaf1c-a63f-47cd-8b9a-29526ced9060}

Graphics
--------

Adapter Description: NVIDIA GeForce GT 220
Adapter Drivers: nvd3dum nvwgf2um,nvwgf2um
Adapter RAM: 1024
ClearType Parameters: Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50
Device ID: 0x0a20
DirectWrite Enabled: false (6.2.9200.22164)
Driver Date: 11-14-2016
Driver Version: 21.21.13.4201
GPU #2 Active: false
GPU Accelerated Windows: 2/2 Direct3D 9 (OMTC)
Subsys ID: 040110b0
Vendor ID: 0x10de
WebGL Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GT 220 Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote: true
AzureCanvasBackend: skia
AzureContentBackend: cairo
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

Important Modified Preferences
------------------------------

accessibility.browsewithcaret_shortcut.enabled: false
accessibility.typeaheadfind: true
accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.display.document_color_use: 1
browser.download.importedFromSqlite: true
browser.link.open_newwindow: 2
browser.places.smartBookmarksVersion: 4
browser.search.context.loadInBackground: false
browser.search.useDBForOrder: true
browser.sessionstore.max_tabs_undo: 99
browser.sessionstore.max_windows_undo: 99
browser.startup.homepage: google.co.il
browser.startup.homepage_override.buildID: 20180130111628
browser.startup.homepage_override.mstone: 3.4.2
browser.tabs.insertRelatedAfterCurrent: true
browser.tabs.loadInBackground: false
extensions.lastAppVersion: 27.7.2
font.internaluseonly.changed: true
font.name.serif.x-western: Arial
gfx.direct3d.last_used_feature_level_idx: 0
image.http.accept: image/webp,image/jxr,image/png,image/*;q=0.8,*/*;q=0.5
layers.prefer-d3d9: true
media.peerconnection.enabled: false
network.cookie.cookieBehavior: 1
network.cookie.lifetimePolicy: 2
network.cookie.prefsMigrated: true
network.http.speculative-parallel-limit: 0
places.database.lastMaintenance: 1518632057
places.history.enabled: false
places.history.expiration.transient_current_max_pages: 80492
plugin.importedState: true
plugin.state.flash: 1
plugin.state.java: 0
plugin.state.npauthz: 0
plugin.state.npdeployjava: 0
plugin.state.npspwrap: 0
print.printer_Canon_iP5300.print_bgcolor: false
print.printer_Canon_iP5300.print_bgimages: false
print.printer_Canon_iP5300.print_colorspace:
print.printer_Canon_iP5300.print_command:
print.printer_Canon_iP5300.print_downloadfonts: false
print.printer_Canon_iP5300.print_duplex: -437918235
print.printer_Canon_iP5300.print_edge_bottom: 0
print.printer_Canon_iP5300.print_edge_left: 0
print.printer_Canon_iP5300.print_edge_right: 0
print.printer_Canon_iP5300.print_edge_top: 0
print.printer_Canon_iP5300.print_evenpages: true
print.printer_Canon_iP5300.print_footercenter:
print.printer_Canon_iP5300.print_footerleft: &PT
print.printer_Canon_iP5300.print_footerright: &D
print.printer_Canon_iP5300.print_headercenter:
print.printer_Canon_iP5300.print_headerleft: &T
print.printer_Canon_iP5300.print_headerright: &U
print.printer_Canon_iP5300.print_in_color: true
print.printer_Canon_iP5300.print_margin_bottom: 0.5
print.printer_Canon_iP5300.print_margin_left: 0.5
print.printer_Canon_iP5300.print_margin_right: 0.5
print.printer_Canon_iP5300.print_margin_top: 0.5
print.printer_Canon_iP5300.print_oddpages: true
print.printer_Canon_iP5300.print_orientation: 0
print.printer_Canon_iP5300.print_page_delay: 50
print.printer_Canon_iP5300.print_paper_data: 9
print.printer_Canon_iP5300.print_paper_height: 11.00
print.printer_Canon_iP5300.print_paper_name:
print.printer_Canon_iP5300.print_paper_size_type: 0
print.printer_Canon_iP5300.print_paper_size_unit: 1
print.printer_Canon_iP5300.print_paper_width: 8.50
print.printer_Canon_iP5300.print_plex_name:
print.printer_Canon_iP5300.print_resolution: -437918235
print.printer_Canon_iP5300.print_resolution_name:
print.printer_Canon_iP5300.print_reversed: false
print.printer_Canon_iP5300.print_scaling: 1.00
print.printer_Canon_iP5300.print_shrink_to_fit: true
print.printer_Canon_iP5300.print_to_file: false
print.printer_Canon_iP5300.print_unwriteable_margin_bottom: 0
print.printer_Canon_iP5300.print_unwriteable_margin_left: 0
print.printer_Canon_iP5300.print_unwriteable_margin_right: 0
print.printer_Canon_iP5300.print_unwriteable_margin_top: 0
privacy.donottrackheader.enabled: true
privacy.donottrackheader.value: 1
privacy.sanitize.migrateFx3Prefs: true
privacy.sanitize.sanitizeOnShutdown: true
security.disable_button.openCertManager: false
security.OCSP.enabled: 0
security.ssl3.rsa_rc4_128_sha: true
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1516731641

Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 1

Library Versions
----------------

NSPR
Expected minimum version: 4.16
Version in use: 4.16

NSS
Expected minimum version: 3.32.1
Version in use: 3.32.1

NSSSMIME
Expected minimum version: 3.32.1
Version in use: 3.32.1

NSSSSL
Expected minimum version: 3.32.1
Version in use: 3.32.1

NSSUTIL
Expected minimum version: 3.32.1
Version in use: 3.32.1

Experimental Features
---------------------
There is no specific case that this problem happens, but it randomly happens, so I can't reproduces it
Last edited by tor000 on 2018-02-18, 10:17, edited 2 times in total.

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2018-02-18, 17:12

I'm sorry, but you are the first one to report this issue and I can hardly help you until I know the steps to reproduce the error.
Last edited by JustOff on 2018-02-18, 17:13, edited 1 time in total.

tor000

Re: Night Mode Addon compatible with 27+?

Unread post by tor000 » 2018-02-28, 10:40

Update: I've discovered that this problem usually occurs if I aggressively restarts Pale Moon by closing the it process through the Task Manager, than restart it and restores the previous session using Session Manager extension, if the process swelling considerably as a result of Youtube browsing or when Youtube videos starts to have problem (Picture flickering or getting an error message from Youtube on its player).

JustOff

Re: Night Mode Addon compatible with 27+?

Unread post by JustOff » 2018-02-28, 19:01

Unfortunately, this description does not help much either. And by the way, restarting Pale Moon by closing its process using the Task Manager is also not a good idea, as this can lead to errors in the profile and various problems that are difficult to identify and fix.

Locked