Download Flash and Video download problem

General discussion, compatibility and contributed extensions.

Moderators: FranklinDM, Lootyhoof

Cogito Ergo Sum

Re: Download Flash and Video download problem

Post by Cogito Ergo Sum » 2016-02-10, 01:53

SGvagon wrote:Nope I'm saying that Download Flash and Video download extension works everywhere, but in Palemoon 26 download not working correctly :eh: .
Ok, i like http://www.fnvfox.com/ and it sucks that it no longer works in Pale Moon.

SGvagon
Astronaut
Astronaut
Posts: 586
Joined: 2013-02-16, 13:33
Location: Czech Republic - Slavonice
Contact:

Re: Download Flash and Video download problem

Post by SGvagon » 2016-02-11, 00:18

It works when you copy URL and paste to the address bar.

Cogito Ergo Sum

Re: Download Flash and Video download problem

Post by Cogito Ergo Sum » 2016-02-11, 02:24

SGvagon wrote:It works when you copy URL and paste to the address bar.
That works for Youtube, but not for SOME other sites.
Last edited by Cogito Ergo Sum on 2016-02-15, 08:10, edited 1 time in total.

SGvagon
Astronaut
Astronaut
Posts: 586
Joined: 2013-02-16, 13:33
Location: Czech Republic - Slavonice
Contact:

Re: Download Flash and Video download problem

Post by SGvagon » 2016-02-11, 17:05

Yes it works anywhere.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-14, 20:55

jumba wrote:Version 1.68.1 adds a check using VersionInfo.isVersionBiggerOrEqual("26") and tries to use the incompatible Downloads.jsm api with Pale Moon.
Actually, in the latest version (v1,79, which still doesn't work with PM26), this value seems to be "29".

jumba

Re: Download Flash and Video download problem

Post by jumba » 2016-02-15, 07:14

Tomaso wrote: Actually, in the latest version (v1,79, which still doesn't work with PM26), this value seems to be "29".
Did the latest version work with Pale Moon 25?

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-15, 09:23

jumba wrote:Did the latest version work with Pale Moon 25?
Yes.

jumba

Re: Download Flash and Video download problem

Post by jumba » 2016-02-15, 16:34

Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-15, 16:54

jumba wrote:Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.
Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here (v1.80):
http://www.mediafire.com/download/uurn7 ... MOD%29.zip

Thanks to jumba, for pointing out the problem! :)
Last edited by Tomaso on 2016-03-24, 21:16, edited 4 times in total.

Cogito Ergo Sum

Re: Download Flash and Video download problem

Post by Cogito Ergo Sum » 2016-02-15, 20:44

Tomaso wrote:
jumba wrote:Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.
Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here:
http://www.mediafire.com/download/tcn93 ... MOD%29.zip

Thanks to jumba, for pointing out the problem! :)
Thanks, your mod works.

SGvagon
Astronaut
Astronaut
Posts: 586
Joined: 2013-02-16, 13:33
Location: Czech Republic - Slavonice
Contact:

Re: Download Flash and Video download problem

Post by SGvagon » 2016-02-20, 15:10

Tomaso wrote:
jumba wrote:Ok, I checked it and it is the same issue. There might be another version check but the one that decides between the download APIs is in overlay.js file at line number 779.
Ahh..
You're right, I found it!

I simply changed the value to "29", which fixed it!
Those of you that are interested can download the modified file here:
http://www.mediafire.com/download/tcn93 ... MOD%29.zip

Thanks to jumba, for pointing out the problem! :)
Super :) It WORKS!! Thank you :thumbup: .

dark_moon

Re: Download Flash and Video download problem

Post by dark_moon » 2016-02-20, 18:56

Maybe you should contact Tobin to upload the addon to Pale Moon addon site, if here no copyrights are violated

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-20, 23:02

dark_moon wrote:Maybe you should contact Tobin to upload the addon to Pale Moon addon site, if here no copyrights are violated
Let's wait and see if the author responds to my mail first.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-24, 17:23

Download Flash & Video v1.80 released.
Changelog:


* Fixed dailymotion.com video detection

--

I've uploaded the new modified version here:
viewtopic.php?f=46&t=10849&p=78672#p78672
As long as this simple hack works, I'll keep on updating that post, without bumping the thread.

jumba

Re: Download Flash and Video download problem

Post by jumba » 2016-02-24, 17:33

You should consider creating a fork and release it under Pale Moon's addons site.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-02-24, 17:53

jumba wrote:You should consider creating a fork and release it under Pale Moon's addons site.
Nah, this is just a brutal hack.
I've got no real understanding about programming. :)

DoctorM
Fanatic
Fanatic
Posts: 109
Joined: 2014-07-31, 18:19
Location: USA

Re: Download Flash and Video download problem

Post by DoctorM » 2016-03-04, 19:00

Edit: Thanks works fine.
I like FlashGot a bit better and it seems a similar fix works for that.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-03-24, 21:18

JFYI:

I uploaded a modified build of v1.81 earlier, but I've removed it now.

While it worked just fine with YouTube, it completely failed to detect videos on some other sites.
Don't know if this is a general bug with this version, or if it's yet another compatibility issue with Pale Moon.

For now, I've put v1.80 back up.
I'll try out our hack on future releases too of course.
If the current issue seems to have been resolved, I'll upload new mods..
If not, we'll just have to stay with v1.80. :(

SGvagon
Astronaut
Astronaut
Posts: 586
Joined: 2013-02-16, 13:33
Location: Czech Republic - Slavonice
Contact:

Re: Download Flash and Video download problem

Post by SGvagon » 2016-03-27, 23:05

Hmm, on version 1.80 youtube doesn't work anymore :( .

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1437
Joined: 2015-07-23, 16:09
Location: Norway

Re: Download Flash and Video download problem

Post by Tomaso » 2016-03-27, 23:17

SGvagon wrote:Hmm, on version 1.80 youtube doesn't work anymore :( .
The one that I modified still works just fine for me.
Try this:
1) Uninstall whatever version you're currently using ('Tools' > 'Add-ons' > 'Extensions' > 'Flash and Video Download' > 'Remove').
2) IMPORTANT: Restart Pale Moon.
3) Install the modified v1.80 build.

Locked