PMPlayer: Can we get support for Nico Nico Douga / nicovideo please? Topic is solved

[jobbautista9]

It only requires changing "www.nicovideo.jp" to "embed.nicovideo.jp". Would also be a nice workaround while nicovideo's player is still not working in Pale Moon (the embed works perfectly fine thankfully, example: https://embed.nicovideo.jp/watch/sm8628149)..

[moonbat]

Heh, didn't realize people do use this extension, seems PureURL is my most popular one so far
I'll take a look. I wanted a more ambitious plan for PMPlayer, to let users add their own link and embed detection logic but seems too complicated as of now.

[Kerebron]

didn't realize people do use this extension

I'm always watching YouTube with PMPlayer.

And I use PureURL, as well. Thank you.

[moonbat]

I've updated it, try it now

[jobbautista9]

Works perfectly, thanks very much!

[jobbautista9]

Hmm actually I'm encountering a bug when I try to open a niconico video from a search result with PMPlayer.. It often just errors out (even though it works perfectly fine when I rewrite the URL from www.nicovideo.jp to embed.nicovideo.jp with URL Rewriter), and sometimes it plays the wrong video... For example if you open PMPlayer in this embed, it will play a totally different video: https://embed.nicovideo.jp/watch/sm3970 ... 297c536e00

However opening PMPlayer in the same embed without the trailing garbage in the URL works as expected: https://embed.nicovideo.jp/watch/sm39709086

Looking at what the add-on logs to the console, it seems PMPlayer is always getting "https://embed.nicovideo.jp/watch/sm3888690" (which might be an ad that isn't embeddable) as the embedded version for some reason.

Code: Select all

[PMPlayer:]generateEmbed-matched link: https://www.nicovideo.jp/watch/sm38886905?ref=search_key_video&playlist=eyJ0eXBlIjoic2VhcmNoIiwiY29udGV4dCI6eyJrZXl3b3JkIjoiXHU3OWQ4XHU3OTVlXHUzMGRlXHUzMGJmXHUzMGZjXHUzMGU5Iiwic29ydEtleSI6ImhvdCIsInNvcnRPcmRlciI6Im5vbmUiLCJwYWdlIjoyLCJwYWdlU2l6ZSI6MzJ9fQ&ss_pos=32&ss_id=fde3a785-9456-4f23-aa16-824170926391
 frame URI=  https://embed.nicovideo.jp/watch/sm3888690
 

[jobbautista9]

I was able to workaround it with this short userscript I made for "https://www.nicovideo.jp/search/*":

Code: Select all

var links = document.getElementsByTagName("a");
for (let i = 0; i < links.length; i++) {
 if (links[i].host === location.host) {
  links[i].removeAttribute("data-href");
 }
}

It effectively removes the trailing garbage of all the video URLs in the search results (and I was never a fan of nicovideo turning the search result into a playlist anyway), and also fixes opening the embed in PMPlayer as a bonus.

Btw I didn't use Pure URL for this because there are many query parameters that are too generic (like "ref" and "playlist"), and I wanted all of the query params gone anyway, but only for nicovideo search results (Pure URL doesn't seem to have an option to limit the removal of some parameters to a specific domain or wildcard pattern).

[moonbat]

I goofed the URL regex - 7 characters instead of 8
Try now.

[jobbautista9]

Yep, that fixed it, even with my userscript disabled now. Thanks again!