GetemAll! - Fork of DownthemAll!

Add-ons for Pale Moon and other UXP Applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

deckard
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2016-12-11, 17:37
Location: New Tristram - Central Khanduras

Re: GetemAll! - Fork of DownthemAll!

Unread post by deckard » 2021-05-18, 09:16

I am looking at a version published on the Thunderbird addons page because it supports Seamonkey (even the previous one did). I am also looking at a new version because it could contain minor bugfixes. I should look at the content of the two versions and compare them and see if the the differences are still relevant and applicable to GetThemAll. But I have to admit that I am not expert enough in coding and development of a Pale Moon add-on to provide a reliable answer.
Therefore I asked since some of the minor bugs in DTA 3.0.8 could have already been fixed by moonbat, the author of GetemAll, and the other fixes might be not necessary as far as I know and can tell.
I am not able enough to say if the fixes in place are relevant to GetemAll or not.
Quis custodiet ipsos custodes? - Satires of Juvenal
Nempe ridiculum esset, custode indigere custodem - Platonis

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 3371
Joined: 2015-12-09, 15:45
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by moonbat » 2021-05-18, 12:25

different from what it was in 2016.
deckard wrote:
2021-05-18, 09:16
I am also looking at a new version because it could contain minor bugfixes.
A new version 3 years after the previous one, containing bugfixes targeted at Seamonkey. They are irrelevant to Pale Moon.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 20.1 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

deckard
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2016-12-11, 17:37
Location: New Tristram - Central Khanduras

Re: GetemAll! - Fork of DownthemAll!

Unread post by deckard » 2021-05-18, 13:12

Thanks a lot for your answer. :)
I am not able enough to be certain that fixes and improvements target just Seamonkey and therefore are irrelevant to Pale Moon, Basilisk Browser or the add-on itself.
Thank you for your effort. :thumbup:
Quis custodiet ipsos custodes? - Satires of Juvenal
Nempe ridiculum esset, custode indigere custodem - Platonis

patrick-g
Newbie
Newbie
Posts: 4
Joined: 2020-12-23, 10:49

Re: GetemAll! - Fork of DownthemAll!

Unread post by patrick-g » 2021-05-18, 19:40

moonbat wrote:
2021-05-18, 12:25
A new version 3 years after the previous one, containing bugfixes targeted at Seamonkey. They are irrelevant to Pale Moon.
Hi,
Looking at the git log of the official DTA-legacy repo, it seems that most of bug fixes / improvements are targeting all XUL app.
All commits were done within a period of 11 months after the 3.08 release.
I don't know if the 3.0.9 version in Thunderbird add-on page is related to these Github commits.

Regards.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 10226
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: GetemAll! - Fork of DownthemAll!

Unread post by New Tobin Paradigm » 2021-05-18, 19:45

I'm sorry, my responses are limited. You must ask the right questions.
Image

patrick-g
Newbie
Newbie
Posts: 4
Joined: 2020-12-23, 10:49

Re: GetemAll! - Fork of DownthemAll!

Unread post by patrick-g » 2021-05-19, 11:08

Hi,

You're right.
I missed the branch dta-3-0 and used the master branch.
But I just quickly check and it appears that all commits done on branch dta-3-0 for version 3.0.9 are backported from master branch.
Except the version bump and the compatibility in the .rdf file, of course.
So now, we know that version 3.0.9 is actually a small part of version 3.1.0pre which is on master.
And that the 3 years difference between 3.0.8 and 3.0.9 versions is just an appearance.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 10226
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: GetemAll! - Fork of DownthemAll!

Unread post by New Tobin Paradigm » 2021-05-19, 16:23

There may be a few goodies in the diff but it seems mostly l10n and es6+ refactoring likely with multiprocess prereqs. Nothing critical I have seen.
I'm sorry, my responses are limited. You must ask the right questions.
Image

deckard
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2016-12-11, 17:37
Location: New Tristram - Central Khanduras

Re: GetemAll! - Fork of DownthemAll!

Unread post by deckard » 2021-05-20, 14:38

Thanks everybody for your effort. ;)
Quis custodiet ipsos custodes? - Satires of Juvenal
Nempe ridiculum esset, custode indigere custodem - Platonis

User avatar
NicolasBahamondes
New to the forum
New to the forum
Posts: 1
Joined: 2021-05-20, 15:51

Covalent Backport for GetEmAll

Unread post by NicolasBahamondes » 2021-05-22, 00:11

Hi everybody,

I am interested on designing a new toolbar iconset for GetEmAll! and this is the result, it's a backport of a previous skin I did for MPC-HC.
Hope you like it :)

https://sta.sh/02cmzm341xv7
Attachments
Preview
Preview

User avatar
RealityRipple
Lunatic
Lunatic
Posts: 389
Joined: 2018-05-17, 02:34
Location: Los Berros Canyon, California
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by RealityRipple » 2021-06-16, 00:06

Made an alternate fork for this: DownItAll. No compiled release available at this time.

Changes:
- All separate preference names (no seamless upgrade)
- No "aero" download window styling (it looked awful with dark themes - white glowy text on a light glass background)
- No toolbars in download window
- Download/Pause buttons as first column
- Rows are now 32px high
- Downloaded and Remaining columns
- Add Download button shows up as an empty, unselectable last row's first cell
- Download properties dialog's disabled element's forced color styling disabled (letting the browser theme handle disabled dropdowns and textboxes)
- Auto-populate Custom Filename entry of Add Download dialog based on current URL (or redirection URL if clicked link redirects to a second URL [which the extension reverts to the initial URL in the download process] if the current URL has no file extension)
- Added file extension appending to Custom Filename if URL has a file extension but the entered Custom Filename is lacking a period.
- Disable context menu items when they don't make sense, like "Pause" while paused, "Cancel" while complete, or "Remove Completed Downloads" when no downloads are completed
- No about webpage on update
- Total percent of multiple downloads in downloads window titlebar now reflects the downloaded and total file sizes instead of just numbers of downloads

Image

Image

Right now there's a bug with drag and drop due to the new "fake" last row where you can't drag a download to the very bottom. Should be resolved soon.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 10226
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: GetemAll! - Fork of DownthemAll!

Unread post by New Tobin Paradigm » 2021-06-16, 00:25

Why do we need multiple forks of this extension? Also, that is TERRIBLE branding and is far too close to the original.
I'm sorry, my responses are limited. You must ask the right questions.
Image

User avatar
RealityRipple
Lunatic
Lunatic
Posts: 389
Joined: 2018-05-17, 02:34
Location: Los Berros Canyon, California
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by RealityRipple » 2021-06-16, 00:33

New Tobin Paradigm wrote:
2021-06-16, 00:25
Why do we need multiple forks of this extension? Also, that is TERRIBLE branding and is far too close to the original.
I'm probably never going to release it as a built extension, I just really didn't like the UI of the original. Also, it was too close to "Damn it all" for me not to use it as an alternate name.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 10226
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: GetemAll! - Fork of DownthemAll!

Unread post by New Tobin Paradigm » 2021-06-16, 00:39

The initial goal for moonbat was to get a replacement made.. I am sure he has further enhancements down the line.
I'm sorry, my responses are limited. You must ask the right questions.
Image

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 3371
Joined: 2015-12-09, 15:45
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by moonbat » 2021-06-21, 12:31

Most of what I've seen of it is way above my paygrade at extension development. One of the things I got rid of was the Paypal donate link and a nag function that kicks in after a certain number of downloads, but otherwise I haven't really looked at it for improvements.
@RealityRipple - if you could submit patches or do a pull request or the equivalent for Gitlab - I'll be glad to integrate them and have you as a contributor.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 20.1 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

User avatar
RealityRipple
Lunatic
Lunatic
Posts: 389
Joined: 2018-05-17, 02:34
Location: Los Berros Canyon, California
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by RealityRipple » 2021-06-21, 15:17

moonbat wrote:
2021-06-21, 12:31
@RealityRipple - if you could submit patches or do a pull request or the equivalent for Gitlab - I'll be glad to integrate them and have you as a contributor.
Your repo has forking disabled.

User avatar
moonbat
Knows the dark side
Knows the dark side
Posts: 3371
Joined: 2015-12-09, 15:45
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by moonbat » 2021-06-21, 15:31

Ah, fixed. Try now?
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 20.1 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
AutoPageColor|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

User avatar
RealityRipple
Lunatic
Lunatic
Posts: 389
Joined: 2018-05-17, 02:34
Location: Los Berros Canyon, California
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by RealityRipple » 2021-06-21, 17:32

Alright, I copied over all the changes that didn't involve renaming the extension or changing the directory tree. I still need to fix the drag-to-bottom issue introduced by the final "Add" row, and then I'll try to make a few different pull requests out of my changes.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2761
Joined: 2015-09-26, 04:51
Location: U.S.

Re: GetemAll! - Fork of DownthemAll!

Unread post by coffeebreak » 2021-06-21, 18:23

moonbat wrote:
2021-06-21, 12:31
if you could submit patches or do a pull request or the equivalent for Gitlab - I'll be glad to integrate them and have you as a contributor.
RealityRipple wrote:
2021-06-21, 17:32
I'll try to make a few different pull requests out of my changes.
Is it possible to make the UI changes merely optional for the user versus carved in stone ?

I just tried out the RealityRipple alt-fork and have to admit that I vastly prefer the current, non-alt version.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 10226
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: GetemAll! - Fork of DownthemAll!

Unread post by New Tobin Paradigm » 2021-06-21, 19:24

I can't argue there.. it is pretty terrible.
I'm sorry, my responses are limited. You must ask the right questions.
Image

User avatar
RealityRipple
Lunatic
Lunatic
Posts: 389
Joined: 2018-05-17, 02:34
Location: Los Berros Canyon, California
Contact:

Re: GetemAll! - Fork of DownthemAll!

Unread post by RealityRipple » 2021-06-21, 20:29

Yeah, no, I didn't plan to include the UI changes in the pulls. That was strictly for me.

Post Reply