Bookmarksviewer fork of MyBookmarks

General discussion, compatibility and contributed extensions.

Moderators: Lootyhoof, FranklinDM

Post Reply
User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-07, 13:14

Hi!
I forked another addon: MyBookmarks
I have renamed it in Bookmarksviewer and add in Palemoon repo in waiting...
Addon works and if someone to check if i wrong something.
This is my second fork addon then i am not expert especially on licensing :)
Bye
Francesco bat

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 9284
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: Bookmarksviewer fork of MyBookmarks

Post by New Tobin Paradigm » 2021-04-07, 13:33

Dude, you need to slow down and do things properly as to not create a bunch of work for me and the Add-ons Team.

Cleaning up your mistakes requires manual action on my part. You should, especially when new to this, allow others to test and let you know about pre-submission issues. Also, you should do nothing until you have an understanding of what you are allowed to do under a software license.

It should be obvious that you should not be doing drive-by forks. You are commiting to long term care of these extensions.
You know I have the greatest enthusiasm possible for the mission.
Image

User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-07, 13:47

Thank you for answer.
This is only extension i use with Select Like A Boss from age Firefox.
Forked Select Like A Boss, I could give up this, but doing the first addon, i made also the second.
Now i am not going to make others adoons.
I don't know if Custom Buttons work again (i have a neutral version).
Maybe in future something else :)
Bye
Francesco bat

User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-07, 15:12

In reference like said in this link: viewtopic.php?f=46&t=26540
now i post install.rdf edited.
If it's ok, i upload also it:

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" 
 xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:id>bookmarksviewer@francescoinblack</em:id>
    <em:type>2</em:type>
    <em:unpack>false</em:unpack>
    <em:name>BookmarksViewer</em:name>
    <em:version>202104.1.0</em:version>
    <em:iconURL>chrome://bookmarksviewer/skin/icon.png</em:iconURL>
    <em:optionsURL>chrome://bookmarksviewer/content/options.xul</em:optionsURL>
    <em:creator>francescoinblack</em:creator>
	<em:contributor>ma2ten</em:contributor>
	<em:description>Creates a formatted page from bookmarks.</em:description>
    <em:localized>
      <Description>
        <em:locale>en-US</em:locale>
        <em:creator>francescoinblack</em:creator>
	<em:contributor>ma2ten</em:contributor>
        <em:name>BookmarksViewer</em:name>
        <em:description>Creates a formatted page from bookmarks.</em:description>        
      </Description>
    </em:localized>
    
    <em:targetApplication>
      <Description>
	      <em:id>{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}</em:id>
        <em:minVersion>29.0</em:minVersion>
        <em:maxVersion>30.*</em:maxVersion>
      </Description>
    </em:targetApplication>
  </Description>
</RDF>
Bye :)
Francesco bat

User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-08, 16:16

I edited install.rdf following the style of:
viewtopic.php?f=46&t=26540&start=20#p212475
and now it's:

Code: Select all

<?xml version="1.0"?>

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:em="http://www.mozilla.org/2004/em-rdf#">
	
	<Description about="urn:mozilla:install-manifest"
		     em:type="2"
		     em:unpack="false"
		     em:id="bookmarksviewer@francescoinblack"
		     em:version="1.0"
		     em:iconURL="chrome://bookmarksviewer/skin/icon.png"
		     em:optionsURL="chrome://bookmarksviewer/content/options.xul"
		     em:name="BookmarksViewer"
		     em:description="Creates a formatted page from bookmarks."
		     em:creator="Francescoinblack">
		     <em:contributor>ma2ten</em:contributor>
		     <em:localized>
		<Description>
        <em:locale>en-US</em:locale>
        <em:creator>francescoinblack</em:creator>
	<em:contributor>ma2ten</em:contributor>
        <em:name>BookmarksViewer</em:name>
        <em:description>Creates a formatted page from bookmarks.</em:description>        
      </Description>
    </em:localized>
		<em:targetApplication name="Pale Moon">
			<Description em:id="{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}"
				     em:minVersion="29.0.0a1"
				     em:maxVersion="29.*"/>
		</em:targetApplication>
		<em:targetApplication name="Basilisk">
			<Description em:id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
				     em:minVersion="52.9"
				     em:maxVersion="52.*"/>
		</em:targetApplication>
	</Description>
</RDF>
It works in Palemoon and Basilisk.
If it is all right i upload also it. ;)
Bye
Francesco bat

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 9284
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: Bookmarksviewer fork of MyBookmarks

Post by New Tobin Paradigm » 2021-04-08, 20:12

It makes no sense to have an en-US localized block of redundant metadata.
You know I have the greatest enthusiasm possible for the mission.
Image

User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-08, 21:28

I also wanted to leave localization in Japanese (like the original), but I had to change the title and description that were written in Japanese and I didn’t know how to translate it (I don’t always trust automatic translators especially if I have to do it from Italian to Japanese).
In the extension there is a subfolder with name "locale" and i removed japanese and i leaved english and inside there are:

- mybookmarks.dtd
- mybookmarks.properties

I saw they are called in some configurations of the addon and i didn't know if i can to delete the localization from install.rdf and it continue to work also in japanese. :think:

User avatar
moonbat
Moon Magic practitioner
Moon Magic practitioner
Posts: 2933
Joined: 2015-12-09, 15:45
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by moonbat » 2021-04-09, 01:18

The localization sections in install.rdf are only meant for displaying the addon metadata in that language for people who have that language pack turned on. So the Japanese section will make sense if someone is running Pale Moon with the Japanese language pack on an OS with the language set to Japanese.
"One hosts to look them up, one DNS to find them and in the darkness BIND them."

Image
Linux Mint 20.1 Xfce x64 on HP i5-5200 laptop, 12 GB RAM.
Advanced URL Builder(fork)|PermissionsPlus|PMPlayer|Pure URL|RecordRewind|TextFX

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 9284
Joined: 2012-10-09, 19:37
Location: Seriphia Galaxy

Re: Bookmarksviewer fork of MyBookmarks

Post by New Tobin Paradigm » 2021-04-09, 02:07

I wouldn't keep anything outside en-US unless you know the language or have translaters lined up.
You know I have the greatest enthusiasm possible for the mission.
Image

User avatar
francesco bat
Moon lover
Moon lover
Posts: 87
Joined: 2017-03-13, 00:11
Contact:

Re: Bookmarksviewer fork of MyBookmarks

Post by francesco bat » 2021-04-09, 11:31

Ok !
I edited it and it works :thumbup:

Code: Select all

<?xml version="1.0"?>

<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:em="http://www.mozilla.org/2004/em-rdf#">
	
	<Description about="urn:mozilla:install-manifest"
		     em:type="2"
		     em:unpack="false"
		     em:id="bookmarksviewer@francescoinblack"
		     em:version="1.0"
		     em:iconURL="chrome://bookmarksviewer/skin/icon.png"
		     em:optionsURL="chrome://bookmarksviewer/content/options.xul"
		     em:name="BookmarksViewer"
		     em:description="Creates a formatted page from bookmarks."
		     em:creator="Francescoinblack">
		     <em:contributor>ma2ten</em:contributor>
		     <em:targetApplication name="Pale Moon">
			<Description em:id="{8de7fcbb-c55c-4fbe-bfc5-fc555c87dbc4}"
				     em:minVersion="29.0.0a1"
				     em:maxVersion="29.*"/>
		</em:targetApplication>
		<em:targetApplication name="Basilisk">
			<Description em:id="{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"
				     em:minVersion="52.9"
				     em:maxVersion="52.*"/>
		</em:targetApplication>
	</Description>
</RDF>
If it's all right i upload it :)
Bye
Francesco bat

Post Reply