Redirector addon: stopped working since v28

General discussion, compatibility and contributed extensions.

Moderators: FranklinDM, Lootyhoof

User avatar
ketmar
Lunatic
Lunatic
Posts: 362
Joined: 2015-07-28, 11:10
Location: Earth

Re: Redirector addon: stopped working since v28

Post by ketmar » 2019-12-11, 05:11

this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.

TMINY
Apollo supporter
Apollo supporter
Posts: 46
Joined: 2016-02-02, 04:58

Re: Redirector addon: stopped working since v28

Post by TMINY » 2019-12-11, 15:38

ketmar wrote:
2019-12-11, 05:11
this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
This works! Thank you so much!

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 6924
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Redirector addon: stopped working since v28

Post by New Tobin Paradigm » 2019-12-11, 15:49

Why isn't anyone forking this extension properly?
Image
- This program cannot be run in DOS mode. -
https://binaryoutcast.com/ | Freenode #binaryoutcast | http://thereisonlyxul.org/

User avatar
Baloo
Apollo supporter
Apollo supporter
Posts: 41
Joined: 2017-08-24, 15:02

Re: Redirector addon: stopped working since v28

Post by Baloo » 2019-12-19, 05:14

ketmar wrote:
2019-12-11, 05:11
this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Thank you so much! This is very much appreciated. Now someone just needs to make it an official fork!
Image Image

IMNdi
Newbie
Newbie
Posts: 5
Joined: 2017-07-12, 16:56

Re: Redirector addon: stopped working since v28

Post by IMNdi » 2020-01-17, 16:43

doofy wrote:
2019-12-05, 13:02
TMINY wrote:
2019-12-05, 12:53
This was working great until recently. Redirects aren't working... I noticed the preferences screen is empty of my rules and the buttons are non-responsive.
Anyone have any ideas on a fix? Thanks!
redirector_fixed is working here.
My only redirect works, as do buttons.
Mine's broken all right. When opening the addon setting page the console produces this:

Error: TypeError: this.unwatch is not a function
Source File: chrome://redirector/content/js/redirectorprefs.js
Line: 25

Buttons don't do anything.

TMINY
Apollo supporter
Apollo supporter
Posts: 46
Joined: 2016-02-02, 04:58

Re: Redirector addon: stopped working since v28

Post by TMINY » 2020-01-17, 17:05

IMNdi wrote:
2020-01-17, 16:43

Mine's broken all right. When opening the addon setting page the console produces this:

Error: TypeError: this.unwatch is not a function
Source File: chrome://redirector/content/js/redirectorprefs.js
Line: 25

Buttons don't do anything.
Have a look at ketmar's fix up above. That got mine working.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26136
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Redirector addon: stopped working since v28

Post by Moonchild » 2020-01-17, 18:47

I'd like to make a point here that watch() and unwatch() have never been part of any ECMAScript version, contrary to what Ketmar has said.
They have been internal Firefox-only functions that, unfortunately, extension devs have been using regardless.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
ketmar
Lunatic
Lunatic
Posts: 362
Joined: 2015-07-28, 11:10
Location: Earth

Re: Redirector addon: stopped working since v28

Post by ketmar » 2020-01-18, 04:03

yeah, i meant "in new Pale Moon js engine versions", but got it wrongly worded. sure, those calls are not in any official ES specification, and Pale Moon is not dropping something that was standardized. sorry.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26136
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Redirector addon: stopped working since v28

Post by Moonchild » 2020-01-18, 13:31

ketmar wrote:
2020-01-18, 04:03
yeah, i meant "in new Pale Moon js engine versions", but got it wrongly worded. sure, those calls are not in any official ES specification, and Pale Moon is not dropping something that was standardized. sorry.
It's an easy mistake to make, no worries -- just wanted to clarify the situation.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

IMNdi
Newbie
Newbie
Posts: 5
Joined: 2017-07-12, 16:56

Re: Redirector addon: stopped working since v28

Post by IMNdi » 2020-01-23, 17:30

TMINY wrote:
2020-01-17, 17:05
Have a look at ketmar's fix up above. That got mine working.
Oh sorry, I read the thread wrong I thought that's what the fix does.
Thanks for the heads up, fortunately the website that needed correction was fixed server-side so I am abandoning for now.

User avatar
JohnAJ
New to the forum
New to the forum
Posts: 1
Joined: 2020-02-04, 09:52

Re: Redirector addon: stopped working since v28

Post by JohnAJ » 2020-02-04, 10:01

Lew Rockwell Fan wrote:
2018-10-04, 06:53
Thanks. I had given up on this. therube was kind enough to point this thread out to me at the end of my older one. Here is a corrected xpi for anybody who'd rather not do it themselves:redirector_fixed.xpi
ketmar wrote:
2019-12-11, 05:11
this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Here's an updated xpi for those who prefer to just download a ready-made file

Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.
Last edited by FranklinDM on 2020-02-04, 10:31, edited 1 time in total.
Reason: Removed attached extension.

User avatar
Andrew Herbert
Moon lover
Moon lover
Posts: 79
Joined: 2019-11-25, 21:46

Re: Redirector addon: stopped working since v28

Post by Andrew Herbert » 2020-02-04, 21:53

Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.
Why? The other modified extension was allowed.

Lew Rockwell Fan
Fanatic
Fanatic
Posts: 190
Joined: 2017-06-14, 15:20

Re: Redirector addon: stopped working since v28

Post by Lew Rockwell Fan » 2020-02-06, 23:45

If somebody is going to work on this, may I make a suggestion (actually a shameless begging plea) to add an option to automatically send the regex matching url to an external program instead of opening an alternate url? There are probably a fair number of us who haven't managed to get a grip on xml and such but can still do some neat tricks with bash if the browser will just throw us a string.

I can do it with "Open With" but not automatically - I have to both know (and sometimes urls are hidden to casual view) and notice (which is a different matter) that the url is of a class I'd like to treat differently.

Thanks either way.
"To attempt to silence a man is to pay him homage, for it is an acknowledgement that his arguments are both impossible to answer and impossible to ignore." - John Bryant

User avatar
Andrew Herbert
Moon lover
Moon lover
Posts: 79
Joined: 2019-11-25, 21:46

Re: Redirector addon: stopped working since v28

Post by Andrew Herbert » 2020-03-21, 13:45

What about the versions 3.0.4 and 3.0.6? The error console doesn't show anything.

User avatar
Andrew Herbert
Moon lover
Moon lover
Posts: 79
Joined: 2019-11-25, 21:46

Re: Redirector addon: stopped working since v28

Post by Andrew Herbert » 2020-03-26, 16:21

The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 26136
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: Redirector addon: stopped working since v28

Post by Moonchild » 2020-03-26, 16:25

Andrew Herbert wrote:
2020-03-26, 16:21
The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?
Because Pale Moon and Basilisk are not Firefox.
Please get this through your thick skull. Thank you.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

User avatar
letmeindude
Moonbather
Moonbather
Posts: 59
Joined: 2018-10-09, 08:56

Re: Redirector addon: stopped working since v28

Post by letmeindude » 2020-03-26, 16:56

Andrew Herbert wrote:
2020-03-26, 16:21
The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?
Version 3.0.6 removed local copy of ExtensionStorage.jsm, because it ships with FF 44 and newer. Pale Moon is not Firefox.

Just copy ExtensionStorage.jsm from 3.0.4 maybe it will work.

User avatar
New Tobin Paradigm
Off-Topic Sheriff
Off-Topic Sheriff
Posts: 6924
Joined: 2012-10-09, 19:37
Location: Sector 001

Re: Redirector addon: stopped working since v28

Post by New Tobin Paradigm » 2020-03-26, 19:05

We could bring that jsm back.. While it landed as part of the initial WebExtensions bullshit it actually isn't dependent WebEx it but WebEx was dependent on it.

We will consider it. No promises.

EDIT: https://github.com/MoonchildProductions/UXP/commit/5e03c9ad4cf63c3f15e19a0dd0d1ea5b8f9abed2
Image
- This program cannot be run in DOS mode. -
https://binaryoutcast.com/ | Freenode #binaryoutcast | http://thereisonlyxul.org/

Post Reply