Redirector addon: stopped working since v28
Moderators: FranklinDM, Lootyhoof
Re: Redirector addon: stopped working since v28
this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Re: Redirector addon: stopped working since v28
This works! Thank you so much!ketmar wrote: ↑2019-12-11, 05:11this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Re: Redirector addon: stopped working since v28
Why isn't anyone forking this extension properly?
Re: Redirector addon: stopped working since v28
Thank you so much! This is very much appreciated. Now someone just needs to make it an official fork!ketmar wrote: ↑2019-12-11, 05:11this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Re: Redirector addon: stopped working since v28
Mine's broken all right. When opening the addon setting page the console produces this:
Error: TypeError: this.unwatch is not a function
Source File: chrome://redirector/content/js/redirectorprefs.js
Line: 25
Buttons don't do anything.
Re: Redirector addon: stopped working since v28
Have a look at ketmar's fix up above. That got mine working.
Re: Redirector addon: stopped working since v28
I'd like to make a point here that watch() and unwatch() have never been part of any ECMAScript version, contrary to what Ketmar has said.
They have been internal Firefox-only functions that, unfortunately, extension devs have been using regardless.
They have been internal Firefox-only functions that, unfortunately, extension devs have been using regardless.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: Redirector addon: stopped working since v28
yeah, i meant "in new Pale Moon js engine versions", but got it wrongly worded. sure, those calls are not in any official ES specification, and Pale Moon is not dropping something that was standardized. sorry.
Re: Redirector addon: stopped working since v28
It's an easy mistake to make, no worries -- just wanted to clarify the situation.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: Redirector addon: stopped working since v28
Lew Rockwell Fan wrote: ↑2018-10-04, 06:53Thanks. I had given up on this. therube was kind enough to point this thread out to me at the end of my older one. Here is a corrected xpi for anybody who'd rather not do it themselves:redirector_fixed.xpi
Here's an updated xpi for those who prefer to just download a ready-made fileketmar wrote: ↑2019-12-11, 05:11this is quite easy again, you only have to copypaste object-watch polyfill at the top of the "chrome/js/redirectorprefs.js" file, right under the "var EXPORTED_SYMBOLS = ['RedirectorPrefs'];" line. `watch()` and `unwatch()` Object properties has been deprecated and removed in new EcmaScript versions.
Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.
Last edited by FranklinDM on 2020-02-04, 10:31, edited 1 time in total.
Reason: Removed attached extension.
Reason: Removed attached extension.
Re: Redirector addon: stopped working since v28
Why? The other modified extension was allowed.Moderator note: edited extension removed. Please follow proper procedure to publish modified extensions.
Re: Redirector addon: stopped working since v28
If somebody is going to work on this, may I make a suggestion (actually a shameless begging plea) to add an option to automatically send the regex matching url to an external program instead of opening an alternate url? There are probably a fair number of us who haven't managed to get a grip on xml and such but can still do some neat tricks with bash if the browser will just throw us a string.
I can do it with "Open With" but not automatically - I have to both know (and sometimes urls are hidden to casual view) and notice (which is a different matter) that the url is of a class I'd like to treat differently.
Thanks either way.
I can do it with "Open With" but not automatically - I have to both know (and sometimes urls are hidden to casual view) and notice (which is a different matter) that the url is of a class I'd like to treat differently.
Thanks either way.
Re: Redirector addon: stopped working since v28
What about the versions 3.0.4 and 3.0.6? The error console doesn't show anything.
Re: Redirector addon: stopped working since v28
The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?
Re: Redirector addon: stopped working since v28
Because Pale Moon and Basilisk are not Firefox.Andrew Herbert wrote: ↑2020-03-26, 16:21The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?
Please get this through your thick skull. Thank you.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Re: Redirector addon: stopped working since v28
Version 3.0.6 removed local copy of ExtensionStorage.jsm, because it ships with FF 44 and newer. Pale Moon is not Firefox.Andrew Herbert wrote: ↑2020-03-26, 16:21The version 3.0.6 requires the file resource://gre/modules/ExtensionStorage.jsm, which doesn't exist on Pale Moon or Basilisk. Why?
Just copy ExtensionStorage.jsm from 3.0.4 maybe it will work.
Re: Redirector addon: stopped working since v28
We could bring that jsm back.. While it landed as part of the initial WebExtensions bullshit it actually isn't dependent WebEx it but WebEx was dependent on it.
We will consider it. No promises.
EDIT: https://github.com/MoonchildProductions/UXP/commit/5e03c9ad4cf63c3f15e19a0dd0d1ea5b8f9abed2
We will consider it. No promises.
EDIT: https://github.com/MoonchildProductions/UXP/commit/5e03c9ad4cf63c3f15e19a0dd0d1ea5b8f9abed2
Re: Redirector addon: stopped working since v28
It seems that even with bringing that jsm back, Redirector 3.0.6 does not function. Installs, but won't save or activate any created redirects. Looks like this add-on just needs a old-fashioned fork...
Re: Redirector addon: stopped working since v28
Well we tried. And it would also allow other extensions using the (otherwise stand-alone) module to work.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite