Multiple Tab Handler seems to work on 28 with small patch, needs forking/review?

Add-ons for Pale Moon and other applications
General discussion, compatibility, contributed extensions, themes, plugins, and more.

Moderators: FranklinDM, Lootyhoof

Stilez

Multiple Tab Handler seems to work on 28 with small patch, needs forking/review?

Unread post by Stilez » 2018-07-21, 10:28

After some initial panic about Multiple Tab Handler not working on PM, and no specific answer related to 27.x, I just wanted to confirm that it *DOES* work with 28.0.0.b4, PROVIDED three patches are made to it:

1) The two patches here and here, described in this thread.

2) The compatibility patch for Pale Moon, described in this StackExchange thread (obviously with maxVersion 28.* not 25.*) and on this website, to handle the Pale Moon GUID+versioning.

Could someone check it works, and if so, fork and patch this for PM, and maybe see if there's a later version that can be made to work. Worth noting: this post, which suggests that versions up to Version 0.8.2017061501 (last version before WebExtensions) could *probably* be made compatible.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Multiple Tab Handler seems to work on 28 with small patch, needs forking/review?

Unread post by Moonchild » 2018-07-21, 12:44

A quick check shows the extension is licensed under the MPL/GPL/LGPL tri-license, so forking is indeed allowed (either under the same license, under the GPL or LGPL, or under the MPL (recommended to use MPL 2.0 in that case)).
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Stilez

Re: Multiple Tab Handler seems to work on 28 with small patch, needs forking/review?

Unread post by Stilez » 2018-07-22, 02:41

Moonchild wrote:A quick check shows the extension is licensed under the MPL/GPL/LGPL tri-license, so forking is indeed allowed (either under the same license, under the GPL or LGPL, or under the MPL (recommended to use MPL 2.0 in that case)).
What I'm asking is more, would someone nice be willing to be enticed to host a forked version, and keep an eye on it for compatibility fixes going forward, since none of the current versions from AMO including the recommnded version, actually work without patching :)

Also whether a simple patch might fix the later pre-webextensions version :)
Last edited by Stilez on 2018-07-22, 02:41, edited 1 time in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Multiple Tab Handler seems to work on 28 with small patch, needs forking/review?

Unread post by Moonchild » 2018-07-22, 15:33

I understand what you were saying - all I did was make sure modifications are allowed by others.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked