[Release] Various theme ports/forks

Anything about browser themes, both Full Themes and Lightweight Themes (personas) should go here.

Moderators: Indalecio, satrow, Lootyhoof, Andrew Gilbertson

User avatar
Nintendo Maniac 64
Fanatic
Fanatic
Posts: 231
Joined: Thu Oct 17, 2013 5:29 am
Location: Northeast Ohio

Re: [Release] Various theme ports/forks

Postby Nintendo Maniac 64 » Sun Sep 10, 2017 8:37 pm

Lootyhoof wrote:
Nintendo Maniac 64 wrote:...yeah I'm not really much of a believer in "OS integration" since most people don't choose a specific OS due to its GUI aesthetic

You would be surprised how many people would argue against that. ;).


Maybe I should have said "most people don't choose a specific OS primarily due to its GUI aesthetic", and I'd like to put emphasis on the fact that I do in fact mean "aesthetic" and not "how the GUI is arranged".

An example would be the people that stayed with Windows 7 over Windows 8 - they did that not because of Windows 7's aesthetic, but rather because of "how the GUI is arranged".

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Fri Sep 22, 2017 8:55 am

Loftyhoof:
What happened with Moonfox3? The hover icons now have a washed-out look, eg.:

Before:
before.png
before.png (7.35 KiB) Viewed 218 times

Now:
now.png
now.png (7.57 KiB) Viewed 218 times


There's even a washed-out hover icon for my Zing! Locale Switcher button, for some reason. I don't mind necessary underlying structural changes to themes but changing the look and feel like this is totally unnecessary and I think it should be restored to how it was before.

You also seem to have removed the "List all tabs" icon. Could you please restore it?

I have to say the lack of quality control for this release (2.0.0) is really disappointing. Maybe you should get some people to test new releases before making them public.

User avatar
Lootyhoof
Themeist
Themeist
Posts: 852
Joined: Thu Feb 09, 2012 11:35 pm
Location: United Kingdom

Re: [Release] Various theme ports/forks

Postby Lootyhoof » Fri Sep 22, 2017 7:57 pm

jez9999 wrote:What happened with Moonfox3? The hover icons now have a washed-out look, eg.:

There's even a washed-out hover icon for my Zing! Locale Switcher button, for some reason. I don't mind necessary underlying structural changes to themes but changing the look and feel like this is totally unnecessary and I think it should be restored to how it was before.

You also seem to have removed the "List all tabs" icon. Could you please restore it?

I have to say the lack of quality control for this release (2.0.0) is really disappointing. Maybe you should get some people to test new releases before making them public.

Thanks for the report. I've fixed this in the source on GitHub and will push a release soon.

I normally don't do betas and test releases (typically because there simply isn't the turnout; I rarely get bug reports for release versions, even), however in this case I'll leave one below. :) Let me know how it is - If all's good I'll push the same to Aeromoon, too.
Attachments
moonfox3-2-0-1b1-pm.xpi
(1.02 MiB) Downloaded 5 times

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Sat Sep 23, 2017 2:18 am

Loftyhoof:

3 things:

there *isn't* a dropdown button to the right of the back/forward buttons that was there before, the tabs look slightly different (more shadow at the top) which looks worse, and when the window is maximized in Windows, for some reason the bevel at the bottom of the window is a bit thicker than before, which looks worse.

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Sat Sep 23, 2017 2:37 am

Loftyhoof:

Also just looking at your code, I don't really like this kind of approach:

Code: Select all

.toolbarbutton-1:not([disabled="true"]):not([badge]):hover:active .toolbarbutton-icon {
  filter: brightness(95%);
}


You're using pure CSS to modify the icons on hover. While this may simplify things, it gets rid of the fundamental principle that an extension developer can change their icon on mouseover to whatever they want. Your CSS should not be touching the icons of any buttons that are not built in to the theme.

User avatar
Lootyhoof
Themeist
Themeist
Posts: 852
Joined: Thu Feb 09, 2012 11:35 pm
Location: United Kingdom

Re: [Release] Various theme ports/forks

Postby Lootyhoof » Sat Sep 23, 2017 4:04 pm

Thanks for the feedback. I do appreciate the constructive criticism - I certainly don't get enough of it generally. I've attached another beta below - please check it out.

jez9999 wrote:You're using pure CSS to modify the icons on hover. While this may simplify things, it gets rid of the fundamental principle that an extension developer can change their icon on mouseover to whatever they want. Your CSS should not be touching the icons of any buttons that are not built in to the theme.

Admittedly I was a bit too presumptuous with this one, as I was hoping to style buttons not native to the theme in the same way as native buttons. I'm still keeping this use of CSS filters though, but only applying it to the native buttons, as I don't feel there's a need to have separate images for each button state when the same thing can be applied using filters now. Back in the Firefox 3 days, sure, but not now.

As for your other concerns:

jez9999 wrote:there *isn't* a dropdown button to the right of the back/forward buttons that was there before

Can't confirm..?

Image

jez9999 wrote:the tabs look slightly different (more shadow at the top) which looks worse

They look the same as Firefox 3's tabs, unless you can point out anything to the contrary.

Image

jez9999 wrote:when the window is maximized in Windows, for some reason the bevel at the bottom of the window is a bit thicker than before

Where..? The below are from Windows 10, but I also checked on Windows 7 too and saw no issues like this.

Image
Image
Image

With regards to other things fixed in this version:
Nintendo Maniac 64 wrote:...yeah I'm not really much of a believer in "OS integration" since most people don't choose a specific OS due to its GUI aesthetic, and I'd much rather have a program have the same UI regardless of platform for familiarity sake (VLC is a good example of this).

Then again, I'm the same person that has been using the Windows "high contrast black" theme for possibly over a decade now and have even used it across Windows versions (at least XP and 7), so I'm used to having programs not match my OS theme.

(there's also the fact that I do a lot with emulation, so I'm extremely used to running software that was originally designed for a completely different hardware platform let alone a different OS)

Please give the beta I've attached a go - I've had a thought about this and come to a compromise with this. I've changed the appmenu again, more like the original, but not exactly. It feels a lot better (in my opinion) - though please let me know if it's not what you were thinking.

"Normal" mode (not maximised):
Image

Maximised mode:
Image
Attachments
moonfox3-2-0-1b2-pm.xpi
(1.02 MiB) Downloaded 2 times

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Sat Sep 23, 2017 7:18 pm

Lootyhoof wrote:
jez9999 wrote:there *isn't* a dropdown button to the right of the back/forward buttons that was there before

Can't confirm..?

Image

Try it in "icons and text" mode.

jez9999 wrote:the tabs look slightly different (more shadow at the top) which looks worse

They look the same as Firefox 3's tabs, unless you can point out anything to the contrary.

jez9999 wrote:when the window is maximized in Windows, for some reason the bevel at the bottom of the window is a bit thicker than before

Where..? The below are from Windows 10, but I also checked on Windows 7 too and saw no issues like this.

See the below screenshots for examples:

Before:
a.png


Now:
b.png

User avatar
Lootyhoof
Themeist
Themeist
Posts: 852
Joined: Thu Feb 09, 2012 11:35 pm
Location: United Kingdom

Re: [Release] Various theme ports/forks

Postby Lootyhoof » Sat Sep 23, 2017 8:02 pm

Thanks. Try this one now?
Attachments
moonfox3-2-0-1b3-pm.xpi
(1.02 MiB) Downloaded 2 times

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Sat Sep 23, 2017 8:16 pm

They seem to be fixed in that one, yeah. Is there any change on icon on mouseover now though? I think the icons got slightly darker on mouseover on Fx3.

User avatar
Lootyhoof
Themeist
Themeist
Posts: 852
Joined: Thu Feb 09, 2012 11:35 pm
Location: United Kingdom

Re: [Release] Various theme ports/forks

Postby Lootyhoof » Sat Sep 23, 2017 8:29 pm

It gets slightly darker when you click the icons, for native buttons only (no extensions).

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Sat Sep 23, 2017 11:18 pm

Lootyhoof wrote:It gets slightly darker when you click the icons, for native buttons only (no extensions).

It doesn't seem to get at all darker on mouseover for those buttons in your theme now, though. Not visibly to the naked eye anyway.

User avatar
Lootyhoof
Themeist
Themeist
Posts: 852
Joined: Thu Feb 09, 2012 11:35 pm
Location: United Kingdom

Re: [Release] Various theme ports/forks

Postby Lootyhoof » Mon Sep 25, 2017 8:50 pm

I've tweaked the button states more now. I had a look at Firefox 3, and yes, these do work on hover rather than click, which I've now accounted for.

Try this one?
Attachments
moonfox3-2-0-1b4-pm.xpi
(1.02 MiB) Downloaded 1 time

jez9999
Apollo supporter
Apollo supporter
Posts: 48
Joined: Sat May 30, 2015 7:35 pm
Location: UK

Re: [Release] Various theme ports/forks

Postby jez9999 » Mon Sep 25, 2017 9:21 pm

Seems to be correct now but I still don't see why you couldn't just keep the previous theme which I created and I made sure I got everything right.


Return to “Themes”

Who is online

Users browsing this forum: No registered users and 1 guest