Wrong positioning of Private window indicator

Support and discussions for the Apple Mac OSX builds of Pale Moon

Moderator: satrow

Forum rules
Important note:
The Mac OSX version of Pale Moon is still very much in development. Your assistance in bringing this build to fruition is greatly appreciated, but you can expect there to be bugs and problems for a while yet!

Any specific bugs you find that don't have their own topic yet: please make a new topic; one bug per topic please to keep things organized.

Please also note that these builds are currently created by Sugis and Moonchild will likely not be able to provide insight or assistance due to lack of Mac hardware and OS/build knowledge for Mac.
User avatar
adesh
Astronaut
Astronaut
Posts: 564
Joined: Tue, 06 Jun 2017, 07:38

Wrong positioning of Private window indicator

Unread postby adesh » Thu, 29 Mar 2018, 09:27

On Mac OS, positioning of private window icon is where a website's favicon is normally displayed alongside page title in a tab. If I open a website in this tab, obviously private window icon gets replaced with the site icon and now there is no indication of the private browsing in the browser window.
Attachments
Screen Shot 2018-03-27 at 4.25.29 PM.png
Last edited by adesh on Thu, 29 Mar 2018, 09:28, edited 1 time in total.

User avatar
New Tobin Paradigm
Knows the dark side
Knows the dark side
Posts: 4688
Joined: Tue, 09 Oct 2012, 19:37

Re: Wrong positioning of Private window indicator

Unread postby New Tobin Paradigm » Thu, 29 Mar 2018, 10:42

Where did this build come from.. There are NO authorized branded builds for macintosh.

User avatar
adesh
Astronaut
Astronaut
Posts: 564
Joined: Tue, 06 Jun 2017, 07:38

Re: Wrong positioning of Private window indicator

Unread postby adesh » Thu, 29 Mar 2018, 11:27

I created this build myself to test how Pale Moon behaves on a Mac.
Tried it with sugis' build (yes, unofficial) also and result is the same.

User avatar
wicknix
Moonbather
Moonbather
Posts: 64
Joined: Mon, 26 Mar 2018, 04:47
Location: Wisconsin, USA

Re: Wrong positioning of Private window indicator

Unread postby wicknix » Mon, 02 Apr 2018, 03:39

Hmm, i have an indicator on 10.6.8 if i open a private window. FYI i'm using the XMoon theme just in case its a default theme issue.

Screen shot 2018-04-01 at 10.32.34 PM.png
Last edited by wicknix on Mon, 02 Apr 2018, 03:43, edited 1 time in total.
Silence is golden, but duct tape is silver...

User avatar
adesh
Astronaut
Astronaut
Posts: 564
Joined: Tue, 06 Jun 2017, 07:38

Re: Wrong positioning of Private window indicator

Unread postby adesh » Mon, 02 Apr 2018, 08:14

I tried hacking some files in "browser" directory and a rebuild but could not get it to display like on Windows and Linux.

Thanks wicknix for your report! This is indeed a default theme issue. I get the same result as you when using XMoon theme.
Now, I probably need to look at XMoon theme code and port the fix to the default one.
Last edited by adesh on Mon, 02 Apr 2018, 08:15, edited 1 time in total.

User avatar
SpockFan02
Lunatic
Lunatic
Posts: 460
Joined: Sun, 24 Sep 2017, 16:35

Re: Wrong positioning of Private window indicator

Unread postby SpockFan02 » Wed, 01 Aug 2018, 23:52

For the record, Issue #553 (UXP) was opened for this, and fixed for Pale Moon 28.

User avatar
adesh
Astronaut
Astronaut
Posts: 564
Joined: Tue, 06 Jun 2017, 07:38

Re: Wrong positioning of Private window indicator

Unread postby adesh » Thu, 02 Aug 2018, 06:44

Sadly it still does not show it for me. Below is the private window, launched with ./mach run (did clobber first). "Private Browsing" is in window title, but NO icon.
Screen Shot 2018-08-02 at 12.06.28 PM.png

One improvement is that now caption buttons are available in private window.
Screen Shot 2018-08-02 at 12.26.31 PM.png


UPDATE:
Caption buttons are only available in non-maximized window. No PB mode indicator.
Screen Shot 2018-08-02 at 4.34.39 PM.png


I am using latest mac os. High Sierra fully updated.
Last edited by adesh on Thu, 02 Aug 2018, 11:07, edited 2 times in total.

User avatar
SpockFan02
Lunatic
Lunatic
Posts: 460
Joined: Sun, 24 Sep 2017, 16:35

Re: Wrong positioning of Private window indicator

Unread postby SpockFan02 » Thu, 02 Aug 2018, 08:51

adesh wrote:Sadly it still does not show it for me. Below is the private window, launched with ./mach run (did clobber first). "Private Browsing" is in window title, but NO icon.
Screen Shot 2018-08-02 at 12.06.28 PM.png
One improvement is that now caption buttons are available in private window.
Screen Shot 2018-08-02 at 12.26.31 PM.png
o_0

I'm a little confused, because I'm sure it was fixed, and also neither of your screenshots show the caption buttons you say are there (as they should be).

I just pulled the latest commit from the UXP repo, clobbered, and built to check again. I am on macOS "Sierra" 10.12.6.
Screenshot 2018-08-02 01.49.12.png

User avatar
adesh
Astronaut
Astronaut
Posts: 564
Joined: Tue, 06 Jun 2017, 07:38

Re: Wrong positioning of Private window indicator

Unread postby adesh » Thu, 02 Aug 2018, 11:10

Just updated my previous post - caption buttons are not available in maximized window. No PB indicator, whatever the window size.

User avatar
SpockFan02
Lunatic
Lunatic
Posts: 460
Joined: Sun, 24 Sep 2017, 16:35

Re: Wrong positioning of Private window indicator

Unread postby SpockFan02 » Thu, 02 Aug 2018, 12:27

I also just built on 10.9, the Private Browsing indicator is still there. Interestingly, though, on my 10.9 machine, maximizing the window makes the caption buttons disappear, and the resizing arrows at the top-right of the window (no longer exist in more recent macOS versions) seems to shift up so only the bottom of one arrow is visible. Perhaps on certain computers, a maximized window shifts things in the titlebar up and out of view....

In the middle of your now three screenshots, what is that mysterious blurry purple blob that seems to be right where the purple indicator should be?

And in your other screenshots, it looks like the titlebar has -moz-appearance: -moz-window-titlebar, which it shouldn't.

User avatar
SpockFan02
Lunatic
Lunatic
Posts: 460
Joined: Sun, 24 Sep 2017, 16:35

Re: Wrong positioning of Private window indicator

Unread postby SpockFan02 » Fri, 03 Aug 2018, 08:39

Correction/clarification:

On OS X 10.9, clicking the green caption button expands the window to take up the full width and height that it could be resized to (not overlapping the dock and keeping visible the toolbar along the top of the screen and the window titlebar), and clicking the arrows in the top-right corner of the window puts it in fullscreen. In proper fullscreen, there are no caption buttons (fullscreen can be exited by moving the mouse to the top of the screen and then clicking the arrows in the top-right). This is expected on this version of OS X and in line with e.g. Safari. In more recent versions of macOS, including 10.12, the fullscreen arrows are not present and clicking the green caption button enters fullscreen, wherein placing the mouse at the top of the window brings down a titlebar with caption buttons.

What is not expected, but I notice happening, is that when a Private Browsing window is expanded to full size (but not fullscreen), either by dragging its edges or pressing the green caption button on 10.9, the caption buttons disappear. On 10.9 I can see the bottom edge of the fullscreen arrows, and on 10.12 I can see the very bottoms of the caption buttons. So when the window is expanded to full size, these items are shifted up and mostly out of view. With a lightweight theme installed (Private window or not), expanding the window like this does the same thing.

I also noticed that in fullscreen, the Private Browsing indicator is missing. In pre-Australis Firefox, it is present (though farther towards the edge of the screen than when not in fullscreen), so I must have overlooked something when I restored it. EDIT: With tabs on the bottom, toolbar items take up the space the indicator would be in in fullscreen. I just chatted with Moonchild and Tobin and found out that other platforms don't indicate Private Browsing while in fullscreen, so this will not be fixed.

Thank you for getting me to look at this again, because there are someis at least one problems that I apparently overlookedwas not aware of. However, I still do not understand why the Private Browsing indicator apparently always fails to appear for you, or why your titlebar looks the way it does in a Private window. Maybe the CSS just isn't applying on High Sierra? :wtf:
Last edited by SpockFan02 on Fri, 03 Aug 2018, 09:21, edited 1 time in total.


Return to “Pale Moon for Mac OSX”

Who is online

Users browsing this forum: No registered users and 1 guest