Regarding the PM4Linux-installer:readme-work branch
Posted: 2015-03-02, 14:03
(This thread is mainly aimed at the Linux maintainer, "trava90"):
I've noticed that you have made a few commits to the Linux installer under the readme-work branch and have some questions and suggestions to make:
I've noticed that you have made a few commits to the Linux installer under the readme-work branch and have some questions and suggestions to make:
- For all the version numbers that you want to put over all the place, you may want to not put the actual version number everywhere, but some string like __VERSION__ that would be replaced at the point of compilation. This approach is already taken for strings like the URL, and it'll actually make your life easier when releasing a version.
- Is there really a need to put the readme into the installer script, since it's already there in the archive? Once someone figures out how to proceed with the install, the readme is useless, so I don't see the point.
The readme viewing does not work anyway, since the option is named with a capital letter "Readme" whereas you check with the smaller letter "readme" - Nitpick: In userdocs/README, I think it's fine that the document uses a first level Markdown heading since its the main heading.
It got me thinking... if its already Markdown, why distribute it as plain text instead of an HTML document? But there's a downside too: what if the user doesn't have a browser available? It's your call. - Nitpick: In userdocs/README, it should be "ask" instead of "as"