Crash on Unstable (graphics)

Users and developers helping users with generic and technical Pale Moon issues on all operating systems.

Moderator: trava90

Forum rules
This board is for technical/general usage questions and troubleshooting for the Pale Moon browser only.
Technical issues and questions not related to the Pale Moon browser should be posted in other boards!
Please keep off-topic and general discussion out of this board, thank you!
Locked
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-05, 03:27

Thanks!
But now I found like in this bug:
https://github.com/MoonchildProductions/UXP/issues/1324
But in my case that is both when I try with the default compiler:
$ gcc --version
gcc (GCC) 9.2.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
(no warranty it will build Pale Moon obviously :D ) and when I try in .mozconfig:
export CC=/usr/bin/gcc-5
export CXX=/usr/bin/g++-5
export HOST_CC=/usr/bin/gcc-5
export HOST_CXX=/usr/bin/g++-5
which worked in the past, but perhaps that is too old now, it's an old build on my system, no longer in the AUR. Both stop at the same place though. And I'm not using hardened Gentoo either, although I suppose Artix does take some inspiration from Gentoo. I tried at git head in both Pale Moon and UXP repos then took UXP to:
$ git branch
* (HEAD detached at PM28.0.0a2_Unstable)
master
Same result still.

Code: Select all

58:01.83 In file included from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/Assembler-x86-shared.h:17,
58:01.83                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/Assembler-x64.h:248,
58:01.83                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/MacroAssembler-x86-shared.h:15,
58:01.83                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/MacroAssembler-x64.h:12,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/MacroAssembler.h:18,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/BaselineJIT.h:18,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/BaselineIC.h:20,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/MIR.h:21,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/AlignmentMaskAnalysis.cpp:8,
58:01.84                  from /home/me/pmbuild/js/src/Unified_cpp_js_src8.cpp:2:
58:01.84 In member function ‘void js::jit::X86Encoding::BaseAssemblerX64::movq_mr(int32_t, js::jit::X86Encoding::RegisterID, js::jit::X86Encoding::RegisterID, int, js::jit::X86En
coding::RegisterID)’,
58:01.84     inlined from ‘void js::jit::Assembler::movq(const js::jit::Operand&, js::jit::Register)’ at /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/Assembler-x64.h:397:2
5:
58:01.84 /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/BaseAssembler-x64.h:596:13: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
58:01.84   596 |         spew("movq       " MEM_obs ", %s", ADDR_obs(offset, base, index, scale), GPReg64Name(dst));
58:01.84       |         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
58:01.84 In file included from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/BaseAssembler-x86-shared.h:35,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/BaseAssembler-x64.h:10,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/Assembler-x86-shared.h:17,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/Assembler-x64.h:248,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/MacroAssembler-x86-shared.h:15,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x64/MacroAssembler-x64.h:12,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/MacroAssembler.h:18,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/BaselineJIT.h:18,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/BaselineIC.h:20,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/MIR.h:21,
58:01.84                  from /home/me/pmsrc/Pale-Moon/platform/js/src/jit/AlignmentMaskAnalysis.cpp:8,
58:01.84                  from /home/me/pmbuild/js/src/Unified_cpp_js_src8.cpp:2:
58:01.84 /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/AssemblerBuffer-x86-shared.h: In function ‘void js::jit::Assembler::movq(const js::jit::Operand&, js::jit::Reg
ister)’:
58:01.85 /home/me/pmsrc/Pale-Moon/platform/js/src/jit/x86-shared/AssemblerBuffer-x86-shared.h:46:32: note: format string is defined here
58:01.85    46 | #define MEM_obs   MEM_o   "(%s,%s,%d)"
58:01.85       |                                ^~
58:10.34 cc1plus: some warnings being treated as errors
58:11.24
58:11.24 In the directory  /home/me/pmbuild/js/src
58:11.24 The following command failed to execute properly:
58:11.24 /usr/bin/g++ -std=gnu++11 -o Unified_cpp_js_src8.o -c -I/home/me/pmbuild/dist/system_wrappers -include /home/me/pmsrc/Pale-Moon/platform/config/gcc_hidden.h -DNDEB
UG=1 -DTRIMMED=1 -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX="lib" -DDLL_SUFFIX=".so" -DFFI_BUILDING -DMOZ_HAS_MOZGLUE -I/home/me/pmsrc/Pale-Moon
/platform/js/src -I/home/me/pmbuild/js/src -I/home/me/pmbuild/js/src/ctypes/libffi/include -I/home/me/pmsrc/Pale-Moon/platform/js/src/ctypes/libffi/src/x86 -I/home/me
/pmbuild/dist/include -I/home/me/pmbuild/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /home/me/pmbuild/js/src/js-confdefs.h -MD -MP -MF .deps/Unified_cpp_js_src8.o.pp
-Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof
-Wc++14-compat -Wc++1z-compat -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=multistatement-macros -W
no-noexcept-type -flifetime-dse=1 -fno-rtti -fno-exceptions -fno-math-errno -msse2 -mfpmath=sse -pthread -pipe -g -freorder-blocks -O3 -fomit-frame-pointer -Wno-shadow -Werror=fo
rmat -fno-strict-aliasing /home/me/pmbuild/js/src/Unified_cpp_js_src8.cpp
58:11.24 make[4]: *** [/home/me/pmsrc/Pale-Moon/platform/config/rules.mk:886: Unified_cpp_js_src8.o] Error 1
58:11.24 make[3]: *** [/home/me/pmsrc/Pale-Moon/platform/config/recurse.mk:71: js/src/target] Error 2
58:11.24 make[2]: *** [/home/me/pmsrc/Pale-Moon/platform/config/recurse.mk:33: compile] Error 2
58:11.24 make[1]: *** [/home/me/pmsrc/Pale-Moon/platform/config/rules.mk:494: default] Error 2
58:11.24 make: *** [client.mk:400: build] Error 2
58:11.26 325 compiler warnings present.
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-05, 10:48

So did you try to work around it by patching your local build?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
New Tobin Paradigm

Re: Crash on Unstable (graphics)

Unread post by New Tobin Paradigm » 2020-01-05, 19:16

I don't think he knows what he has done or what he is doing.
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-06, 02:44

Same error, different place. I probably need to add CXXFLAGS += ['-Wno-error=format-overflow'] in js/xpconnect/src/moz.build to get this one. Try again another day.
Re gcc5 from earlier, I think it was actually installed from the Arch binary repos ages ago. (I left it as it doesn't get updates and was useful for Pale Moon in the past) If it's getting used at that point, it gets mentioned in the config, it might not be the gcc version that causes the build failure. (Today I used gcc 9 as it seems to not make a difference.) I copied the contents of my existing updated git local UXP repo into platform, but I think there's some proper git way to pull sub repo's, and perhaps I should put a .mozconfig in platform as well as in the Pale-Moon directory or something. I haven't used this new arrangement yet to have a successful formula to compare with.
$ pacman -Qi gcc5
Name : gcc54
Version : 5.4.1-1
Description : The GNU Compiler Collection (5.4.x)
Architecture : x86_64
Build Date : Sat 05 May 2018 02:02:29 BST
Install Date : Tue 14 Aug 2018 21:22:08 BST

Code: Select all

128:02.25 In file included from /home/me/pmbuild/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp:38:
128:02.25 /home/me/pmsrc/Pale-Moon/platform/js/xpconnect/src/XPCWrappedNative.cpp: In member function ‘char* XPCWrappedNative::ToString(XPCWrappedNativeTearOff*) const’:
128:02.25 /home/me/pmsrc/Pale-Moon/platform/js/xpconnect/src/XPCWrappedNative.cpp:2221:41: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
128:02.25  2221 |                 name = JS_sprintf_append(name, fmt,
128:02.25       |                        ~~~~~~~~~~~~~~~~~^~~~~~~~~~~
128:02.26  2222 |                                          array[i]->GetNameString());
128:02.26       |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~
128:04.53 cc1plus: some warnings being treated as errors
128:05.00
128:05.00 In the directory  /home/me/pmbuild/js/xpconnect/src
128:05.00 The following command failed to execute properly:
128:05.00 /usr/bin/g++ -std=gnu++11 -o Unified_cpp_js_xpconnect_src1.o -c -I/home/me/pmbuild/dist/stl_wrappers -I/home/me/pmbuild/dist/system_wrappers -include /home/me/pmsrc/Pal
e-Moon/platform/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/me/
pmsrc/Pale-Moon/platform/js/xpconnect/src -I/home/me/pmbuild/js/xpconnect/src -I/home/me/pmbuild/ipc/ipdl/_ipdlheaders -I/home/me/pmsrc/Pale-Moon/platform/ipc/chromium/src -I/hom
e/me/pmsrc/Pale-Moon/platform/ipc/glue -I/home/me/pmsrc/Pale-Moon/platform/js/xpconnect/loader -I/home/me/pmsrc/Pale-Moon/platform/js/xpconnect/wrappers -I/home/me/pmsrc/Pale-Moo
n/platform/caps -I/home/me/pmsrc/Pale-Moon/platform/dom/base -I/home/me/pmsrc/Pale-Moon/platform/dom/html -I/home/me/pmsrc/Pale-Moon/platform/dom/svg -I/home/me/pmsrc/Pale-Moon/p
latform/dom/workers -I/home/me/pmsrc/Pale-Moon/platform/layout/base -I/home/me/pmsrc/Pale-Moon/platform/layout/style -I/home/me/pmsrc/Pale-Moon/platform/xpcom/reflect/xptinfo -I/
home/me/pmbuild/dist/include -I/home/me/pmbuild/dist/include/nspr -I/home/me/pmbuild/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /home/me/pmbuild/mozilla-config.h -MD -MP -M
F .deps/Unified_cpp_js_xpconnect_src1.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-
code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array
-bounds -flifetime-dse=1 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fomit-frame-pointer -Wno-shadow -W
error=format /home/me/pmbuild/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp
128:05.00 make[4]: *** [/home/me/pmsrc/Pale-Moon/platform/config/rules.mk:895: Unified_cpp_js_xpconnect_src1.o] Error 1
128:05.00 make[3]: *** [/home/me/pmsrc/Pale-Moon/platform/config/recurse.mk:71: js/xpconnect/src/target] Error 2
128:05.00 make[2]: *** [/home/me/pmsrc/Pale-Moon/platform/config/recurse.mk:33: compile] Error 2
128:05.00 make[1]: *** [/home/me/pmsrc/Pale-Moon/platform/config/rules.mk:503: default] Error 2
128:05.00 make: *** [client.mk:400: build] Error 2
128:05.03 538 compiler warnings present.
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-06, 11:33

Suggestion: inform yourself first about using git submodules. It has already been documented how to do this.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-07, 03:12

Yes, thanks. Adding that to js/xpconnect/src/moz.build did allow a successful build with gcc9.2. Then I started afresh with git clone --recursive and built in vanilla copies of that, only adding a .mozconfig and doing ./mach build. I tried with gcc9.2 and it failed as before. Then I installed gcc8 from the repos. Arch doesn't have update-alternatives so I symlinked everything in /usr/bin from gcc-8 without the -8 suffix from /usr/local/bin, which is apparently a simple fairly failsafe way to override the default gcc, which is always the latest version. That built fine with debug symbols.

Code: Select all

(gdb) bt
#0  0x00007f29bfbb87b5 in raise () at /usr/lib/libpthread.so.0
#1  0x00007f29bcae6b78 in nsProfileLock::FatalSignalHandler(int, siginfo_t*, void*) (signo=11, info=0x7ffdad2ce070, context=0x7ffdad2cdf40)
    at /home/me/pmsrc/Pale-Moon/platform/toolkit/profile/nsProfileLock.cpp:177
#2  0x00007f29bd85ba6d in WasmFaultHandler<(Signal)0> (context=0x7ffdad2cdf40, info=0x7ffdad2ce070, signum=11)
    at /home/me/pmsrc/Pale-Moon/platform/js/src/wasm/WasmSignalHandlers.cpp:1222
#3  0x00007f29bd85ba6d in WasmFaultHandler<(Signal)0>(int, siginfo_t*, void*) (signum=<optimized out>, info=0x7ffdad2ce070, context=0x7ffdad2cdf40)
    at /home/me/pmsrc/Pale-Moon/platform/js/src/wasm/WasmSignalHandlers.cpp:1222
#4  0x00007f29bfbb8930 in <signal handler called> () at /usr/lib/libpthread.so.0
#5  0x00007f29a6231ecb in cli_push_get (bo=0x0, client=0x7f29acba1c60) at ../libdrm-2.4.100/nouveau/private.h:57
#6  0x00007f29a6231ecb in pushbuf_kref (push=push@entry=0x7f29acb398a0, bo=0x0, flags=<optimized out>) at ../libdrm-2.4.100/nouveau/pushbuf.c:169
#7  0x00007f29a623278b in pushbuf_validate (push=push@entry=0x7f29acb398a0, retry=retry@entry=true) at ../libdrm-2.4.100/nouveau/pushbuf.c:502
#8  0x00007f29a62329d0 in nouveau_pushbuf_validate (push=push@entry=0x7f29acb398a0) at ../libdrm-2.4.100/nouveau/pushbuf.c:749
#9  0x00007f29ab425cfd in nv50_sifc_linear_u8 (nv=0x7f298b998000, dst=0x7f298eb07700, offset=0, domain=<optimized out>, size=16, data=0x7f297c779e40)
    at ../mesa-19.3.1/src/gallium/drivers/nouveau/nv50/nv50_transfer.c:161
#10 0x00007f29ab42694a in nv50_cb_push (nv=<optimized out>, res=0x7f298cdc5700, offset=<optimized out>, words=<optimized out>, data=<optimized out>)
    at ../mesa-19.3.1/src/gallium/drivers/nouveau/nv50/nv50_transfer.c:433
#11 0x00007f29ab43e22a in nouveau_transfer_write (nv=nv@entry=0x7f298b998000, tx=tx@entry=0x7f298a8ff740, offset=offset@entry=0, size=16)
    at ../mesa-19.3.1/src/gallium/drivers/nouveau/nouveau_buffer.c:213
#12 0x00007f29ab43e409 in nouveau_buffer_transfer_unmap (pipe=0x7f298b998000, transfer=0x7f298a8ff740) at ../mesa-19.3.1/src/gallium/drivers/nouveau/nouveau_buffer.c:540
#13 0x00007f29abba5da9 in u_transfer_unmap_vtbl (pipe=<optimized out>, transfer=<optimized out>) at ../mesa-19.3.1/src/gallium/auxiliary/util/u_transfer.c:158
#14 0x00007f29abba5c63 in pipe_transfer_unmap (transfer=<optimized out>, context=0x7f298b998000) at ../mesa-19.3.1/src/gallium/auxiliary/util/u_inlines.h:515
#15 0x00007f29abba5c63 in u_default_buffer_subdata (pipe=0x7f298b998000, resource=<optimized out>, usage=<optimized out>, offset=<optimized out>, size=16, data=0x7f297c4ba080)
    at ../mesa-19.3.1/src/gallium/auxiliary/util/u_transfer.c:39
#16 0x00007f29ab7c5935 in st_bufferobj_subdata (ctx=<optimized out>, offset=<optimized out>, size=<optimized out>, data=<optimized out>, obj=<optimized out>)
    at ../mesa-19.3.1/src/mesa/main/bufferobj.h:45
#17 0x00007f29ab65b091 in _mesa_buffer_sub_data
    (ctx=ctx@entry=0x7f298cac0000, bufObj=bufObj@entry=0x7f298b06ba80, offset=offset@entry=0, size=size@entry=16, data=data@entry=0x7f297c4ba080)
    at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2267
#18 0x00007f29ab65b67e in buffer_sub_data
    (func=0x7f29ac215ffe "glBufferSubData", no_error=false, dsa=false, data=0x7f297c4ba080, size=16, offset=0, buffer=0, target=<optimized out>)
    at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2299
#19 0x00007f29ab65b67e in _mesa_BufferSubData (target=<optimized out>, offset=0, size=16, data=0x7f297c4ba080) at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2316
#20 0x00007f29bbbedf30 in mozilla::gl::GLContext::fBufferSubData(unsigned int, long, long, void const*) (this=
    0x7f298e7fd000, this=0x7f298e7fd000, data=0x7f297c4ba080, size=16, offset=0, target=34962) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:970
#21 0x00007f29bbbedf30 in mozilla::WebGLContext::BufferSubDataImpl(unsigned int, long, unsigned long, unsigned char const*) (this=this@entry=
    0x7f2994821800, target=target@entry=34962, dstByteOffset=dstByteOffset@entry=0, dataLen=16, data=0x7f297c4ba080 "")
    at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:431
#22 0x00007f29bbbee0e7 in mozilla::WebGLContext::BufferSubData(unsigned int, long, mozilla::dom::ArrayBufferView_base<&js::UnwrapArrayBufferView, &js::GetArrayBufferViewLengthAndData, &(JS_GetArrayBufferViewType(JSObject*))> const&, unsigned int, unsigned int)
    (this=this@entry=0x7f2994821800, target=target@entry=34962, dstByteOffset=dstByteOffset@entry=0, src=..., srcElemOffset=srcElemOffset@entry=0, srcElemCountOverride=srcElemCountOverride@entry=0) at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:466
#23 0x00007f29bb8ce360 in mozilla::dom::WebGLRenderingContextBinding::bufferSubData(JSContext*, JS::Handle<JSObject*>, mozilla::WebGLContext*, JSJitMethodCallArgs const&)
--Type <RET> for more, q to quit, c to continue without paging--c
    (cx=0x7f29b4856000, obj=..., self=0x7f2994821800, args=...) at /home/me/pmbuild/dom/bindings/WebGLRenderingContextBinding.cpp:11663
#24 0x00007f29bbb700e1 in mozilla::dom::GenericBindingMethod(JSContext*, unsigned int, JS::Value*) (cx=0x7f29b4856000, argc=<optimized out>, vp=<optimized out>) at /home/me/pmbuild/dist/include/js/RootingAPI.h:1004
#25 0x0000321f2255f6aa in  ()
#26 0x00007f297ea02440 in  ()
#27 0x00007ffdad2ce8b0 in  ()
#28 0x0000000000000000 in  ()
And it looks like there has already been some interest in this area from the comment:
platform/dom/canvas/WebGLContextBuffers.cpp
// Warning: Possibly shared memory. See bug 1225033.
gl->fBufferSubData(target, dstByteOffset, glDataLen, data);
Wait, it's all Ohio? Always has been...
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-08, 14:16

I successfully built another Pale Moon with gcc-8 by exporting that from the .mozconfig so would ignore the gcc-5 thing as anomalous due to doing something unexpected, probably causing gcc 9.2 to be used.
After creating 5 coredumps with this I found 3 variants:

Code: Select all

1)
#14 0x00007f753800498a in _mesa_validated_drawrangeelements at ../mesa-19.3.1/src/mesa/main/draw.c:816
#15 0x00007f7538004c7f in _mesa_DrawElements (mode=4, count=3456, type=5123, indices=0x0) at ../mesa-19.3.1/src/mesa/main/draw.c:970
#16 0x00007f75490de182 in mozilla::gl::GLContext::raw_fDrawElements(unsigned int, int, unsigned int, void const*) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:1162
#17 0x00007f75490de182 in mozilla::gl::GLContext::fDrawElements(unsigned int, int, unsigned int, void const*) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:1162
#18 0x00007f75490de182 in mozilla::WebGLContext::DrawElements at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextDraw.cpp:831
3)
#18 0x00007faf4f90498a in _mesa_validated_drawrangeelements at ../mesa-19.3.1/src/mesa/main/draw.c:816
#19 0x00007faf4f904c7f in _mesa_DrawElements (mode=4, count=3456, type=5123, indices=0x0) at ../mesa-19.3.1/src/mesa/main/draw.c:970
#20 0x00007faf5fcca182 in mozilla::gl::GLContext::raw_fDrawElements at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:1162
#21 0x00007faf5fcca182 in mozilla::gl::GLContext::fDrawElements(unsigned int, int, unsigned int, void const*) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:1162
#22 0x00007faf5fcca182 in mozilla::WebGLContext::DrawElements at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextDraw.cpp:831



2)
#20 0x00007f9de245b67e in buffer_sub_data at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2299
#21 0x00007f9de245b67e in _mesa_BufferSubData  at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2316
#22 0x00007f9df3812f30 in mozilla::gl::GLContext::fBufferSubData(unsigned int, long, long, void const*) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:970
#23 0x00007f9df3812f30 in mozilla::WebGLContext::BufferSubDataImpl at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:431
#24 0x00007f9df38130e7 in mozilla::WebGLContext::BufferSubData  at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:466
5)
#18 0x00007ff5c9c5b67e in buffer_sub_data at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2299
#19 0x00007ff5c9c5b67e in _mesa_BufferSubData (target=<optimized out>, offset=0, size=48, data=0x7ff59b204b40) at ../mesa-19.3.1/src/mesa/main/bufferobj.c:2316
#20 0x00007ff5db112f30 in mozilla::gl::GLContext::fBufferSubData(unsigned int, long, long, void const*) at /home/me/pmsrc/Pale-Moon/platform/gfx/gl/GLContext.h:970
#21 0x00007ff5db112f30 in mozilla::WebGLContext::BufferSubDataImpl at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:431
#22 0x00007ff5db1130e7 in mozilla::WebGLContext::BufferSubData at /home/me/pmsrc/Pale-Moon/platform/dom/canvas/WebGLContextBuffers.cpp:466



4)
#18 0x00007f616727e0ce in _mesa_draw_arrays at ../mesa-19.3.1/src/mesa/main/draw.c:374
#19 0x00007f616727e152 in _mesa_DrawArrays (mode=4, start=0, count=6) at ../mesa-19.3.1/src/mesa/main/draw.c:531
#20 0x00007f6176c08a4a in mozilla::gl::GLContext::raw_fDrawArrays(unsigned int, int, int) at /home/me/pmbuild/dist/include/GLContext.h:1156
#21 0x00007f6176c08a4a in mozilla::gl::GLContext::fDrawArrays(unsigned int, int, int) at /home/me/pmbuild/dist/include/GLContext.h:1156
#22 0x00007f6176c08a4a in mozilla::layers::CompositorOGL::BindAndDrawQuad at /home/me/pmsrc/Pale-Moon/platform/gfx/layers/opengl/CompositorOGL.cpp:1568
#23 0x00007f6176c08cdb in mozilla::layers::CompositorOGL::BindAndDrawGeometryWithTextureRect at /home/me/pmsrc/Pale-Moon/platform/gfx/layers/opengl/CompositorOGL.cpp:1537
So it is not as simple as Pale Moon does some particular thing that causes the crash, rather perhaps it is doing some things with mesa that eventually results in memory corruption / buffer overflow which gives the various outcomes - freezing Pale Moon, crashing Pale Moon, freezing the graphical environment or sometimes even the entire OS thus requiring a hard power off.

If I can formulate the info into some usable form and get some more info with "apitrace" as requested by mesa bug tracking then perhaps I will be able to file a bug there, although their open bugs outnumber closed ones by a large margin.
Attachments
gdbfullbacktraces.txt
(119.42 KiB) Downloaded 10 times
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-08, 16:28

I've pushed a blocklist entry to the Pale Moon repo (master) that should block the broken driver's crashing features.
Could you try again with that in place?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-08, 21:05

Yes, certainly, in due course. But I think I have just discovered something very exciting using apitrace that may indicate how to solve the problem.
I was trying with --api gl and it was crashing / freezing as before. But I saw all these "unknown function" errors about glEGL this or that. So I tried with --api egl and it WORKS! No screen flickering or crashing. Also, instead of the page turning graphics, it had a slide across page change instead like Chromium. So this is crashing because it is somehow using / linking to gl when it should be egl? That could be a build error in the mesa or libdrm Arch PKGBUILD's, possibly not in Pale Moon at all.
Anyway - egl not gl - that is the fix, now where should it be applied!
:D

Code: Select all

$ apitrace trace --api gl /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
apitrace: loaded into /usr/bin/apitrace
apitrace: unloaded from /usr/bin/apitrace
apitrace: loaded into /home/me/pmbuild/dist/bin/palemoon
apitrace: redirecting dlopen("libGL.so.1", 0x1) from /home/me/pmbuild/dist/bin/libnspr4.so
apitrace: tracing to /home/me/pmsrc/Pale-Moon/palemoon.1.trace
apitrace: attempting to read configuration file: /home/me/.config/apitrace/gltrace.conf
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: unknown function "glEGLImageTargetTexture2DOES"
apitrace: warning: unknown function "glEGLImageTargetRenderbufferStorageOES"
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA4
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5
apitrace: warning: _gl_param_size: unknown GLenum 0x8CA5

$ rm palemoon.1.trace palemoon.trace 
$ apitrace trace --api egl /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
apitrace: loaded into /usr/bin/apitrace
apitrace: unloaded from /usr/bin/apitrace
apitrace: loaded into /home/me/pmbuild/dist/bin/palemoon
apitrace: redirecting dlopen("libGL.so.1", 0x1) from /home/me/pmbuild/dist/bin/libnspr4.so
apitrace: unloaded from /home/me/pmbuild/dist/bin/palemoon
Wait, it's all Ohio? Always has been...
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-09, 19:05

The patch does not work, surprisingly:

Code: Select all

$ ./mach run
 0:01.07 /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS (t=3.2647) [GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS
(Pale Moon froze up)
$ ./mach run
 0:00.33 /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS (t=0.774491) [GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS
palemoon: ../libdrm-2.4.100/nouveau/pushbuf.c:723: nouveau_pushbuf_data: Assertion `kref' failed.
(Pale Moon crashed)
$ apitrace trace --api egl /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
apitrace: loaded into /usr/bin/apitrace
apitrace: unloaded from /usr/bin/apitrace
apitrace: loaded into /home/me/pmbuild/dist/bin/palemoon
apitrace: redirecting dlopen("libGL.so.1", 0x1) from /home/me/pmbuild/dist/bin/libnspr4.so
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS (t=0.771542) [GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS
apitrace: unloaded from /home/me/pmbuild/dist/bin/palemoon
(Worked fine)
(Changed layers.acceleration.disabled to true)
$ ./mach run
 0:00.33 /home/me/pmbuild/dist/bin/palemoon -no-remote -profile /home/me/pmbuild/tmp/scratch_user
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS (t=0.576094) [GFX1-]: Unrecognized feature FEATURE_OPENGL_LAYERS
(Worked fine)

Built at:
Pale-Moon
commit b7841e5cf6dd6dc17eacc24b7dc1c215fda2a031 (HEAD -> master, origin/master, origin/HEAD)
Author: Pale Moon <git-repo@palemoon.org>
Date:   Wed Jan 8 17:26:55 2020 +0100

    Block Noveau NV96 mesa driver layers acceleration.

platform / UXP
commit 29bf28ca34cb3061d2a6c38f60b01f2d7ca1e1e2 (HEAD, origin/master, origin/HEAD)
Merge: d79cc5fb4 52bda2a82
Author: Moonchild <moonchild@palemoon.org>
Date:   Thu Jan 9 13:07:56 2020 +0000

    Merge pull request #1347 from g4jc/html5_dialog
    
    Implement HMTL5 <dialog>
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-09, 19:09

Well then. Not sure what the point is of having the feature defined if you can't use it in the blocklist :P

Please go into palemoon/app and edit blocklist.xml, go to the very bottom and remove the line that says:

Code: Select all

      <feature>FEATURE_OPENGL_LAYERS</feature>

Leave the rest in place. Rebuild, then try to run again.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-10, 17:58

No, that did not work again unfortunately. :(
I have been looking at the 'egl' aspect to see how / why that worked incidentally.

Code: Select all

~/pmsrc/Pale-Moon$ ag glEGLImageTarget
platform/gfx/angle/include/GLES2/gl2ext.h
234:GL_APICALL void GL_APIENTRY glEGLImageTargetTexture2DOES (GLenum target, GLeglImageOES image);
235:GL_APICALL void GL_APIENTRY glEGLImageTargetRenderbufferStorageOES (GLenum target, GLeglImageOES image);

platform/gfx/angle/src/libANGLE/renderer/gl/FunctionsGL.cpp
1887:    AssignGLExtensionEntryPoint(extensions, "GL_OES_EGL_image", loadProcAddress("glEGLImageTargetRenderbufferStorageOES"), &eglImageTargetRenderbufferStorageOES);
1888:    AssignGLExtensionEntryPoint(extensions, "GL_OES_EGL_image", loadProcAddress("glEGLImageTargetTexture2DOES"), &eglImageTargetTexture2DOES);

platform/gfx/angle/src/libGLESv2/libGLESv2.cpp
1454:void GL_APIENTRY glEGLImageTargetTexture2DOES(GLenum target, GLeglImageOES image)
1459:void GL_APIENTRY glEGLImageTargetRenderbufferStorageOES(GLenum target, GLeglImageOES image)

platform/gfx/angle/src/libGLESv2/libGLESv2.def
184:    glEGLImageTargetTexture2DOES    @297
185:    glEGLImageTargetRenderbufferStorageOES @298

platform/gfx/angle/src/tests/gl_tests/ImageTest.cpp
291:        glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, image);
308:        glEGLImageTargetTexture2DOES(GL_TEXTURE_EXTERNAL_OES, image);
325:        glEGLImageTargetRenderbufferStorageOES(GL_RENDERBUFFER, image);
824:    glEGLImageTargetTexture2DOES(GL_TEXTURE_CUBE_MAP_POSITIVE_X, image);
832:    glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, reinterpretHelper<GLeglImageOES>(0xBAADF00D));
838:    glEGLImageTargetRenderbufferStorageOES(GL_TEXTURE_2D, image);
847:    glEGLImageTargetRenderbufferStorageOES(GL_RENDERBUFFER,


platform/gfx/angle/src/libANGLE/moz.build:362:  OS_LIBS += [ 'd3d9', 'dxguid' ]
platform/gfx/angle/src/libEGL/moz.build:69:  OS_LIBS += [ 'd3d9', 'dxguid' ]
platform/gfx/angle/src/libGLESv2/moz.build:75:  OS_LIBS += [ 'd3d9', 'dxguid' ]
This seems to originate in the bundled angle lib. Possibly linking to 'egl' in libEGL would enable this. It seems to currently link to d3d9 which is presumably Direct 3D 9 here:
https://chromium.googlesource.com/angle/angle/+/master/README.md
And that isn't fully supported for Linux in angle according to that page. EGL is the "new" graphics layer on Linux, it has much better hardware support and the old GL interface is mothballed and not developed much now. The devs say "please use EGL!" Both gl and egl are provided by the libgvlnd package on my system and are merely different interfaces to the same hardware, but apparently egl is the better one to use now. The code must be built already in the angle lib to use this and if it was linked in on the linux build it could use that and might help resolve some hardware acceleration issues. So in theory... when angle was used it would take the WebGL etc. input as it does now, but feed it to EGL when appropriate, and (perhaps) work more reliably. The Kaieteur news page turning did have a bit less CPU use with EGL, although the animation is probably less demanding.
ac_add_options --with-gl-provider=EGL fails to build, so it isn't that simple, and my idea is to enable egl just for angle which can make use of it.

Perhaps not, angle might not even get built on Linux so those EGL functions could be from an included lib?
Wait, it's all Ohio? Always has been...
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-14, 13:11

The unsupported functions are from an ANGLE header file, a selected few cpp files from angle are built on Linux and the functions are in the header but not used anywhere. So that's irrelevant. The same crash / freeze happens using Devuan Beowulf, but not when booted with nomodeset on the kernel command line which uses software emulated graphics only.
Then I was gathering apitest data for a mesa bug report and one trace gave this error with apitrace replay:
58205: message: major shader compiler issue 14: 0:2(12): warning: extension `GL_ARB_gpu_shader5' unsupported in vertex shader
58205: message: major shader compiler issue 15: 0:2(12): warning: extension `GL_ARB_gpu_shader5' unsupported in fragment shader

So I searched that and found the examples on this bug also seem to reproduce the problem I encountered:
http://palebluepixel.org/static/projects/fireflies/
https://threejs.org/examples/webgl_video_panorama_equirectangular.html

https://bugzilla.mozilla.org/show_bug.cgi?id=1310741
A possible fix is included in this patch?
https://hg.mozilla.org/integration/mozilla-inbound/rev/465c8a6fcdcb
So that's interesting for further investigation.
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-14, 15:23

You could try that patch or the one from 1399501. We don't have affected hardware handy so if you could test and if successful, submit a PR to the UXP repo, that would be awesome :)
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-15, 14:37

The first patch for the angle code applies and builds fine, but doesn't fix this issue. The second file it modifies isn't used in the Linux build anyway. The next patch won't apply in several files, that's after deleting the mochitest bits. Comparing dom/canvas/WebGLContext.cpp in Pale Moon and current Firefox, they have a lot of differences, the patch calls new functions and has no obvious location and so on.
glxinfo shows there is no GL_ARB_gpu_shader5 on my hardware.
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-16, 00:47

I'm taking the ANGLE cherry pick anyway since that just seems an obvious improvement.
Tracking in Issue #1354 (UXP)

As it is I added some commits to trunk that should fix the crashes if I understand correctly. Please try building from the latest master.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-17, 07:57

@Lunokhod
There are a few more things you can try; one is disabling XRender (pref gfx.xrender.enabled), another is trying to build the GTK3 version which, as far as I understood, defaults to EGL (while you may currently be using GLX?).
Unfortunately I'm a little out of my depth regarding the whole Linux X11 graphics acceleration/compositor back-end shtick. My main expertise is Windows, so a lot of this is guessing based on what little information I've been able to garner from the source.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
User avatar
Lunokhod
Lunatic
Lunatic
Posts: 469
Joined: 2017-04-20, 21:25
Contact:
Contact Lunokhod

Re: Crash on Unstable (graphics)

Unread post by Lunokhod » 2020-01-18, 00:21

Building a GTK3 version failed here:

Code: Select all

120:11.53 In file included from /home/me/pmbuild/netwerk/protocol/http/Unified_cpp_protocol_http0.cpp:65:
120:11.53 /home/me/pmsrc/Pale-Moon/platform/netwerk/protocol/http/Http2Stream.cpp: In member function ‘bool mozilla::net::Http2Stream::Do0RTT()’:
120:11.53 /home/me/pmsrc/Pale-Moon/platform/netwerk/protocol/http/Http2Stream.cpp:1481:6: error: expected ‘(’ before ‘mTransaction’
120:11.54    if mTransaction->Do0RTT() {
120:11.54       ^~~~~~~~~~~~
120:11.54       (
120:11.54 /home/me/pmsrc/Pale-Moon/platform/netwerk/protocol/http/Http2Stream.cpp:1483:5: error: ‘else’ without a previous ‘if’
120:11.54    } else {
120:11.54      ^~~~
Confusion with a Python if ? :) Perhaps: if mTransaction->Do0RTT() { should be: if (mTransaction->Do0RTT()) {
I'll try another build when I get a chance.
The cumulative efforts of the entire Linux community to date have not yet perfected open source graphics so any progress is an achievement I think.
Wait, it's all Ohio? Always has been...
Top
User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35588
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:
Contact Moonchild

Re: Crash on Unstable (graphics)

Unread post by Moonchild » 2020-01-18, 01:09

Yeah dumb typo and not checked the build before committing.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite
Top
New Tobin Paradigm

Re: Crash on Unstable (graphics)

Unread post by New Tobin Paradigm » 2020-01-18, 01:11

It happens.
Top
Locked

Return to “Browser Support”