URL Bar behaviour in 33.8.2 Topic is solved

[Lecco]

Operating system: Windows 10
Browser version: 33.8.2
32-bit or 64-bit browser?: 64-bit
Problem URL: none
Browser theme (if not default): default
Installed add-ons: NoUn Buttons
Installed plugins: (about:plugins): none

Hello,

after the update to 33.8.2, I noticed a different behaviour of the URL bar compared to 33.8.1.

• When I open a new tab (CTRL+T or new tab button) and URL Bar in previous tab was empty, the URL bar in new tab is empty and is not focused.
• When I open a new tab (CTRL+T or new tab button) and URL Bar in previous tab was not empty, the URL bar in new tab has the same text as in previous tab and is not focused.
• When I open a new window, the URL bar does not get focused.
• When I press CTRL+L, the URL bar does not get focused. I can get to the location bar using the Tab key.
• When navigating on webpages, the text in URL Bar does not update at all.

With a fresh profile, I narrowed the issue down to an Add-on I use called "NoUn Buttons".

This Add-on not only allows for individual dropmarkers next to the back and forward buttons, but also comes bundled with its own location bar, which removes some icons and includes the Go button from Firefox 1.
When I use the default location bar, it works as expected, but with the "custom" location bar, I observe the behaviour I described above.

I updated this Add-on myself to get it to work in newer versions of Pale Moon, since there were some changes to the URL Bar in the past, but this one is a bit of a puzzle for me.

Looking up the commit history, I believe this is the one that changed the behaviour : https://repo.palemoon.org/MoonchildProd ... 2b8e4006f2
Unfortunately, from those changes, I'm not able to decipher what I need change in the Add-On, since the code that was changed are only two lines.

Most probably the relevant part of the Add-On code would be the XUL file where the URL Bar is "described".
The CSS file seems to be only for styling of the buttons and the JS file seems to be only used for filling the history dropdown menu under the dropmarkers.

I then compared the Add-ons code with the code in the repo to see if there are any differences in how the default URL Bar is "described" : https://repo.palemoon.org/MoonchildProd ... rowser.xul (lines 432-532)

Yes, there were some minor differences, but even after playing with the code, I was unable to convince the URL Bar to behave itself.

Maybe I'm just on a false path and the issue is with a different element ?

If some good soul would give me a hint I would really appreciate it.
I can upload the Add-On in question if requested.

[Moonchild]

I've checked behaviour in the browser in case there was a core issue but there is not -- everything works as-intended without the problematic add-on.
This means that the extension will have to be updated to work with later versions of Pale Moon.

[RealityRipple]

If the overridden url bar is keeping focus on these actions, it's gonna be fundamentally incompatible with this change. I was a little worried there'd be an edge case like this.

[Moonchild]

This add-on should be added to the blocklist at the compatibility warning level in that case. Can you attach a copy of the xpi so I can do this?

[Lecco]

Hello Moonchild and RealityRipple,

I have found the issue and fixed it.

• If I use the custom URL Bar with attached Go button at the end as a single item, the URL Bar doesn't work.
• If I split the custom URL Bar and Go Button to separate toolbar items, everything works as expected.

I may dig into why the Go Button breaks the URL Bar later, but I would consider this post this as solved.

During testing I have found a weird behaviour :

• The "custom broken" URL Bar starts to work in a single window when I customize the toolbar and make a change to it.
• Either adding or removing one item or moving the URL Bar up or down to another toolbar makes it work for that one window.

And just to clarify what "custom" means : I removed most of the additional items, that can be displayed in the URL Bar, like thar Star icon. Other than that, the code is identical to what can be found in browser.xul.

If you want to put the Add-on on a blacklist, go ahead, but I believe creating the custom URL Bar and attaching the Go Button next to the URL Bar was my "addition", since the original Add-on was only about splitting the back and forward buttons.
I'm not sure if the Add-on that can be publicly sourced will work in current Pale Moon, I vaguely remember fixing something regarding the Go Button, which was my addition anyway.

I did not publish my edited version anywhere, so that code did never circulate on the internet.

The original Add-on can be found here : http://web.archive.org/web/201709010921 ... /versions/

The Add-on was taken over by JSLover, but that XPI seems to have been lost to history.
http://web.archive.org/web/201608071714 ... Un-Buttons
http://web.archive.org/web/201910090135 ... Un-Buttons

Fri, Oct 21, 2016 --- 10/21/16, 3:19:19pm

I'm still planning on updating/supporting NoUn Buttons — however, that support may only be for Pale Moon.

Well, there was none.

[moonbat]

I did not publish my edited version anywhere, so that code did never circulate on the internet.

Given that the original is GNU licensed, you could fork and publish it here, put your forked code on GIthub or similar, let the addons team review it and then it will be available for others to install from the addons page.