pornhub videos not playing anymore after pm update Topic is solved

Users and developers helping users with generic and technical Pale Moon issues on all operating systems.

Moderator: trava90

Forum rules
This board is for technical/general usage questions and troubleshooting for the Pale Moon browser only.
Technical issues and questions not related to the Pale Moon browser should be posted in other boards!
Please keep off-topic and general discussion out of this board, thank you!
User avatar
therube
Board Warrior
Board Warrior
Posts: 1648
Joined: 2018-06-08, 17:02

Re: pornhub videos not playing anymore after pm update

Unread post by therube » 2023-01-27, 16:48

Confirmed.
So add a new useragent override (setting its' value as mentioned); general.useragent.override.pornhub.com


(I'll note that the default value of "dom.webcomponents.enabled" is 'false'.)


not playing anymore after pm update
That is only coincidence.

User avatar
UCyborg
Fanatic
Fanatic
Posts: 171
Joined: 2019-01-10, 09:37

Re: pornhub videos not playing anymore after pm update

Unread post by UCyborg » 2023-02-05, 23:32

One full page of posts and nobody figured out the main thing? First of all, Chromium does not actually accept space-separated codec list, comma is required. Second, one of the UXP messages always print codecs in console, separated by space, when it says it doesn't support them. Third, neither Chromium nor UXP object to "vp9, vorbis". Both seem to treat it the same as "vp9,vorbis". Seems you can put any number of spaces, before or after codec name, doesn't matter.

FInally, the real question is, why does UXP reject videos marked as being encoded with VP8 if it can actually play them?

https://test-videos.co.uk/jellyfish/webm-vp8

Download any video from the above site, create test.html file in the same folder as the video with the following content (I use the very first video file from the site in this example's video's src tag):

Code: Select all

<html>
<head>
<title>Video test</title>
<body>
<video controls>
	<source src="Jellyfish_1080_10s_1MB.webm" type='video/webm;codecs="vp8"'>
</video>
</body>
</head>
</html>
Check the video file with actual media player or tool such as MediaInfo to verify it's actually a VP8 video. Now open test.html, video won't load. Now change codecs="vp8" to codecs="vp9", now it suddenly works. Same if you remove type altogether. Guess it's just used to quickly filter out unsupported types when you specify multiple files with different encoding without having to check support by parsing the file.

User avatar
sidology
Moon lover
Moon lover
Posts: 79
Joined: 2021-12-04, 22:07

Re: pornhub videos not playing anymore after pm update

Unread post by sidology » 2023-02-06, 00:12

UCyborg wrote:
2023-02-05, 23:32
FInally, the real question is, why does UXP reject videos marked as being encoded with VP8 if it can actually play them?
All I know it worked before this commit, which added support for extended VPx codec strings, but also introduced "Cannot play media. No decoders for requested formats" for some sites.

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-06, 00:45

sidology wrote:
2023-02-06, 00:12
All I know it worked before this commit, which added support for extended VPx codec strings, but also introduced "Cannot play media. No decoders for requested formats" for some sites.
You can easy check that the pornhub does not work in PM v29.4.3 (2021-12-14) and v29.4.5 (2022-03-23) - before this commit https://repo.palemoon.org/MoonchildProd ... ssues/1820

User avatar
UCyborg
Fanatic
Fanatic
Posts: 171
Joined: 2019-01-10, 09:37

Re: pornhub videos not playing anymore after pm update

Unread post by UCyborg » 2023-02-06, 01:05

From what I could tell, that error related to crapping out with VP8 codec occurs due to some other JavaScript code on the site checking VP8 for whatever reason, but yeah, I don't think it's the main issue. Comparing with Chromium, it may want service workers for something. Last time I checked SeaMonkey, which doesn't have VP8 codec issue, the video element doesn't get created on that site...or it's attempted in unsupported manner. Maybe check how video tag on the site looks in Chromium for comparison.

Spoofing old Firefox makes it fallback to more compatible way of doing things.

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-06, 01:17

The embeded version works fine without useragent spoofing.
https://www.pornhub.com/embed/ph6310926684943

Yes, the browser has a problem with the VP8 codec, but this is another problem. Your test example (src="Jellyfish_1080_10s_1MB.webm" type='video/webm;codecs="vp8"') works in version 29.4.5, but the pornhub does not work anyway.

User avatar
sidology
Moon lover
Moon lover
Posts: 79
Joined: 2021-12-04, 22:07

Re: pornhub videos not playing anymore after pm update

Unread post by sidology » 2023-02-06, 01:22

Kris_88 wrote:
2023-02-06, 01:17
Yes, the browser has a problem with the VP8 codec, but this is another problem.
Sorry then, all my comments were about that "another" problem. I don't use pornhub, but thought it was the same problem, because of "Cannot play media. No decoders for requested formats".

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-07, 17:23

Moonchild wrote:
2022-12-03, 15:12

Code: Select all

video/webm;codecs="vp8,vorbis"
UCyborg wrote:
2023-02-05, 23:32
FInally, the real question is, why does UXP reject videos marked as being encoded with VP8 if it can actually play them?
sidology wrote:
2023-02-06, 01:22
I don't use pornhub, but thought it was the same problem, because of "Cannot play media. No decoders for requested formats".
If we fix it in this way, the vp8 will work.
platform\dom\media\platforms\agnostic\VPXDecoder.cpp

Code: Select all

static VPXDecoder::Codec MimeTypeToCodec(const nsACString& aMimeType)
{
  if (aMimeType.EqualsLiteral("video/webm; codecs=vp8")) {
    return VPXDecoder::Codec::VP8;
  } else if (aMimeType.EqualsLiteral("video/vp8")) {
    return VPXDecoder::Codec::VP8;
  } else if (aMimeType.EqualsLiteral("video/webm; codecs=vp9")) {
    return VPXDecoder::Codec::VP9;
  } else if (aMimeType.EqualsLiteral("video/vp9")) {
    return VPXDecoder::Codec::VP9;
  }
  return VPXDecoder::Codec::Unknown;
}
...

bool
VPXDecoder::IsVPX(const nsACString& aMimeType, uint8_t aCodecMask)
{
  return ((aCodecMask & VPXDecoder::VP8) &&
          aMimeType.EqualsLiteral("video/webm; codecs=vp8")) ||
         ((aCodecMask & VPXDecoder::VP8) &&
          aMimeType.EqualsLiteral("video/vp8")) ||
         ((aCodecMask & VPXDecoder::VP9) &&
          aMimeType.EqualsLiteral("video/webm; codecs=vp9")) ||
         ((aCodecMask & VPXDecoder::VP9) &&
          aMimeType.EqualsLiteral("video/vp9"));
}
Tests:
codecs="vp08.00.41.08,vorbis"
codecs="vp09.02.10.8.01.09.16.09.01,opus"
codecs="vp8"
codecs="vp9"

User avatar
UCyborg
Fanatic
Fanatic
Posts: 171
Joined: 2019-01-10, 09:37

Re: pornhub videos not playing anymore after pm update

Unread post by UCyborg » 2023-02-07, 22:38

Ah, I see VPXDecoder::Codec() was updated. What about VPXDecoder::IsVPX() ?

Also, if anyone doesn't mind enlightening me, where would "video/vp9" be used in practice? Can you specify it in video tag->source tag as type in some cases?

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-07, 23:52

UCyborg wrote:
2023-02-07, 22:38
What about VPXDecoder::IsVPX() ?
Probably Moonchild did not notice scrollbar in the "CODE" section?
Or he has other considerations...
UCyborg wrote:
2023-02-07, 22:38
where would "video/vp9" be used in practice?
It is used internally. There is a rather confusing code.
platform\dom\media\webm\WebMDecoder.cpp

Code: Select all

bool
WebMDecoder::CanHandleMediaType(const nsACString& aMIMETypeExcludingCodecs,
                                const nsAString& aCodecs)
...
      if (IsVP9CodecString(codec))  {
        trackInfo = CreateTrackInfoWithMIMEType(
          NS_LITERAL_CSTRING("video/vp9"));
      } else if (IsVP8CodecString(codec)) {
        trackInfo = CreateTrackInfoWithMIMEType(
          NS_LITERAL_CSTRING("video/vp8"));
      }
...

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35404
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: pornhub videos not playing anymore after pm update

Unread post by Moonchild » 2023-02-08, 00:33

Kris_88 wrote:
2023-02-07, 23:52
Probably Moonchild did not notice scrollbar in the "CODE" section?
Indeed.
This is the problem of not using the repo and PRs and instead just throwing code onto the forum.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-08, 00:54

I agree...
But I rarely post the code, it makes no sense to register ...

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35404
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: pornhub videos not playing anymore after pm update

Unread post by Moonchild » 2023-02-08, 10:20

Kris_88 wrote:
2023-02-08, 00:54
it makes no sense to register ...
It makes a lot of sense to register if you're actually interested in contributing code, even if rarely.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
UCyborg
Fanatic
Fanatic
Posts: 171
Joined: 2019-01-10, 09:37

Re: pornhub videos not playing anymore after pm update

Unread post by UCyborg » 2023-02-08, 20:52

Kris_88 wrote:
2023-02-07, 23:52
It is used internally. There is a rather confusing code.
platform\dom\media\webm\WebMDecoder.cpp
Thanks, I've got to CanHandleMediaType(), but got lost afterwards.
Moonchild wrote:
2023-02-08, 00:33
Indeed.
This is the problem of not using the repo and PRs and instead just throwing code onto the forum.
As long as it makes it to the repo in the end. :) But I get that that's why the repo is for.

But since we're conversing on the forum, conversation may sometimes naturally lead to some code being posted.

User avatar
UCyborg
Fanatic
Fanatic
Posts: 171
Joined: 2019-01-10, 09:37

Re: pornhub videos not playing anymore after pm update

Unread post by UCyborg » 2023-02-25, 08:58

I still notice the VP8 issue in Pale Moon 32.0.1. Were the changes somehow omitted for this release or they don't work as was intended? Am I missing something?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35404
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: pornhub videos not playing anymore after pm update

Unread post by Moonchild » 2023-02-25, 09:48

Unless it's something critical, a security point release won't include changes like these.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-25, 11:08

I am worried about one thing. I could not find a simple and transparent method to download the source for a specific Pale Moon release (in particular, for the latest version 32.0.1). Perhaps I just don't know some subtlety of using the repository.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35404
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: pornhub videos not playing anymore after pm update

Unread post by Moonchild » 2023-02-25, 11:24

Off-topic:
You use git and check out a specific tagged commit to pull down the source code.
See the instructions for building Pale moon from source specifically how to get the source code that way.
Also, if I don't forget, releases are published on the repo at https://repo.palemoon.org/MoonchildProd ... n/releases -- UXP also has tagged release bases for the platform code, but if you use git then the correct platform code will automatically be checked out too as a submodule.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Kris_88
Keeps coming back
Keeps coming back
Posts: 932
Joined: 2021-01-26, 11:18

Re: pornhub videos not playing anymore after pm update

Unread post by Kris_88 » 2023-02-25, 11:30

Off-topic:
Yes, I found. Thank you!

Locked