Update changed quick search suggestions list background color Topic is solved

Users and developers helping users with generic and technical Pale Moon issues on all operating systems.

Moderator: trava90

Forum rules
This board is for technical/general usage questions and troubleshooting for the Pale Moon browser only.
Technical issues and questions not related to the Pale Moon browser should be posted in other boards!
Please keep off-topic and general discussion out of this board, thank you!
Nelraen
Hobby Astronomer
Hobby Astronomer
Posts: 19
Joined: 2015-01-27, 22:34
Location: somewhere

Update changed quick search suggestions list background color

Unread post by Nelraen » 2021-11-10, 21:59

Hey,

The very last update seems to have broken something with my old-old-old theme. The background of the quick search (ctrl-e) list of suggestions is now a gradient of grays instead of previous white. Wouldn't be much of a problem, but the text is black, making it pretty much unusable:

Image

I do remember that there were previously fixes for old themes that had a doubled address text, so I hope this can be solved with a greasemonkey/stylish fix, or maybe a minor adjustment for the skin.

Any ideas? I'm using "NASA Night launch" theme. As said, it's old, but still works. Can upload, or try out suggestions, but the search suggestion box is probably broken for all old style skins. This is something I use multiple times a day.

As to what I mean by old, this:

Image

Also, the update said it was a security update, and release notes have nothing on changing theme handling. That doesn't seem to be the case. Again, this is a breaker for me.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-10, 22:17

yes there's a styling issue with autocomplete.
I'll probably build an out-of band release to fix that. soon.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Nelraen
Hobby Astronomer
Hobby Astronomer
Posts: 19
Joined: 2015-01-27, 22:34
Location: somewhere

Re: Update changed quick search suggestions list background color

Unread post by Nelraen » 2021-11-10, 22:20

Thank you for the quick reply, Moonchild!

Nelraen
Hobby Astronomer
Hobby Astronomer
Posts: 19
Joined: 2015-01-27, 22:34
Location: somewhere

Re: Update changed quick search suggestions list background color

Unread post by Nelraen » 2021-11-11, 09:53

Hmm, installed the update, restarted a couple times, unfortunately it does not seem to have solved the issue.

tried the following so far, in hopes it might be somehow "cache" issue:
- restart multiple times
- change between search providers
- change theme to default and then back

Still the same effect.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-11, 11:45

Sorry but I have confirmed that the problem is solved, so this can no longer happen because of this obvious oversight in development last cycle.

Please provide the output of help->troubleshooting information in your reply here so we can have a bit more information about what you're running under and with.

Note: it is also possible the theme specifically styles these popup panels which might have broken because the ID for the pop-up panels has changed in the browser front-end. This should normally never be needed; in that case the theme needs an update to use the updated ID.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

New Tobin Paradigm

Re: Update changed quick search suggestions list background color

Unread post by New Tobin Paradigm » 2021-11-11, 15:30

The theme is NOT a Pale Moon Theme and thus is badly outdated and incompatable.

The user hacked the install manifest and this autocomplete styling thing was a wild goose chase. Unless you are going to tell me private-autocomplete styling was messed up for three years and Ryan, FranklinDB, and I just HAPPENED to miss it for that long.
Last edited by New Tobin Paradigm on 2021-11-11, 15:34, edited 1 time in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-11, 15:33

New Tobin Paradigm wrote:
2021-11-11, 15:30
this autocomplete styling thing was a wild goose chase.
No it wasn't. Styling was clearly wrong and that was definitely a bug that could cause readability issues.
What it wasn't, however, was as urgent as this thread would suggest.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

New Tobin Paradigm

Re: Update changed quick search suggestions list background color

Unread post by New Tobin Paradigm » 2021-11-11, 15:35

And in what Pale Moon theme was it wrong in?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-11, 15:38

All of them, I'd gather.

At the very least the default theme looks like this:
Incorrect search
Incorrect search
incorrect.png (7.78 KiB) Viewed 778 times
Correct
Correct
correct.png (19.7 KiB) Viewed 778 times
Incorrect formfill
Incorrect formfill
pwincorrect.png (4.23 KiB) Viewed 778 times
Correct
Correct
pwcorrect.png (3.76 KiB) Viewed 778 times
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Nelraen
Hobby Astronomer
Hobby Astronomer
Posts: 19
Joined: 2015-01-27, 22:34
Location: somewhere

Re: Update changed quick search suggestions list background color

Unread post by Nelraen » 2021-11-11, 20:58

I'd say it's 99% the theme has that customized as well. It's an old, truly complete classic skin, effecting essentially everything. What was the old and the new ID? I wanted to jump to the repo and try searching, but If I'm correct there's no publicly available git repo for pale moon, only tarballs, so it's a bit hard to pinpoint it, especially as I never looked at the PM source before. Hopefully I can update the theme over the weekend, as the original dev is long gone and I wouldn't be surprised if I'd be the last user.


I have multiple PCs with the same skin, W7/10, 64bit versions mostly, so pasting info from cleanest, newest W10 one. This profile never had NoScript installed. Temporarily changed language to default English, as about:support uses language pack but otherwise changed nothing.


about:support before update:
https://pastebin.com/HSapczq6

after update:
https://pastebin.com/HSapczq6

Goodydino
Keeps coming back
Keeps coming back
Posts: 820
Joined: 2017-10-10, 21:20

Re: Update changed quick search suggestions list background color

Unread post by Goodydino » 2021-11-11, 22:22

What about Darkpitch? That theme changes everything, and it does not need patching for Pale Moon.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-11, 23:14

The relevant panel IDs have changed from

Code: Select all

panel[type="autocomplete"]
panel[type="autocomplete-richlistbox"]
to

Code: Select all

panel[type="private-autocomplete"]
panel[type="private-autocomplete-richlistbox"]
That should allow you to update the theme.
I strongly recommend you keep the old IDs as well because we do plan to streamline it all back into one method later on.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Nelraen
Hobby Astronomer
Hobby Astronomer
Posts: 19
Joined: 2015-01-27, 22:34
Location: somewhere

Re: Update changed quick search suggestions list background color

Unread post by Nelraen » 2021-11-13, 12:58

Thanks, also thanks for the suggestion, it works perfectly. Sent a donation your way of about a day's wages here, though that's only $32.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Update changed quick search suggestions list background color

Unread post by Moonchild » 2021-11-14, 01:02

I really appreciate your support!
I didn't know Hungary had such low wages though. I hope prices of groceries are similarly low.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked