My armhf builds are now failing for 29.3.0

Users and developers helping users with generic and technical Pale Moon issues on all operating systems.

Moderator: trava90

Forum rules
This board is for technical/general usage questions and troubleshooting for the Pale Moon browser only.
Technical issues and questions not related to the Pale Moon browser should be posted in other boards!
Please keep off-topic and general discussion out of this board, thank you!
User avatar
stevenpusser
Project Contributor
Project Contributor
Posts: 903
Joined: 2015-08-01, 18:33

My armhf builds are now failing for 29.3.0

Unread post by stevenpusser » 2021-07-19, 22:40

At least on the OpenSUSE Build Service, on various Debian and Ubuntu releases there that offer that platform build. Gcc version doesn't seem to be a factor, as they all fail with this error:

Code: Select all

 3613s] /usr/src/packages/BUILD/platform/xpcom/reflect/xptcall/md/unix/xptcinvoke_arm.cpp:12:27: error: missing ')' in expression
[ 3613s]  #if !defined(__arm__) && !(defined(LINUX)
[ 3613s]                            ^
[ 3614s] make[7]: *** [/usr/src/packages/BUILD/platform/config/rules.mk:881: xptcinvoke_arm.o] Error 1
[ 3614s] make[7]: Leaving directory '/usr/src/packages/BUILD/obj-armv7l-unknown-linux-gnueabihf/xpcom/reflect/xptcall/md/unix'
[ 3614s] make[6]: *** [/usr/src/packages/BUILD/platform/config/recurse.mk:71: xpcom/reflect/xptcall/md/unix/target] Error 2
[ 3614s] make[6]: *** Waiting for unfinished jobs....
Hopefully, a patch that adds that missing ')' in the correct spot is all that it needs...not that I know where that spot is. Maybe at the end of the line?

New Tobin Paradigm

Re: My armhf builds are now failing for 29.3.0

Unread post by New Tobin Paradigm » 2021-07-19, 22:52

On line 12 of xpcom/reflect/xptcall/md/unix/xptcinvoke_arm.cpp use:

Code: Select all

#if !defined(__arm__) && !defined(LINUX)
LocalPatch for this release for your target and I will patch it on trunk and it will be uplifted for the next minor release.

User avatar
stevenpusser
Project Contributor
Project Contributor
Posts: 903
Joined: 2015-08-01, 18:33

Re: My armhf builds are now failing for 29.3.0

Unread post by stevenpusser » 2021-07-20, 04:17

I tried first before I had to drop offline for 7 hrs just adding the ")" at the end of the line, and had successful builds when I got back just now, but will redo the patch per your instructions and push it as a package maintainer update.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35480
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: My armhf builds are now failing for 29.3.0

Unread post by Moonchild » 2021-07-20, 07:13

Just a dumb typo on my end when removing the Mac stuff. No way for me to test arm builds while doing so.
Sorry about that!
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
stevenpusser
Project Contributor
Project Contributor
Posts: 903
Joined: 2015-08-01, 18:33

Re: My armhf builds are now failing for 29.3.0

Unread post by stevenpusser » 2021-07-20, 19:57

I have figured out how to do arm builds on my Intel I7 laptop, or any other architecture that Debian supports, by using QEMU and sbuild, but the ten times speed penalty that the emulator imposes for non-x86 target arches means that it's much faster to let the OBS do all the builds.

I did make some small changes to the order of build-dependencies and the build procedures that let one set of source files build again for both the standard Debian and the upstream versions, plus the newer Ubuntu releases that have the same "make": Debian 11 bullseye and Sid, Ubuntu Groovy and Hirsute, which insist that their builds can't use multiple threads, but the builds will use multiple threads on the older releases. https://build.opensuse.org/project/show ... emoon-GTK3


User avatar
stevenpusser
Project Contributor
Project Contributor
Posts: 903
Joined: 2015-08-01, 18:33

Re: My armhf builds are now failing for 29.3.0

Unread post by stevenpusser » 2021-08-27, 19:16

Thank you! I'll make a note to remove the arm patch from my future builds.

New Tobin Paradigm

Re: My armhf builds are now failing for 29.3.0

Unread post by New Tobin Paradigm » 2021-08-27, 20:48

Sorry for taking so long to get this fix in the tree.

Locked