Page 1 of 2

Unable to download from GameJolt.com

Posted: 2019-07-20, 17:24
by Tomaso
Anyone know why Pale Moon is unable to download from GameJolt.com?

How to reproduce:

1) Open this page:
https://gamejolt.com/games/double_drago ... te/255630/

2) Click on the "DOWNLOAD" button.

3) In the popup window, click on "No thanks, take me to the download".

* Expected result: The download should initiate.
* Actual result: Nothing happens!

(Tested with Pale Moon v28.6.0.1,x64 and v28.7.0a1,x64-2019-07-18)

--

EDIT:
Clicking on the thumbnails, to view sceenshots/videos, doesn't work either.

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 18:02
by ron_1
I can confirm the behavior. It also doesn't work in Basilisk. Also tried clean profiles in both Pale Moon and Basilisk. Still doesn't work.

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 18:11
by Tomaso
It works just fine in Firefox and SeaMonkey though.
I came up short, using Mozregression too.

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 18:45
by jars_
In PaleMoon v27.9.4 downloading files without problem from this site :o
and Clicking on the thumbnails, to view sceenshots/videos - works as expected.

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 19:25
by New Tobin Paradigm
My BEST guess is something to do with javascript. On Tycho it loads a bunch of compatibility shims and polyfills whereas whatever it thinks we support in UXP is enough to figure we support everything it needs. Thing is, I am not seeing any express script errors and the only thing I can get to emit is the following BUT I have no idea if it is relevant. They MAY be suppressing errors.

You will have to make them aware of it so they can make us aware of what the hell they expect us to support. Anyway:

Code: Select all

Timestamp: 7/20/2019 3:21:24 PM
Warning: A call to document.write() from an asynchronously-loaded external script was ignored.
Source File: https://www.googletagservices.com/tag/js/gpt.js
Line: 1

Timestamp: 7/20/2019 3:21:29 PM
Warning: Strict-Transport-Security: The site specified a header that included an invalid ‘max-age’ directive.
Source File: https://oxp.mxptint.net/OpenX.ashx
Line: 0

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 19:38
by Tomaso
OK, thanks for looking into it.
If no one is able to pinpoint a specific browser issue, during this weekend, I'll send them an e-mail.

Re: Unable to download from GameJolt.com

Posted: 2019-07-20, 19:45
by New Tobin Paradigm
>browser issue

Re: Unable to download from GameJolt.com

Posted: 2019-07-23, 21:51
by Gaming4JC
Did some research on this issue since it hit our applications as well. The problem is larger than GameJolt, since the site is using Vue.js framework.
That lead me to start browsing the Vue.js issue tracker for "FireFox" issues.

Off-topic:
This may be better fit for the UXP Development Forum, but I will describe it here since GameJolt triggers the issue the best.

The issue is their use of a TimeStamp on a click function: https://github.com/vuejs/vue/issues/9446
This was worked around in this commit by detecting FF52's UA: https://github.com/vuejs/vue/commit/7bc ... fa057f9R45

Applying the following UA allows the site to work:

Code: Select all

Mozilla/5.0 (Windows; WOW64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
So, we have several possibilities here:


Re: Unable to download from GameJolt.com

Posted: 2019-07-23, 22:04
by Moonchild
If we do decide to add (yet another) high-resolution time stamp API to DOM, it should also be made sufficiently course to prevent side-channel attacks and Spectre-alike issues on vulnerable hardware.

Short term, vue.js should implement a workaround. They decided to use UA sniffing, then they should make sure their sniffing catches all applicable applications the alternate code path is needed for.

Re: Unable to download from GameJolt.com

Posted: 2019-07-23, 23:08
by Tomaso
Thanks, Gaming4JC.
I'll be using that UA override then (which I can confirm that works), and leave any potential issue reports to you tech guys. :)

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 00:01
by Gaming4JC
Ok. I've opened an issue on the Vue.js bug tracker, we'll see if it goes anywhere. :thumbup:

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 16:56
by Tomaso
That's a thorough report, Gaming4JC. :)
I see that one of the devs is asking for someone to submit a user agent, to temporarely fix the issue, until the timeStamp bug has been safely fixed in UXP.
Perhaps you could formulate the most effective one, Moonchild?

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 18:15
by Moonchild
See viewtopic.php?f=24&t=9077
Note, the vue.js dev is asking for a ready PR, not just supplying a user-agent string. You'll have to do some work because they won't.

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 18:39
by Tomaso
Ah, that's where those UA examples were at.
I remember seeing them before. :)
Maybe there should be a section for them over at http://www.palemoon.org/faq.shtml too?

Anyway, I don't know anything about coding.
How about it, Gaming4JC... feel up to submitting a PR?

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 18:43
by Moonchild
Tomaso wrote:
2019-07-24, 18:39
Anyway, I don't know anything about coding.
Maybe learn a bit?
It's just JavaScript. And it's not like you have to write anything new, just adapt what they already have with an extra check.

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 19:03
by Tomaso
Moonchild wrote:
2019-07-24, 18:43
Maybe learn a bit?
If I were 20+ years younger, perhaps. :)

Re: Unable to download from GameJolt.com

Posted: 2019-07-24, 19:14
by Moonchild
Tomaso wrote:
2019-07-24, 19:03
Moonchild wrote:
2019-07-24, 18:43
Maybe learn a bit?
If I were 20+ years younger, perhaps. :)
You're never too old to learn!

Re: Unable to download from GameJolt.com

Posted: 2019-09-17, 15:56
by Moonchild
OK, so since start.me ran into the same issue with vue.js they are submitting a PR for Pale Moon compat (which involves a UA sniffing regex change, yes, vue.js is still doing that and refusing to do due diligence on their sniffing refusing to keep an updated list of UAs). Should solve this and allow them to upgrade vue.js for the portal.

Re: Unable to download from GameJolt.com

Posted: 2019-09-17, 21:30
by Goodydino
Tomaso wrote:
2019-07-20, 17:24

1) Open this page:
https://gamejolt.com/games/double_drago ... te/255630/
I get a blank page with every browser I have except Safari. I tried disabling the uBlock Origin for that site, and enabling cookies, but that did not help.

Re: Unable to download from GameJolt.com

Posted: 2019-09-17, 22:18
by coffeebreak
Goodydino wrote:
2019-09-17, 21:30
I get a blank page
Page displays fine here.

You'll get a blank page if you either: 1) don't accept cookies from gamejolt.com; or 2) disable local storage; or 3) are blocking requests from gjcdn.net.

Since you've covered no.1 and maybe no.3, check that your local storage setting is: dom.storage.enabled = true .