Toolbar customization issue: can't have empty space at the right of toolbar?

[fr0zensphere]

Admittedly, this is a pretty minor thing. I was trying to customize my toolbar so that there's empty space at the very right of the toolbar. (I just happen to like how it looks.) What I did was I right-click on toolbar -> Customize, and then I dragged the "Space" item from the Customize Toolbar window to the very right. Initially it appears to work, but then every new PM window opened automatically moves the space one slot over to the left, so that I end up with this:

PaleMoon customization issue.png

You see, the space is now between my Ublock Origin icon and the Evernote icon, instead of being to the right of UO icon. I want it to stay to the right of my UO icon. Is it possible to force it do that?

[Lootyhoof]

The icon for uBlock Origin in particular is added with JS after the window is spawned, so no. You could try moving that to another toolbar though.

[vannilla]

This is a funny bug in both uBlock and uMatrix.
I fixed it for my eMatrix fork, so if you use it you can place a spacer after the eMatrix icon.
Maybe you could suggest the same fix for uBlock to its developer?

[JustOff]

I fixed it for my eMatrix fork, so if you use it you can place a spacer after the eMatrix icon.

Sorry, but your fix is incomplete, because it does not take into account the possibility of having multiple spacers, and also does not handle springs and separators that have a similar problem.

I think something like this should do the job:

Code: Select all

            for ( var i = index + 1, special; i < currentset.length; i++ ) {
                if ( (special = /^(spring|spacer|separator)$/.exec(currentset[i])) !== null ) {
                    var spels = toolbar.querySelectorAll('toolbar' + special[1]);
                    var spcnt = currentset.slice(i - currentset.length).filter(s => s == special[1]).length;
                    before = toolbar.querySelector('[id="' + spels[spels.length - spcnt].id + '"]');
                } else {
                    before = toolbar.querySelector('[id="' + currentset[i] + '"]');
                }
                if ( before !== null ) {
                    break;
                }
            }

[vannilla]

I fixed it for my eMatrix fork, so if you use it you can place a spacer after the eMatrix icon.

Sorry, but your fix is incomplete, because it does not take into account the possibility of having multiple spacers, and also does not handle springs and separators that have a similar problem.

You are indeed right, as I didn't consider those cases.
I'll patch it during the week.
Thanks for the report.

[fr0zensphere]

So, to double-check: are you guys saying that the only way for this to be fixed is if the developer(s) of UO fixes this bug?

[vannilla]

So, to double-check: are you guys saying that the only way for this to be fixed is if the developer(s) of UO fixes this bug?

Yes.
If you want a comparison, Adblock Latitude uses the same method to add its icon to the toolbar, but it doesn't have this problem (i.e. you can add spacers and similar after it.)
So it's ultimately a bug in uBlock.

[Giraffe]

The icon for uBlock Origin in particular is added with JS after the window is spawned, so no. You could try moving that to another toolbar though.

When I had trouble with the icon for uBlock disappearing all the while I put it on the top of the Sidebar (using AIOS at the time, now TGOS). The icon stayed put and now, having just tried it, so do spaces on the RHS of the main toolbar.

[JustOff]

So, to double-check: are you guys saying that the only way for this to be fixed is if the developer(s) of UO fixes this bug?

I sent my suggestion to fix this issue to the uBlock Origin author.

[JustOff]

The issue has been solved in uBlock Origin 1.16.4.9.

[fr0zensphere]

I sent my suggestion to fix this issue to the uBlock Origin author.

Whoa, amazing, thanks for doing that!

I downloaded the updated version--looks good.

[Night Wing]

The issue has been solved in uBlock Origin 1.16.4.9.

Thank you for getting in touch with Gorhill so he could fix the issue. It works in both linux and windows Pale Moon. Much appreciated.