I just lost 400 tabs due to Tab Groups deprecation Topic is solved

Users and developers helping users with technical Pale Moon issues (Windows and other non-Linux O.S.). Please direct questions about the Linux version to the appropriate Linux board.

Moderators: trava90, satrow

Forum rules
This board is for technical/usage questions and troubleshooting for the Pale Moon browser only. The main focus here is on Pale Moon on Windows. Please direct your questions for Linux, Android and Mac to the dedicated boards.
Technical issues and questions not related to the Pale Moon browser should be posted in "technical chat"
Please keep off-topic and general discussion out of this board, thank you!
galneon
Hobby Astronomer
Hobby Astronomer
Posts: 23
Joined: Thu, 21 May 2015, 20:40
Location: US

I just lost 400 tabs due to Tab Groups deprecation

Unread postby galneon » Sat, 18 Aug 2018, 02:31

Tab Groups no longer works, so without warning from the auto-updater, I just lost over 400 tabs from my session. KeePass integration is also gone as the newest version that worked with PM no longer loads at all. I've stuck around as long as I could.

fillerup
Lunatic
Lunatic
Posts: 452
Joined: Mon, 19 May 2014, 19:14
Location: Finland

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby fillerup » Sat, 18 Aug 2018, 02:37

really sucks, but also partially your fault for being so careless.. lots of ways you could have prevented that

- making a backup of your profile prior to updating

- bookmarking your open tabs into a folder

- using Sessions Manager to save/restore your sessions

- using an addon (i forgot its name) to back up your list of open tabs into a text file at a set interval

anyway i think Basilisk or Waterfox would be suitable alternatives

User avatar
Isengrim
Astronaut
Astronaut
Posts: 513
Joined: Tue, 08 Sep 2015, 22:54
Location: 127.0.0.1
Contact:

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Isengrim » Sat, 18 Aug 2018, 02:39

Tab Groups has not been intentionally deprecated. It just needs someone to update it. The original author is no longer reasonably able to do so.
Linux Mint 18.3 Cinnamon (64-bit)
Windows 7 (64-bit) (Sometimes)
Windows 10 build 1803 (64-bit) (Sometimes)
We are our choices.

galneon
Hobby Astronomer
Hobby Astronomer
Posts: 23
Joined: Thu, 21 May 2015, 20:40
Location: US

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby galneon » Sat, 18 Aug 2018, 02:44

fillerup wrote:really sucks, but also partially your fault for being so careless.. lots of ways you could have prevented that

- making a backup of your profile prior to updating

- bookmarking your open tabs into a folder

- using Sessions Manager to save/restore your sessions

- using an addon (i forgot its name) to back up your list of open tabs into a text file at a set interval

anyway i think Basilisk or Waterfox would be suitable alternatives


I back up everything nightly and I've just reverted, so only today's session changes were lost. I've worked around so much lost functionality over the years for the sake of supporting PM (which I've recommended to so many people), but at some point, I have to look at the lost time and productivity that has accumulated and conclude it's just not worth it. I'm not going to put anymore time into workarounds or compromises, all to further a mission that has evolved to the point where I no longer keep up with it.

Thanks for the suggestions--I will explore those alternatives (among others probably) tomorrow.

Anyway, it isn't like me to post an "I'm leaving" thread anywhere, so I won't prolong the annoyance for satisfied users any longer. :P

fillerup
Lunatic
Lunatic
Posts: 452
Joined: Mon, 19 May 2014, 19:14
Location: Finland

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby fillerup » Sat, 18 Aug 2018, 07:36

galneon wrote:I've worked around so much lost functionality over the years for the sake of supporting PM

same, but it's only with Pale Moon that i get the functionalities and privacy assurances that i don't have when using other browsers. did PM not provide any of that for you?

between the alternatives, Waterfox has the biggest pool of addons to draw from, so i think you'll be happy with it as a replacement. its longevity is not guaranteed though, and that combined with some quirks i found while using made me switch to Basilisk which i have been quite satisfied with for the past few months. PM 28 will be a powerhouse again when compatibility with some major addons are restored though.

User avatar
therube
Astronaut
Astronaut
Posts: 637
Joined: Fri, 08 Jun 2018, 17:02

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby therube » Sat, 18 Aug 2018, 11:06

(Oh, I see, Tab Groups (Panorama) was a browser feature, not an extension.)

User avatar
Isengrim
Astronaut
Astronaut
Posts: 513
Joined: Tue, 08 Sep 2015, 22:54
Location: 127.0.0.1
Contact:

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Isengrim » Sat, 18 Aug 2018, 11:11

therube wrote:(Oh, I see, Tab Groups (Panorama) was a browser feature, not an extension.)

It was a feature in Firefox that was later removed and converted to an extension by the Mozilla Team. The extension was ported to Pale Moon at some point.
Linux Mint 18.3 Cinnamon (64-bit)
Windows 7 (64-bit) (Sometimes)
Windows 10 build 1803 (64-bit) (Sometimes)
We are our choices.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22305
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Moonchild » Sat, 18 Aug 2018, 11:14

Isengrim wrote:
therube wrote:(Oh, I see, Tab Groups (Panorama) was a browser feature, not an extension.)

It was a feature in Firefox that was later removed and converted to an extension by the Mozilla Team. The extension was ported to Pale Moon at some point.


Um no.
It was a feature in the browser but was removed by us before Mozilla did so, and my Tab Groups extension was created at that point in time. When Mozilla decided to remove the feature later on, someone else did the same thing for Firefox there. That extension was not ported to Pale Moon and is independent of our own efforts.
Last edited by Moonchild on Sat, 18 Aug 2018, 11:16, edited 1 time in total.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

Take note: 23 November is Wolfenoot! Eat roast meat and/or cake decorated like the full moon. #wolfenoot

User avatar
Isengrim
Astronaut
Astronaut
Posts: 513
Joined: Tue, 08 Sep 2015, 22:54
Location: 127.0.0.1
Contact:

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Isengrim » Sat, 18 Aug 2018, 11:18

Moonchild wrote:Um no.
It was a feature in the browser but was removed by us before Mozilla did so, and my Tab Groups extension was created at that point in time. When Mozilla decided to remove the feature later on, someone else did the same thing for Firefox there. That extension was not ported to Pale Moon and is independent of our own efforts.

I stand corrected! My apologies.
Last edited by Isengrim on Sat, 18 Aug 2018, 11:19, edited 1 time in total.
Linux Mint 18.3 Cinnamon (64-bit)
Windows 7 (64-bit) (Sometimes)
Windows 10 build 1803 (64-bit) (Sometimes)
We are our choices.

User avatar
Terkaz
New to the forum
New to the forum
Posts: 1
Joined: Tue, 21 Aug 2018, 18:13

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Terkaz » Tue, 21 Aug 2018, 18:45

Hello! The same thing happened to me. I removed Moonchild’s Tab Groups and replaced it with Quicksaver’s version from Mozilla repository. It work with v28, I don’t have any bugs so far. It also take over settings from Moonchild’s version – I didn’t lose any tabs.

For groups and tabs backup I recommend Tab Groups Helper by Kevin Jones.

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Wed, 22 Aug 2018, 03:55

actually, fix for panorama is freakin' easy:

1. in file "chrome/content/tabview-browser.js" you have to replace string "browser-delayed-startup-finished" at the bottom of the file to "sessionstore-windows-restored".
2. you have to replace all top-level `let`s with `var`s (just in case).
3. in "chrome/content/groupitems.js", replace `getBoundingBox()` implementation with:

Code: Select all

   getBoundingBox: function GroupItems_getBoundingBox(els) {
    var left = 99999999;
    var top = 99999999;
    var right = -99999999;
    var bottom = -99999999;
    for (var el in els) {
      var bounds = iQ(el).bounds();
      for (var b in bounds) {
        left = Math.min(left, b.left);
        top = Math.min(top, b.top);
        right = Math.max(right, b.right);
        bottom = Math.max(bottom, b.bottom);
      }
    }
  },


with these changes panorama will be working again.
Last edited by ketmar on Wed, 22 Aug 2018, 04:29, edited 3 times in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 22305
Joined: Sun, 28 Aug 2011, 17:27
Location: 58.5°N 15.5°E
Contact:

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby Moonchild » Wed, 22 Aug 2018, 18:39

Can you clarify 3? The original function returns a rect -- but this function returns nothing.
Improving Mozilla code: You know you're on the right track with code changes when you spend the majority of your time deleting code.

"If you want to build a better world for yourself, you have to be willing to build one for everybody." -- Coyote Osborne

Take note: 23 November is Wolfenoot! Eat roast meat and/or cake decorated like the full moon. #wolfenoot

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Wed, 22 Aug 2018, 18:59

oops. it is a copy-pasta bug! i'm very sorry. it should end with `return new Rect(left, top, right-left, bottom-top);`, of course.

CraigPD
Lunatic
Lunatic
Posts: 282
Joined: Tue, 01 Jan 2013, 19:03
Location: Mexico

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby CraigPD » Wed, 22 Aug 2018, 21:13

Great strides forward thanks to everyone's contributed patches! :clap: I previewed the pending 0.4 release on GitHub and ask if it's possible to readdress the empty page icons that affected Tab Groups prior to the 0.3 version bump. They have gone missing again though everything else seems completely functional.

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Wed, 22 Aug 2018, 21:31

sorry, i don't think that i understand you. can you please post a "good" and "bad" screenshots? if it is hard for you to produce a "good" screenshot (due to required browser/extension downgrade), just draw some silly ms-paint thingy that should show me what is broken, and how it was before. ;-)

CraigPD
Lunatic
Lunatic
Posts: 282
Joined: Tue, 01 Jan 2013, 19:03
Location: Mexico

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby CraigPD » Wed, 22 Aug 2018, 22:02

Maybe "page icon" is wrong terminology. The same affliction prior to v0.3. I hope this clarifies and thanks again for your efforts.

v0.3 - 27.9.4
TabGroups_0.3_PM27.9.4.jpg

v0.4 - 28.0.0
TabGroups_0.4_PM28.0.0.jpg

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Wed, 22 Aug 2018, 22:37

aha, i see. funny thing: i am using panorama for a long time, but never payed any attention to such icons. no promises are made, but i'll try to look into this issue. i am pretty sure that it is something very trivial to fix. yet it is not trivial to find what to fix, where, and what line should be changed. ;-)

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Wed, 22 Aug 2018, 23:12

oops, posted a wrong patch. anyway, here we go, take two:

Code: Select all

From a112053072e664a7494d0c7d6ba3ca5d30062800 Mon Sep 17 00:00:00 2001
From: Ketmar Dark <ketmar@ketmar.no-ip.org>
Date: Thu, 23 Aug 2018 02:05:25 +0300
Subject: [PATCH] fixed tab icons

---
 src/chrome/content/tabview-content.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/chrome/content/tabview-content.js b/src/chrome/content/tabview-content.js
index ad202c5..d415375 100644
--- a/src/chrome/content/tabview-content.js
+++ b/src/chrome/content/tabview-content.js
@@ -12,16 +12,26 @@ Cu.import("chrome://tabgroups/content/utils.jsm");
 
 // Bug 671101 - directly using webProgress in this context
 // causes docShells to leak
+/*k8: this is deprecated
 __defineGetter__("webProgress", function () {
   let ifaceReq = docShell.QueryInterface(Ci.nsIInterfaceRequestor);
   return ifaceReq.getInterface(Ci.nsIWebProgress);
 });
+*/
+
+// prefixed to avoid clashes
+function k8_WEH_getWebProgress () {
+  let ifaceReq = docShell.QueryInterface(Ci.nsIInterfaceRequestor);
+  return ifaceReq.getInterface(Ci.nsIWebProgress);
+}
+
 
 // ----------
 // WindowEventHandler
 //
 // Handles events dispatched by the content window.
 var WindowEventHandler = {
+
   // ----------
   // Function: onDOMWillOpenModalDialog
   // Sends a synchronous message when the "onDOMWillOpenModalDialog" event
@@ -63,7 +73,7 @@ var WindowMessageHandler = {
   // Checks if the currently active document is loaded.
   isDocumentLoaded: function WMH_isDocumentLoaded(cx) {
     let isLoaded = (content.document.readyState != "uninitialized" &&
-                    !webProgress.isLoadingDocument);
+                    !k8_WEH_getWebProgress().isLoadingDocument);
 
     sendAsyncMessage(cx.name, {isLoaded: isLoaded});
   },
--
2.17.1


with this patch, panorama works flawlessly, shows page icons, and produces no messages in error console. for your pleasure, sir!

CraigPD
Lunatic
Lunatic
Posts: 282
Joined: Tue, 01 Jan 2013, 19:03
Location: Mexico

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby CraigPD » Wed, 22 Aug 2018, 23:57

Thanks much, Ketmar. Waiting for wolfbeast to merge & appreciate the results. So glad you're not abandoning us... yet. :D

User avatar
ketmar
Lunatic
Lunatic
Posts: 357
Joined: Tue, 28 Jul 2015, 11:10
Location: Earth

Re: I just lost 400 tabs due to Tab Groups deprecation

Unread postby ketmar » Thu, 23 Aug 2018, 00:19

i just felt that i should not keep my fixes to panorama to myself only, as i know how painful it is to loose hundreds of your stored tabs. and as i started to do fixes, i thought that i should finish it all. ;-)

Off-topic:
that is, i stopped developing my own extensions, but i didn't fully moved away: Pale Moon is the best browser on the planet, so i'll be using it, and will be lurking here for a long time. ;-)
Last edited by ketmar on Thu, 23 Aug 2018, 00:34, edited 2 times in total.


Return to “General support”

Who is online

Users browsing this forum: No registered users and 10 guests