Pale Moon 28.13.0 crashes on PBS.org site

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
BookMark
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2014-08-23, 05:54
Location: Boston

Pale Moon 28.13.0 crashes on PBS.org site

Unread post by BookMark » 2020-09-12, 00:31

I discovered this odd effect on my primary PC, which is running 28.13.0-64 on Windows 10 (v2004). Not a site I normally use, so I can't be certain if this is only related specifically to that latest version. Connecting to any variation of pbs.org (which will redirect to https://www.pbs.org) opens the site apparently normally. They have something running some sort of geolocation which attempts to find the closest PBS station. As soon as the mouse cursor is moved onto the web page, PM crashes instantly. When PM is re-opened it shows the recovery screen, and any sites open prior to the crash - but not pbs.org. I tried running PM in safe mode and it did not crash. I then tried instead disabling all extensions, and it still crashed.

Next I downloaded Pale Moon Portable 28.13.0 32 bit and 64 bit - both crashed in the same way.

I then moved to another PC still running PM 28.9.0.2-64. It did not crash on the pbs.org site. However running PM Portable 28.13.0 from a USB stick on that same PC - instant crash.

Today I had the chance to try the USB stick PM portable 28.13.0 on 3 other PC's - 2 Win 10 PC's and 1 Win 8.1 PC. PM crashed on the Win 8.1 PC and only one of the Win 10 PC's.

On all of the PC's above, I also tried PM Portable 28.9.3 which I already had on USB and it did not crash on any PC.

In all instances, the site loads with the attempt to display the closest PBS station, and stays loaded until the mouse is moved anywhere onto the displayed page.

User avatar
ron_1
Moon Magic practitioner
Moon Magic practitioner
Posts: 2859
Joined: 2012-06-28, 01:20

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by ron_1 » 2020-09-12, 02:05

BookMark wrote:
2020-09-12, 00:31
I tried running PM in safe mode and it did not crash. I then tried instead disabling all extensions, and it still crashed.
With this bit of info, it might be useful to list what extensions you're using.

Using your link, I visited the site and I got no crash. I had to disable uBlock Origin to get the geolocation thing. It didn't crash, neither before nor after disabling uBo. Not sure if it makes a difference, but I'm on Linux.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by coffeebreak » 2020-09-12, 02:16

No crash here either. (PM 28.13, Win 7 x86)
BookMark wrote:
2020-09-12, 00:31
I tried running PM in safe mode and it did not crash. I then tried instead disabling all extensions, and it still crashed.
Safe mode does a few things besides disable extensions.

What happens if you disable hardware acceleration?
(Requires a restart)

User avatar
jars_
Lunatic
Lunatic
Posts: 399
Joined: 2016-12-27, 00:12

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by jars_ » 2020-09-12, 04:12

Win7x64 + PM 28.13.0x64 - crash.

Clean profile:

Code: Select all

@echo off
set PROF=%~dp0Profiles\%RANDOM%
start "" /D "%~dp0" "palemoon.exe" -no-remote -profile "%PROF%"
- crash.

CleanProfile + SafeMode :

Code: Select all

@echo off
set PROF=%~dp0Profiles\%RANDOM%
start "" /D "%~dp0" "palemoon.exe" -no-remote -safe-mode -profile "%PROF%"
= ok, page loads normally.

BookMark
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2014-08-23, 05:54
Location: Boston

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by BookMark » 2020-09-12, 04:41

coffeebreak wrote:
2020-09-12, 02:16
No crash here either. (PM 28.13, Win 7 x86)
BookMark wrote:
2020-09-12, 00:31
I tried running PM in safe mode and it did not crash. I then tried instead disabling all extensions, and it still crashed.
Safe mode does a few things besides disable extensions.

What happens if you disable hardware acceleration?
(Requires a restart)
Very good - disabling hardware acceleration prevented the crash on the 3 PC's that are mine. But there is little in common between all ofthese PC's. They are different models with different video cards. Mine are a Dell desktop running Win 10, an HP desktop running Win 10, and a home-built system running Win 8.1. (The other 2 are Win 10 PC's at another location which I won't be back to very soon. It was one of those that did not crash.) Only 2 have Pale Moon installed on them - my Win 10 PC's.

I have been testing with PM Portable 28.13.0-64 on a USB stick, with no profile or extensions, which crashed 4 of the 5 PC's. However testing with PM Portable 28.9.3-64 on USB did not result in any crashes, even though acceleration was enabled. So there has to be some difference in the way PM implements the hardware acceleration in 28.13.0 vs 28.9.3.

One other small thing that might affect other folks testing - the PBS.org screen correctly suggests WGBH as my local PBS station, so it is possible it sets up a link to WGBH in the background.

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2986
Joined: 2015-09-26, 04:51
Location: U.S.

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by coffeebreak » 2020-09-12, 05:31

BookMark wrote:
2020-09-12, 04:41
disabling hardware acceleration prevented the crash on the 3 PC's that are mine. But there is little in common between all ofthese PC's. They are different models with different video cards.
That would need to be looked at by someone more knowledgeable than myself.

You can help by providing information re your three computers/browser environments where Pale Moon crashed:

Please read the sticky at the top of the General support board, [IMPORTANT!] Information to include when asking for support, and provide the information detailed there for your three computers. Paste the information into your post in three chunks, one for each computer, and put each chunk of text inside it's own "hide" tags.

As also requested in that sticky, please provide a report from NirSoft's AppCrashView for each of your three computers:
  • "If you get application crashes, use AppCrashView to check the details of the app crash and post them"

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35640
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Moonchild » 2020-09-12, 08:24

A quick check in Basilisk also shows the crash which seems to be a null dereference crash. I'll see if I can debug it locally.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35640
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Moonchild » 2020-09-12, 08:45

Try setting layout.css.clip-path-shapes.enabled to false in about:config and see if that resolves the crash?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
ron_1
Moon Magic practitioner
Moon Magic practitioner
Posts: 2859
Joined: 2012-06-28, 01:20

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by ron_1 » 2020-09-12, 14:48

Why are some people getting a crash and some aren't?

User avatar
jars_
Lunatic
Lunatic
Posts: 399
Joined: 2016-12-27, 00:12

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by jars_ » 2020-09-12, 14:49

Try setting layout.css.clip-path-shapes.enabled to false in about:config and see if that resolves the crash?
for me yes!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35640
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Moonchild » 2020-09-12, 14:57

ron_1 wrote:
2020-09-12, 14:48
Why are some people getting a crash and some aren't?
Because some crashes are intermittent and depend on many things. In this case it's obviously related to how paths/masks are rendered. Likely it is a web design problem (e.g. having such narrow clipping that it rounds to zero on some hardware, for example) but we shouldn't be crashing as a result.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35640
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Moonchild » 2020-09-12, 14:58

jars_ wrote:
2020-09-12, 14:49
Try setting layout.css.clip-path-shapes.enabled to false in about:config and see if that resolves the crash?
for me yes!
OK, so looks like I may have to disable the clip paths again until we figure out the crash. Tracking in Issue #1650 (UXP).
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite


BookMark
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2014-08-23, 05:54
Location: Boston

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by BookMark » 2020-09-13, 05:59

Moonchild wrote:
2020-09-12, 08:45
Try setting layout.css.clip-path-shapes.enabled to false in about:config and see if that resolves the crash?
Yes, that fixes it.

New Tobin Paradigm

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by New Tobin Paradigm » 2020-09-13, 06:36

... It doesn't fix anything.. It merely bypasses the codepath for the feature that has the missing null check that results in a possible crash. The FIX has been done in the code and will be in the next release.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35640
Joined: 2011-08-28, 17:27
Location: Motala, SE

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Moonchild » 2020-09-13, 07:47

Just remember to flip the preference back to default after you've upgraded, so your workaround doesn't hinder proper use of the feature on other websites.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Tharthan
Board Warrior
Board Warrior
Posts: 1411
Joined: 2019-05-20, 20:07
Location: New England

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Tharthan » 2020-09-13, 20:18

Thanks for always being on top of this stuff, Moonchild.

PBS's website is a very important one to be able to visit, so it is good that this problem will be fixed next release.
"This is a war against individuality and intelligence. Only thing we can do is stand strong."adesh, 9 January 2020

"I used to think I was a grumpy old man, but I don't hold a candle compared to Tharthan."Cassette, 9 September 2020

Image

BookMark
Apollo supporter
Apollo supporter
Posts: 31
Joined: 2014-08-23, 05:54
Location: Boston

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by BookMark » 2020-09-14, 02:21

Moonchild wrote:
2020-09-13, 07:47
Just remember to flip the preference back to default after you've upgraded, so your workaround doesn't hinder proper use of the feature on other websites.
I only changed the setting to verify that it stopped the crashing, and then set it back to default. I can change again if needed.

New Tobin Paradigm

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by New Tobin Paradigm » 2020-09-14, 08:57

Just remember that any workaround be it flipping a pref or a ua override or whatnot != a fix.

User avatar
Tharthan
Board Warrior
Board Warrior
Posts: 1411
Joined: 2019-05-20, 20:07
Location: New England

Re: Pale Moon 28.13.0 crashes on PBS.org site

Unread post by Tharthan » 2020-09-14, 18:39

If this was an error on their end, then it is probable that the only way a true fix would happen would be if PBS actually tried to work on their own site so that this problem didn't occur.

But PBS being what it is, and being as well=known, respected, and utilised as it is, they don't have much incentive to go out of their way for "the little guy".
Last edited by Tharthan on 2020-09-14, 20:07, edited 1 time in total.
"This is a war against individuality and intelligence. Only thing we can do is stand strong."adesh, 9 January 2020

"I used to think I was a grumpy old man, but I don't hold a candle compared to Tharthan."Cassette, 9 September 2020

Image