webrtc bug

[Fedor2]

You can check it on the Basilisk only because webrtc disabled in Palemoon.
file - media\webrtc\signaling\src\media-conduit\VideoConduit.cpp

~WebrtcVideoConduit() has SyncTo(nullptr); which is coded as

Code: Select all

    mPtrViEBase->DisconnectAudioChannel(mChannel);
    mPtrViEBase->SetVoiceEngine(nullptr);

meanwhile DeleteStreams() has

Code: Select all

mPtrViEBase = nullptr;

and executed earlier ~WebrtcVideoConduit(), so you get excpetion 0xc0000005 in result
I moved SyncTo(nullptr) to DeleteStreams() before mPtrViEBase = nullptr and bug seems gone, what do you think o this.

[Moonchild]

I think this would be a good thing to make a GitHub issue for, then file a PR for

[Fedor2]

Done - issue #1558