28.6.1 pipelining crash

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
pmuser2
Hobby Astronomer
Hobby Astronomer
Posts: 26
Joined: 2018-02-09, 04:35

28.6.1 pipelining crash

Unread post by pmuser2 » 2019-08-22, 08:27

I wanted to open a site in LAN with NTLM authentication in Palemoon, added the domain to network.automatic-ntlm-auth.trusted-uris.

Palemoon crashes opening specific page of that site.
Windows version: 10, 1903. Windows event log data:

Faulting application name: palemoon.exe, version: 4.3.0.7143, time stamp: 0x5d372a42
Faulting module name: xul.dll, version: 4.3.0.7143, time stamp: 0x5d372c31
Exception code: 0xc0000005
Fault offset: 0x00000000004eca84 (usually, sometimes 0x00000000004e10c4)
Last edited by pmuser2 on 2019-08-22, 10:30, edited 2 times in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: 28.6.1 (64-bit) NTLM crash

Unread post by Moonchild » 2019-08-22, 08:34

Please provide a crash dump of this, since I won't be able to recreate the specific crash circumstances. Preferably one for each crash offset seen.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

pmuser2
Hobby Astronomer
Hobby Astronomer
Posts: 26
Joined: 2018-02-09, 04:35

Re: 28.6.1 (64-bit) NTLM crash

Unread post by pmuser2 » 2019-08-22, 08:49

I tried to open the page without NTLM, manually entering username and password — Palemoon still crashes.
Crash dump attached.
Last edited by pmuser2 on 2019-08-22, 09:15, edited 1 time in total.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: 28.6.1 (64-bit) NTLM crash

Unread post by Moonchild » 2019-08-22, 09:03

Thanks.

I don't see how this crash can happen. It occurs in the http pipelining part; the connection is yanked out from under us while trying to push data to it. This can happen with bad behaving proxies but we already specifically check for that in our code before trying to continue...

Are you using non-default settings for http pipelining? Are you using a proxy?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

pmuser2
Hobby Astronomer
Hobby Astronomer
Posts: 26
Joined: 2018-02-09, 04:35

Re: 28.6.1 (64-bit) NTLM crash

Unread post by pmuser2 » 2019-08-22, 09:19

No explicit proxy server specified in Palemoon, but most likely there is one in-between.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: 28.6.1 (64-bit) NTLM crash

Unread post by Moonchild » 2019-08-22, 09:33

Well, there's no code solution that I can see; it seems that whatever is proxying your traffic (could be endpoint security or what not) is not holding the connection open properly for pipelining and somehow yanks it out right between the connection check and connection use (literally the following instruction).

Please disable pipelining for your use as a workaround.

P.S.: It's not recommended to install Pale Moon in %AppData%/local -- you're taking a risk by having the browser binaries installed in an unprotected location.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

pmuser2
Hobby Astronomer
Hobby Astronomer
Posts: 26
Joined: 2018-02-09, 04:35

Re: 28.6.1 (64-bit) NTLM crash

Unread post by pmuser2 » 2019-08-22, 09:46

Yes, disabling pipelining works.
It's interesting that neither Firefox, nor Chrome crash at that page.
Also, no other page I visited makes Palemoon crash with pipelining.

yami_

Re: 28.6.1 (64-bit) NTLM crash

Unread post by yami_ » 2019-08-22, 09:47

AFAIK both Chrome and Firefox do not support HTTP pipelining.

User avatar
therube
Board Warrior
Board Warrior
Posts: 1651
Joined: 2018-06-08, 17:02

Re: 28.6.1 pipelining crash

Unread post by therube » 2019-08-22, 10:53

Older did, network.http.pipelining.
AFAIK, it was always considered experimental, never defaulted to 'true', & expected that it might cause issues.

Quantum does not have it.
(Chrome, I wouldn't have a clue.)

New Tobin Paradigm

Re: 28.6.1 pipelining crash

Unread post by New Tobin Paradigm » 2019-08-22, 11:20

Wasn't pipelining effectively obsoleted by http/2 or am I thinking of SPDY?

yami_

Re: 28.6.1 pipelining crash

Unread post by yami_ » 2019-08-22, 11:26

IDK about SPDY but HTTP/2 does include a mode of operation similar to pipelining called multiplexing.

User avatar
Admin
Site Admin
Site Admin
Posts: 405
Joined: 2012-05-17, 19:06

Re: 28.6.1 pipelining crash

Unread post by Admin » 2019-08-22, 11:42

New Tobin Paradigm wrote:
2019-08-22, 11:20
Wasn't pipelining effectively obsoleted by http/2 or am I thinking of SPDY?
Pipelining works over plain http. http/2.0 multiplexing is only made available for https. Same with SPDY: https only.
Did you know that moral outrage triggers the pleasure centers of the brain? It's unlikely you can actually get addicted to outrage, but there is plausible evidence that you can become strongly predisposed to it.
Source: https://www.bbc.co.uk/programmes/p002w557/episodes/downloads - "The cooperative species" and "Behaving better online"
Image

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: 28.6.1 pipelining crash

Unread post by Moonchild » 2019-08-22, 13:49

therube wrote:
2019-08-22, 10:53
AFAIK, it was always considered experimental, never defaulted to 'true', & expected that it might cause issues.
It was never enabled by default in Firefox, but has been enabled by default in Pale Moon for many years. The only "issues" there have ever been have been with proxies that didn't implement it properly (pipelining is an integral part of the HTTP/1.1 standard!), which is why pipelining over proxies (if Pale Moon knows about it, i.e.: it's not a transparent system-wide proxy) has been disabled by default.
Mozilla has always been very afraid about the potential "head of line" issue with pipelining (i.e. a request in the pipeline being slow and blocking what is waiting to be transferred through the same pipeline after it) but in practice, especially with the various rescheduling algorithms in place to make new requests if delayed too much, it's never been a problem.

I do have to wonder though: this crash, does it occur over http or https? If https, then it might be an issue with competing protocols (http/2 vs. pipelining) and it might be an idea to disable ssl pipelining with alternative request grouping being commonplace now with http/2...
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

pmuser2
Hobby Astronomer
Hobby Astronomer
Posts: 26
Joined: 2018-02-09, 04:35

Re: 28.6.1 pipelining crash

Unread post by pmuser2 » 2019-08-23, 09:51

That page's and all its resources' URIs have HTTP scheme, not HTTPS.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35602
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: 28.6.1 pipelining crash

Unread post by Moonchild » 2019-08-23, 11:34

OK, then what I wondered about is not the case and you're likely dealing with a misbehaving transparent proxy in your environment causing the crash.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

Locked