PM28.5.0: When tab bar is not visible in "normal" mode, it also doesn't show in customize mode

The place to report Pale Moon specific bugs on the Windows operating system.

Moderator: satrow

Locked
coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2067
Joined: 2015-09-26, 04:51
Location: U.S.

PM28.5.0: When tab bar is not visible in "normal" mode, it also doesn't show in customize mode

Post by coffeebreak » 2019-05-01, 18:50

When PM 28.5.0 is set to hide the tab bar when only one tab is open, the tab bar is also getting hidden in "customize mode" when only one tab is open. (If additional tabs are opened, or if the preference is changed, the tab bar is accessible again in customize mode.) In PM 28.4.1, the tab bar was accessible in customize mode regardless of that setting.

Starting with new profile:
  • Pale Moon 28.5.0 > Preferences > Tabs > deselect "Always show the tab bar" (browser.tabs.autoHide = true);
  • Have only one tab open;
  • Open customize mode: the tab bar is not visible there;
  • Expected: that although the tab bar was hidden in normal view due to the preference and just one tab open, it would still be accessible in customize mode.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 25683
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: PM28.5.0: When tab bar is not visible in "normal" mode, it also doesn't show in customize mode

Post by Moonchild » 2019-05-02, 14:55

This is a corner case that simply isn't taken into account in customize mode. If you need access to the bar you have automatically hidden, just open a second tab (although I'm not sure why you'd need access to it if you are obviously mainly using windowed browsing with the tab bar collapsed -- what are you going to put on it that won't be visible?)
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

coffeebreak
Moon Magic practitioner
Moon Magic practitioner
Posts: 2067
Joined: 2015-09-26, 04:51
Location: U.S.

Re: PM28.5.0: When tab bar is not visible in "normal" mode, it also doesn't show in customize mode

Post by coffeebreak » 2019-05-02, 19:05

I don't use windowed browsing exclusively, or nearly exclusively.
I'm a light tab user, but use both windowed browsing and windows with multiple tabs about equally.

The use would be to move the "new tab button" (or in theory the "all tabs button") on or off the tab bar.

I noticed what to me is a bug while setting up a fresh portable version.
Because it was new, I was going through the settings available in the UI to make adjustments, in Preferences and Customize, in no special order. I didn't open multiple tabs to do this, there was no reason to.

Typically, I hide the tab bar for only one tab open, and also remove the "New Tabs Button" from the tab bar.
Happens, I went through Preferences first, then Customize.
Intended to remove the new tab button, but (until some problem solving) couldn't because it was not accessible.

This is not how I'd seen Customize behave in the past, and from my perspective some functionality is broken.

Moonchild wrote:
2019-05-02, 14:55
This is a corner case that simply isn't taken into account in customize mode.
But this corner case was taken account of through PM 28.4.1, or behaved like it was.

The breakage in Customize is presumably caused by this from v28.5.0 (2019-04-30):
Fixed border drawing when the tab bar is hidden

Can't this work be done in a way that doesn't impair functionality in Customize ?

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 25683
Joined: 2011-08-28, 17:27
Location: 58°2'16"N 14°58'31"E
Contact:

Re: PM28.5.0: When tab bar is not visible in "normal" mode, it also doesn't show in customize mode

Post by Moonchild » 2019-05-02, 23:56

I wasn't aware that this was a regression. I assumed it never worked before.

EDIT: Opened Issue #1072 (UXP) to track this.
"There will be times when the position you advocate, no matter how well framed and supported, will not be accepted by the public simply because you are who you are." -- Merrill Rose
Image

Locked