Page rendering issue (Pale Moon v28.3.0) Topic is solved

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-16, 16:19

The problem is even worse at this subpage:
https://www.vg.no/sport/

In PM v28.3.0, only a few images at the top loads successfully, while the rest fails completely!
Scrolling down and up again doesn't help, neither does refreshing the page.
And like before, the page loads just fine in PM v28.2.2 and other browsers.

@Moonchild:
There are no errors in the console at this subpage.
Perhaps you could troubleshoot the issue there?

van p
Astronaut
Astronaut
Posts: 595
Joined: 2015-11-19, 07:15
Location: Cincinnati, OH, U.S.A.

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by van p » 2019-01-16, 17:08

Tried the subpage. Seems OK to me.
Windows 10 Pro x64 v22H2 8GB i5-4570|Pale Moon v33.0.2 x64

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-16, 17:12

We've already established that this particular issue might be OS dependent.

JustOff

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by JustOff » 2019-01-16, 17:14

Tomaso wrote:The problem is even worse at this subpage:
https://www.vg.no/sport/
I can confirm that (Pale Moon x32; Win7x64).

I also tried to reverse Issue #903 (UXP) and found it is not related. Further investigation required.

PS: Both 28.2.2 and 28.3.0 produce several errors in the console, but they are exactly the same, so it seems they are not related to the problem.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-16, 17:45

Thanks for confirming, and for ruling out that commit, JustOff.
I ran a bunch of FF builds through mozregression earlier, but weren't able to find a single build that was affected.

JustOff

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by JustOff » 2019-01-16, 17:47

I thinks this problem is caused by the enabling of the Intersection Observer API, see Issue #249 (UXP).

When dom.IntersectionObserver.enabled is false, https://www.vg.no/sport/ is displayed fine on 28.3.0.

User avatar
badnick
Astronaut
Astronaut
Posts: 670
Joined: 2017-03-23, 19:56

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by badnick » 2019-01-16, 17:50

Tomaso wrote:The problem is even worse at this subpage:
https://www.vg.no/sport/
Yes, this doen't work.
Windows 10 pro /64 (version 1809)
PM last/64

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-16, 18:01

JustOff wrote:I thinks this problem is caused by the enabling of the Intersection Observer API, see Issue #249 (UXP).

When dom.IntersectionObserver.enabled is false, https://www.vg.no/sport/ is displayed fine on 28.3.0.
Confirmed! :thumbup:
Thanks a bunch for troubleshooting this, JustOff!
Guess the only thing that remains now is to find the faulty commit?
VG.no is the largest news site here in Norway, so if this issue remains unfixed, Pale Moon will probably loose some users.

User avatar
therube
Board Warrior
Board Warrior
Posts: 1651
Joined: 2018-06-08, 17:02

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by therube » 2019-01-17, 01:11

I started looking again before realizing you'd already figured out a "fix", so even though you don't like it, "me to".
Confirmed. Toggling dom.IntersectionObserver.enabled "fixes" it.

And I'd also like to say, damn, some of you guys are really good :-).

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Moonchild » 2019-01-17, 02:31

Just because it has "lazy" in it doesn't mean it's related.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Moonchild » 2019-01-17, 13:50

The question is then: is this because of a bug in our implementation of intersectionobservers, or is it a bug in how the site tries to use them?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

yami_

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by yami_ » 2019-01-17, 14:04

Last time I have checked some things were missing form UXP implementation (viewtopic.php?f=3&t=20208&p=153048#p152820). But that was a few months ago.

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-17, 14:20

Moonchild wrote:The question is then: is this because of a bug in our implementation of intersectionobservers, or is it a bug in how the site tries to use them?
At least, the fact that no other browsers than PM28.3 seems to be affected by this issue, points to the former.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Moonchild » 2019-01-17, 16:33

yami_ wrote:Last time I have checked some things were missing form UXP implementation (viewtopic.php?f=3&t=20208&p=153048#p152820). But that was a few months ago.
I've done a lot of work on them to align with the spec recently. I didn't see any other BZ bugs related to them so gathered what I had was complete.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35593
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Moonchild » 2019-01-17, 17:22

Looks like we may be missing an API property which was added because web devs apparently have trouble grasping that "0% intersection == not intersecting"... :crazy: :roll:
I'm on it.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Tomaso
Board Warrior
Board Warrior
Posts: 1622
Joined: 2015-07-23, 16:09
Location: Norway

Re: Page rendering issue (Pale Moon v28.3.0)

Unread post by Tomaso » 2019-01-17, 19:58

Thanks for fixing this, Moonchild!
I'm glad it turned out to be a PM issue, since issues can be reported here, and actually gets fixed when confirmed by devs.
If it had been a website issue, it would have been a real problem, since most webmasters never listens to user feedback (except perhaps when it comes from Chrome users).

Since the fix has been confirmed working by JustOff (@ GitHub), I'm marking this as "solved"! :thumbup:

Locked