Page 1 of 1

v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-09-23, 14:44
by LigH1L
In the release notes you also mentioned:
  • Fixed tab previews in the Windows taskbar (if enabled).
Interesting, since this version the favicons displayed in each tab are not displayed in the taskbar list anymore if I do not use Aero Glass with Aero Peak, but only Aero Basic designs in Windows 7 SP1.

Here a sample of my taskbar preview list, using two windows with several tabs each.
PaleMoon_AeroBasic_Taskbar.png
I remember that I reported just the same issue before to the Mozilla Firefox bug tracker, where it got fixed...

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-09-29, 16:50
by LigH1L
Not even a confirmation yet?

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-09-29, 23:54
by Moonchild
Anything in the browser console/error console?

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-09-30, 08:16
by LigH1L
I started Pale Moon in Safe Mode to avoid add-ons interfering.

Browser Console:

Code: Select all

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.  
(unknown)
[bugsnag] Loaded!  
application-908b5c27f491a4d5ed17.js:1:776617
An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing  
container.html:8
pixel.everesttech.net : server does not support RFC 5746, see CVE-2009-3555  
(unknown)
Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”  
browser.xul
Several more warnings in the Error Console, but AFAICS only CSS warnings.

Do you log Windows API errors at all? I doubt they would appear here.

BTW, the tabs contain all favicons. Only the taskbar list doesn't. Just like the linked old Firefox bug reports.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-09-30, 10:11
by Moonchild
The Firefox bug existed because someone forgot to rename a calling site when refactoring. That refactoring is not present in our tree and as a result that bug isn't, either.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-10-02, 07:14
by Scribe
Running Win7 Home Premium (64bit) I can confirm the blank favicons in PM 28.1.0, (they are present in Fx 62.0.2).

I can also confirm that on Win10 Home (1803) the thumbnails that just showed a loading throbber prior to PM 28.1.0 now show thumbnail images as expected.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-10-02, 11:09
by Moonchild
Created Issue #809 (UXP) to track this regression.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-10-03, 11:34
by LigH1L
Thank you, will watch this issue.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-11-14, 08:05
by LigH1L
Not yet fixed in 28.2.0.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-11-15, 06:55
by Nigaikaze
LigH1L wrote:Not yet fixed in 28.2.0.
Of course not, since that GitHub issue is still open.

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-11-15, 07:06
by Moonchild
LigH1L wrote:Not yet fixed in 28.2.0.
What is it with people and this release expecting things to have somehow magically resolved themselves?

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Posted: 2018-11-15, 07:23
by LigH1L
:cry: I don't expect magic from humans. It was just feedback; no demand, no blame. At most a patient reminder. But maybe I have a talent for making myself misunderstood for the worst.

Take the time you need. I will stop my feedback until it's done. :silent: