v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Talk about code development, features, specific bugs, enhancements, patches, and similar things.
Forum rules
Please keep everything here strictly on-topic.
This board is meant for Pale Moon source code development related subjects only like code snippets, patches, specific bugs, git, the repositories, etc.

This is not for tech support! Please do not post tech support questions in the "Development" board!
Please make sure not to use this board for support questions. Please post issues with specific websites, extensions, etc. in the relevant boards for those topics.

Please keep things on-topic as this forum will be used for reference for Pale Moon development. Expect topics that aren't relevant as such to be moved or deleted.
User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-09-23, 14:44

In the release notes you also mentioned:
  • Fixed tab previews in the Windows taskbar (if enabled).
Interesting, since this version the favicons displayed in each tab are not displayed in the taskbar list anymore if I do not use Aero Glass with Aero Peak, but only Aero Basic designs in Windows 7 SP1.

Here a sample of my taskbar preview list, using two windows with several tabs each.
PaleMoon_AeroBasic_Taskbar.png
I remember that I reported just the same issue before to the Mozilla Firefox bug tracker, where it got fixed...
Last edited by LigH1L on 2018-09-23, 14:52, edited 1 time in total.
Fun and success!

User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-09-29, 16:50

Not even a confirmation yet?
Fun and success!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Moonchild » 2018-09-29, 23:54

Anything in the browser console/error console?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-09-30, 08:16

I started Pale Moon in Safe Mode to avoid add-ons interfering.

Browser Console:

Code: Select all

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.  
(unknown)
[bugsnag] Loaded!  
application-908b5c27f491a4d5ed17.js:1:776617
An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing  
container.html:8
pixel.everesttech.net : server does not support RFC 5746, see CVE-2009-3555  
(unknown)
Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”  
browser.xul
Several more warnings in the Error Console, but AFAICS only CSS warnings.

Do you log Windows API errors at all? I doubt they would appear here.

BTW, the tabs contain all favicons. Only the taskbar list doesn't. Just like the linked old Firefox bug reports.
Fun and success!

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Moonchild » 2018-09-30, 10:11

The Firefox bug existed because someone forgot to rename a calling site when refactoring. That refactoring is not present in our tree and as a result that bug isn't, either.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
Scribe
Moon lover
Moon lover
Posts: 80
Joined: 2016-01-29, 09:35
Location: West London, England

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Scribe » 2018-10-02, 07:14

Running Win7 Home Premium (64bit) I can confirm the blank favicons in PM 28.1.0, (they are present in Fx 62.0.2).

I can also confirm that on Win10 Home (1803) the thumbnails that just showed a loading throbber prior to PM 28.1.0 now show thumbnail images as expected.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Moonchild » 2018-10-02, 11:09

Created Issue #809 (UXP) to track this regression.
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-10-03, 11:34

Thank you, will watch this issue.
Fun and success!

User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-11-14, 08:05

Not yet fixed in 28.2.0.
Fun and success!

User avatar
Nigaikaze
Board Warrior
Board Warrior
Posts: 1322
Joined: 2014-02-02, 22:15
Location: Chicagoland

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Nigaikaze » 2018-11-15, 06:55

LigH1L wrote:Not yet fixed in 28.2.0.
Of course not, since that GitHub issue is still open.
Nichi nichi kore ko jitsu = Every day is a good day.

User avatar
Moonchild
Pale Moon guru
Pale Moon guru
Posts: 35474
Joined: 2011-08-28, 17:27
Location: Motala, SE
Contact:

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by Moonchild » 2018-11-15, 07:06

LigH1L wrote:Not yet fixed in 28.2.0.
What is it with people and this release expecting things to have somehow magically resolved themselves?
"Sometimes, the best way to get what you want is to be a good person." -- Louis Rossmann
"Seek wisdom, not knowledge. Knowledge is of the past; wisdom is of the future." -- Native American proverb
"Linux makes everything difficult." -- Lyceus Anubite

User avatar
LigH1L
Fanatic
Fanatic
Posts: 122
Joined: 2013-02-22, 19:08
Location: rural central Germany

Re: v28.1.0: Taskbar preview fix breaks taskbar icons in W7 Aero Basic

Unread post by LigH1L » 2018-11-15, 07:23

:cry: I don't expect magic from humans. It was just feedback; no demand, no blame. At most a patient reminder. But maybe I have a talent for making myself misunderstood for the worst.

Take the time you need. I will stop my feedback until it's done. :silent:
Fun and success!

Locked